[Impala-ASF-CR] IMPALA-6201: Fix test basic filters on ASAN

2017-11-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8646 ) Change subject: IMPALA-6201: Fix test_basic_filters on ASAN .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2017-11-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2017-11-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 6: (13 comments)

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2017-11-28 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 6: (12 comments)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-29 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8270 to look at the new patch set (#7). Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos ..

[Impala-ASF-CR] Update incubator-impala -> impala URLs

2017-11-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8685 ) Change subject: Update incubator-impala -> impala URLs .. Patch Set 1: Code-Review+1 Checked some URLs and confirmed that they work.

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-04 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8472 to look at the new patch set (#5). Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-04 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8472 to look at the new patch set (#6). Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 6: Code-Review+2 (1

[Impala-ASF-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8760 ) Change subject: [security] Make the kerberos principal configurable for Kudu servers .. Patch Set 1: This is the cherry-pick required

[Impala-ASF-CR] IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS be principal is set

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8761 ) Change subject: IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS_be_principal is set .. Patch Set 1:

[Impala-ASF-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has removed Dan Burkert from this change. ( http://gerrit.cloudera.org:8080/8760 ) Change subject: [security] Make the kerberos principal configurable for Kudu servers .. Removed reviewer Dan Burkert. -- To

[Impala-ASF-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has removed Alexey Serbin from this change. ( http://gerrit.cloudera.org:8080/8760 ) Change subject: [security] Make the kerberos principal configurable for Kudu servers .. Removed reviewer Alexey Serbin. -- To

[Impala-ASF-CR] IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS be principal is set

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8761 Change subject: IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS_be_principal is set .. IMPALA-6256:

[Impala-ASF-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8760 ) Change subject: [security] Make the kerberos principal configurable for Kudu servers .. Removed reviewer Kudu Jenkins. -- To

[Impala-ASF-CR] [security] Make the kerberos principal configurable for Kudu servers

2017-12-04 Thread Sailesh Mukil (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8760 to review the following change. Change subject: [security] Make the kerberos principal configurable for Kudu servers

[Impala-ASF-CR] Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos"

2017-12-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8763 Change subject: Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos" .. Revert "IMPALA-5053: [SECURITY] Make KRPC work with

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-12-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 8: Code-Review+2 (2 comments) Carry +2

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-12-01 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8270 to look at the new patch set (#9). Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos ..

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow

2017-11-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8510 ) Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow .. Patch Set 7: > Change has been successfully

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow

2017-11-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8510 ) Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-18 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8270 to look at the new patch set (#5). Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos ..

[Impala-ASF-CR] IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow

2017-11-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8510 ) Change subject: IMPALA-6128: Spill-to-disk Encryption(AES-CFB + SHA256) is slow .. Patch Set 5: (2 comments)

[Impala-ASF-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8622 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8622 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 1: (1 comment)

[Impala-ASF-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-21 Thread Sailesh Mukil (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8622 to review the following change. Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert

[Impala-ASF-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8622 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Patch Set 1: This patch fixes IMPALA-6172. -- To view,

[Impala-ASF-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has removed Todd Lipcon from this change. ( http://gerrit.cloudera.org:8080/8622 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Removed reviewer Todd Lipcon. -- To view, visit

[Impala-ASF-CR] KUDU-2220: GetEndOfChainX509 does not return end-user cert

2017-11-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has removed Alexey Serbin from this change. ( http://gerrit.cloudera.org:8080/8622 ) Change subject: KUDU-2220: GetEndOfChainX509 does not return end-user cert .. Removed reviewer Alexey Serbin. -- To view,

[Impala-ASF-CR](asf-site) Impala graduated; remove outdated references to incubation

2017-11-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8575 ) Change subject: Impala graduated; remove outdated references to incubation .. Patch Set 1: There are quite a few more places where we

[Impala-ASF-CR](asf-site) Impala graduated; remove outdated references to incubation

2017-11-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8575 ) Change subject: Impala graduated; remove outdated references to incubation .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Impala is graduating; remove outdated references to incubation

2017-11-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8577 ) Change subject: Impala is graduating; remove outdated references to incubation .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-16 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 3: (15 comments)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-11-16 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8270 to look at the new patch set (#4). Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos ..

[Impala-ASF-CR] IMPALA-6109: xfail TestHdfsUnknownErrors::test hdfs safe mode error 255

2017-11-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8590 ) Change subject: IMPALA-6109: xfail TestHdfsUnknownErrors::test_hdfs_safe_mode_error_255 .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 7: Code-Review+2 (1

[Impala-ASF-CR] Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos"

2017-12-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8763 ) Change subject: Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos" .. Patch Set 2: > I would recommend against reverting

[Impala-ASF-CR] IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS be principal is set

2017-12-05 Thread Sailesh Mukil (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8761 to look at the new patch set (#2). Change subject: IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS_be_principal is set

[Impala-ASF-CR] IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS be principal is set

2017-12-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8761 ) Change subject: IMPALA-6256: Incorrect principal will be used for internal connections if FLAGS_be_principal is set .. Patch Set 2:

[Impala-ASF-CR] Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos"

2017-12-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. ( http://gerrit.cloudera.org:8080/8763 ) Change subject: Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos" .. Abandoned Thanks Michael, sounds good. I've uploaded a patch

[Impala-ASF-CR] IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing

2017-12-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8766 Change subject: IMPALA-6268: KerberosOnAndOff/RpcMgrKerberizedTest.MultipleServices failing .. IMPALA-6268:

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 4: The latest patchset

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-12-01 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8270 to look at the new patch set (#8). Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos ..

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-12-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2017-12-03 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 1: Update: This is now blocked on:

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-02 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 4: (26 comments)

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-02 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8472 to look at the new patch set (#4). Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

[Impala-ASF-CR] IMPALA-4671: (part-1) Copy kudu::ServicePool into Impala namespace

2017-12-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8471 ) Change subject: IMPALA-4671: (part-1) Copy kudu::ServicePool into Impala namespace .. IMPALA-4671: (part-1) Copy

[Impala-ASF-CR] IMPALA-4671: (part-1) Copy kudu::ServicePool into Impala namespace

2017-12-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8471 ) Change subject: IMPALA-4671: (part-1) Copy kudu::ServicePool into Impala namespace .. Patch Set 7: Verified+1 Code-Review+2 Since the

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-07 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8472 to look at the new patch set (#9). Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

[Impala-ASF-CR] IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads

2017-12-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8472 ) Change subject: IMPALA-4671: (part-2) Replace kudu::ServicePool with one that uses Impala threads .. Patch Set 9: Code-Review+2

[Impala-ASF-CR] IMPALA-6285: Don't print stack trace on RPC errors.

2017-12-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8788 ) Change subject: IMPALA-6285: Don't print stack trace on RPC errors. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-06 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. Patch Set 2: Code-Review+1 I'm fine with this patch.

[Impala-ASF-CR] IMPALA-6262: Always initialize runtime profile for DataSink

2017-12-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8770 ) Change subject: IMPALA-6262: Always initialize runtime profile for DataSink .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-12-01 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8270 ) Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos .. Patch Set 10: Code-Review+2 (1 comment) Carry +2.

[Impala-ASF-CR] IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

2017-12-01 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8270 to look at the new patch set (#10). Change subject: IMPALA-5053: [SECURITY] Make KRPC work with Kerberos

[Impala-ASF-CR] Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos"

2017-12-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8763 ) Change subject: Revert "IMPALA-5053: [SECURITY] Make KRPC work with Kerberos" .. Revert "IMPALA-5053: [SECURITY] Make KRPC work with

[Impala-ASF-CR] Move admission-controller and catalog metrics into own groups

2018-05-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10302 ) Change subject: Move admission-controller and catalog metrics into own groups .. Patch Set 2: Code-Review+1 Ok, that's fine by me.

[Impala-ASF-CR] Move admission-controller and catalog metrics into own groups

2018-05-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10302 ) Change subject: Move admission-controller and catalog metrics into own groups .. Patch Set 2: Is there any motivation for this patch,

[Impala-ASF-CR] IMPALA-6975: TestRuntimeRowFilters.test row filters failing with Memory limit exceeded

2018-05-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10315 ) Change subject: IMPALA-6975: TestRuntimeRowFilters.test_row_filters failing with Memory limit exceeded .. Patch Set 1: I haven't run

[Impala-ASF-CR] IMPALA-6975: TestRuntimeRowFilters.test row filters failing with Memory limit exceeded

2018-05-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10315 Change subject: IMPALA-6975: TestRuntimeRowFilters.test_row_filters failing with Memory limit exceeded .. IMPALA-6975:

[Impala-ASF-CR] IMPALA-7018: fix spill-to-disk encryption err handling

2018-05-14 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10385 ) Change subject: IMPALA-7018: fix spill-to-disk encryption err handling .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR](asf-site) Update download and signature links for 3.0.0 release.

2018-05-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10333 Change subject: Update download and signature links for 3.0.0 release. .. Update download and signature links for 3.0.0 release.

[Impala-ASF-CR](asf-site) Added changelog for 3.0.0

2018-05-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10334 ) Change subject: Added changelog for 3.0.0 .. Added changelog for 3.0.0 Change-Id: I895f54fc47bada6b5131f20167405781c7d284b5 --- A

[Impala-ASF-CR](asf-site) Added changelog for 2.12.0

2018-05-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10334 Change subject: Added changelog for 2.12.0 .. Added changelog for 2.12.0 Change-Id: I895f54fc47bada6b5131f20167405781c7d284b5 --- A

[Impala-ASF-CR](asf-site) Added changelog for 3.0.0

2018-05-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10334 ) Change subject: Added changelog for 3.0.0 .. Added changelog for 3.0.0 Change-Id: I895f54fc47bada6b5131f20167405781c7d284b5

[Impala-ASF-CR](asf-site) Update download and signature links for 3.0.0 release.

2018-05-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10333 ) Change subject: Update download and signature links for 3.0.0 release. .. Update download and signature links for 3.0.0

[Impala-ASF-CR](asf-site) Update download and signature links for 3.0.0 release.

2018-05-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10333 ) Change subject: Update download and signature links for 3.0.0 release. .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR](asf-site) Added changelog for 3.0.0

2018-05-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10334 ) Change subject: Added changelog for 3.0.0 .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10334 To

[Impala-ASF-CR] IMPALA-6907: Close stale connections to removed cluster members

2018-05-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10327 ) Change subject: IMPALA-6907: Close stale connections to removed cluster members .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6998: test bloom wait time fails due to late arrival of filters on Isilon

2018-05-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10366 Change subject: IMPALA-6998: test_bloom_wait_time fails due to late arrival of filters on Isilon .. IMPALA-6998: test_bloom_wait_time

[Impala-ASF-CR] Update version to 3.1.0-SNAPSHOT

2018-05-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10360 Change subject: Update version to 3.1.0-SNAPSHOT .. Update version to 3.1.0-SNAPSHOT Change-Id:

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10158 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 21: (1 comment)

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-10 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10158 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 19: (12 comments) LGTM overall,

[Impala-ASF-CR] IMPALA-5384, part 2: Simplify Coordinator locking and clarify state

2018-05-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10158 ) Change subject: IMPALA-5384, part 2: Simplify Coordinator locking and clarify state .. Patch Set 20: Code-Review+2 (4 comments)

[Impala-ASF-CR](2.x) Ignore 3.x version update patch

2018-05-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10383 Change subject: Ignore 3.x version update patch .. Ignore 3.x version update patch Change-Id:

[Impala-ASF-CR](2.x) Ignore 3.x version update patch

2018-05-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10383 ) Change subject: Ignore 3.x version update patch .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10383

[Impala-ASF-CR](2.x) Ignore 3.x version update patch

2018-05-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10383 ) Change subject: Ignore 3.x version update patch .. Ignore 3.x version update patch Change-Id:

[Impala-ASF-CR](2.x) IMPALA-6908: IsConnResetTException() should include ECONNRESET

2018-05-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10265 ) Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET .. Patch Set 4: Code-Review+2 (2 comments) Carry +2.

[Impala-ASF-CR](asf-site) Update download and signature links for 3.0.0 release.

2018-05-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10333 ) Change subject: Update download and signature links for 3.0.0 release. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6907: Close stale connections to removed cluster members

2018-05-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10327 ) Change subject: IMPALA-6907: Close stale connections to removed cluster members .. Patch Set 3: (4 comments)

[Impala-ASF-CR](2.x) IMPALA-6908: IsConnResetTException() should include ECONNRESET

2018-05-08 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10265 to look at the new patch set (#4). Change subject: IMPALA-6908: IsConnResetTException() should include ECONNRESET

[Impala-ASF-CR](2.x) IMPALA-6507: remove --disable mem pools debug feature

2018-05-05 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10320 ) Change subject: IMPALA-6507: remove --disable_mem_pools debug feature .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6998: test bloom wait time fails due to late arrival of filters on Isilon

2018-05-20 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10366 ) Change subject: IMPALA-6998: test_bloom_wait_time fails due to late arrival of filters on Isilon .. Patch Set 3: Code-Review+2

[Impala-ASF-CR] IMPALA-6998: test bloom wait time fails due to late arrival of filters on Isilon

2018-05-20 Thread Sailesh Mukil (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10366 to look at the new patch set (#3). Change subject: IMPALA-6998: test_bloom_wait_time fails due to late arrival of filters on Isilon

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 1: > > Patch Set 1: > > >

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-21 Thread Sailesh Mukil (Code Review)
Hello Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9966 to look at the new patch set (#2). Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-21 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 2: > Can we add a basic

[Impala-ASF-CR] [DOCS] Added a link to impala kerberos doc in impala-shell options doc

2018-05-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10482 ) Change subject: [DOCS] Added a link to impala kerberos doc in impala-shell options doc .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] [DOCS] Sentry is required for Impala to enable delegation

2018-05-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10451 ) Change subject: [DOCS] Sentry is required for Impala to enable delegation .. Patch Set 2: Is there a JIRA that states that delegation

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 3: Code-Review+2 preads add

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-7071: make get fs path() idempotent

2018-05-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10517 ) Change subject: IMPALA-7071: make get_fs_path() idempotent .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-4970: Record identity of largest latency ExecQueryFInstances()

2018-05-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 ) Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() .. Patch Set 6: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table

2018-05-24 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9966 ) Change subject: IMPALA-6813: Hedged reads metrics broken when scanning non-HDFS based table .. Patch Set 4: > > preads add some

  1   2   3   4   5   6   >