[Impala-ASF-CR] IMPALA-6225: Part 1: Query profile date-time strings should have ns precision.

2017-11-27 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Philip Zeyliger, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8611 to look at the new patch set (#8). Change subject: IMPALA-6225: Part 1: Query profile date-time strings should have ns precision.

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2017-11-28 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8349 Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. IMPALA-6059: Enhance ltrim()/rtrim()

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-15 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8784 to look at the new patch set (#6). Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-15 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 6: > (1 comment) > >

[Impala-ASF-CR] IMPALA-6114: Require type equality of NumericLiteral::localEquals().

2017-12-14 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8448 ) Change subject: IMPALA-6114: Require type equality of NumericLiteral::localEquals(). .. Patch Set 5: Thanks for the comments. Please

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2017-12-15 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8349 to look at the new patch set (#6). Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2017-12-15 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 4: (6 comments) Thanks for

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2017-12-15 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8349 to look at the new patch set (#5). Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-15 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-13 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 4: (3 comments) Thanks

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-13 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 5: > (1 comment) > >

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-13 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 4: (1 comment) Uploading

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-13 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8784 to look at the new patch set (#5). Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

[Impala-ASF-CR] IMPALA-6114: Require type equality of NumericLiteral::localEquals().

2017-12-12 Thread Zoram Thanga (Code Review)
Hello Bharath Vissapragada, Michael Ho, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8448 to look at the new patch set (#4). Change subject: IMPALA-6114: Require type equality of NumericLiteral::localEquals().

[Impala-ASF-CR] IMPALA-6114: Require type equality of NumericLiteral::localEquals().

2017-12-12 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8448 ) Change subject: IMPALA-6114: Require type equality of NumericLiteral::localEquals(). .. Patch Set 3: (1 comment) Thanks for the

[Impala-ASF-CR] IMPALA-6114: Require type equality of NumericLiteral::localEquals().

2017-12-12 Thread Zoram Thanga (Code Review)
Hello Bharath Vissapragada, Michael Ho, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8448 to look at the new patch set (#5). Change subject: IMPALA-6114: Require type equality of NumericLiteral::localEquals().

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2017-12-12 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8349 to look at the new patch set (#4). Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-18 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 6: Hi PhilZ, are you ok

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-20 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8610 Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. IMPALA-6225: Query profile date-time strings

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-20 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8610 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 1: Please see

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-20 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. IMPALA-6225: Query profile date-time strings

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-20 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8610 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 1: Looking into the test code,

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-21 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 2: (2 comments) > (1 comment) >

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-21 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Philip Zeyliger, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8611 to look at the new patch set (#3). Change subject: IMPALA-6225: Query profile date-time strings should have ns precision.

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-21 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Philip Zeyliger, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8611 to look at the new patch set (#4). Change subject: IMPALA-6225: Query profile date-time strings should have ns precision.

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-21 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 3: > > (2 comments) > > > > > (1

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-21 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 4: (5 comments) Uploading a new

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-21 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Philip Zeyliger, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8611 to look at the new patch set (#5). Change subject: IMPALA-6225: Query profile date-time strings should have ns precision.

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-21 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8611 ) Change subject: IMPALA-6225: Query profile date-time strings should have ns precision. .. Patch Set 6: (4 comments) Uploading patch

[Impala-ASF-CR] IMPALA-6225: Query profile date-time strings should have ns precision.

2017-11-21 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Philip Zeyliger, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8611 to look at the new patch set (#7). Change subject: IMPALA-6225: Query profile date-time strings should have ns precision.

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-07 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 2: (9 comments) Thanks

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-07 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8784 to look at the new patch set (#3). Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-07 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8784 to look at the new patch set (#2). Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-07 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-06 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8784 Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. IMPALA-6225: Part 2: Query profile

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-06 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 1: The earlier attempt

[Impala-ASF-CR] IMPALA-6114: Require type equality of NumericLiteral::localEquals().

2017-12-08 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8448 ) Change subject: IMPALA-6114: Require type equality of NumericLiteral::localEquals(). .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6114: Require type equality of NumericLiteral::localEquals().

2017-12-08 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8448 ) Change subject: IMPALA-6114: Require type equality of NumericLiteral::localEquals(). .. IMPALA-6114: Require type equality of

[Impala-ASF-CR] IMPALA-6114: Require type equality of NumericLiteral::equals().

2017-12-08 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8448 Change subject: IMPALA-6114: Require type equality of NumericLiteral::equals(). .. IMPALA-6114: Require type equality of

[Impala-ASF-CR] IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()

2018-05-14 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10364 ) Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded() .. Patch Set 1: Ping? -- To view, visit

[Impala-ASF-CR] IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()

2018-05-11 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10364 ) Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded() .. Patch Set 1: (1 comment)

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

2018-06-01 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10576 ) Change subject: Bump libunwind version to 1.3-rc1 .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls

2018-06-21 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10696 ) Change subject: [DRAFT] IMPALA-6189: Add thread watchdogs for HDFS IO calls .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-02 Thread Zoram Thanga (Code Review)
Zoram Thanga has abandoned this change. ( http://gerrit.cloudera.org:8080/10842 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Abandoned Raising a new review. -- To view,

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-02 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10842 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 1: (3 comments) Abandoning

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-02 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10850 Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. IMPALA-6086: Use of permanent function

[Impala-ASF-CR] IMPALA-6954: Fix problems with CTAS into Kudu with an expr rewrite

2018-04-30 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10251 ) Change subject: IMPALA-6954: Fix problems with CTAS into Kudu with an expr rewrite .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-03 Thread Zoram Thanga (Code Review)
Hello Fredy Wijaya, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10850 to look at the new patch set (#2). Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-03 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 2: (6 comments) Thanks.

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-03 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 1: (1 comment) Thanks for

[Impala-ASF-CR] IMPALA-6307: CTAS statement fails with duplicate column exception.

2018-01-09 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8930 to look at the new patch set (#3). Change subject: IMPALA-6307: CTAS statement fails with duplicate column exception.

[Impala-ASF-CR] IMPALA-6307: CTAS statement fails with duplicate column exception.

2018-01-09 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8930 ) Change subject: IMPALA-6307: CTAS statement fails with duplicate column exception. .. Patch Set 2: (3 comments) Thanks! Uploading

[Impala-ASF-CR] IMPALA-6307: CTAS statement fails with duplicate column exception.

2018-01-08 Thread Zoram Thanga (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8930 to look at the new patch set (#2). Change subject: IMPALA-6307: CTAS statement fails with duplicate column exception.

[Impala-ASF-CR] IMPALA-6307: CTAS statement fails with duplicate column exception.

2018-01-08 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8930 ) Change subject: IMPALA-6307: CTAS statement fails with duplicate column exception. .. Patch Set 1: (3 comments) Thanks for the

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-08 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 6: (4 comments) Changed

[Impala-ASF-CR] Fix typo in test observability.

2018-01-10 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9003 ) Change subject: Fix typo in test_observability. .. Patch Set 1: Code-Review+1 Looks good. Sorry for the typo! -- To view, visit

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-17 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9038 ) Change subject: IMPALA-2642: Fix a potential deadlock in statestore .. Patch Set 2: (3 comments) Working on the test case.

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-18 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 9: (2 comments) Thanks.

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-18 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8349 to look at the new patch set (#10). Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-19 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 1: (1 comment) Thanks for fixing

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-19 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 2: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-26 Thread Zoram Thanga (Code Review)
Hello Bharath Vissapragada, Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9038 to look at the new patch set (#3). Change subject: IMPALA-2642: Fix a potential deadlock in statestore

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-12 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 9: (3 comments) Thanks.

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-12 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8349 to look at the new patch set (#9). Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

[Impala-ASF-CR] IMPALA-6307: CTAS statement fails with duplicate column exception.

2018-01-11 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8930 ) Change subject: IMPALA-6307: CTAS statement fails with duplicate column exception. .. Patch Set 3: (1 comment) Thanks for the

[Impala-ASF-CR] IMPALA-6307: CTAS statement fails with duplicate column exception.

2018-01-11 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8930 to look at the new patch set (#4). Change subject: IMPALA-6307: CTAS statement fails with duplicate column exception.

[Impala-ASF-CR] IMPALA-6384: RequestPoolService should honor custom group mapping config

2018-01-11 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9000 ) Change subject: IMPALA-6384: RequestPoolService should honor custom group mapping config .. Patch Set 2: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-11 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8349 to look at the new patch set (#8). Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-11 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 7: (4 comments) Thanks for

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-29 Thread Zoram Thanga (Code Review)
Hello Bharath Vissapragada, Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9038 to look at the new patch set (#4). Change subject: IMPALA-2642: Fix a potential deadlock in statestore

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-30 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9038 ) Change subject: IMPALA-2642: Fix a potential deadlock in statestore .. Patch Set 5: Thanks Sailesh. I do not have the permission to

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-29 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9038 ) Change subject: IMPALA-2642: Fix a potential deadlock in statestore .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-20 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8784 to look at the new patch set (#7). Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

[Impala-ASF-CR] IMPALA-6225: Part 2: Query profile date-time strings should have ns precision.

2017-12-20 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8784 ) Change subject: IMPALA-6225: Part 2: Query profile date-time strings should have ns precision. .. Patch Set 6: (1 comment) Thanks for

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-15 Thread Zoram Thanga (Code Review)
Hello Michael Ho, anujphadke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11234 to look at the new patch set (#2). Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions.

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-15 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 1: (2 comments) > Just being

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-16 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 ) Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-16 Thread Zoram Thanga (Code Review)
Hello Michael Ho, anujphadke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11234 to look at the new patch set (#3). Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions.

[Impala-ASF-CR] IMPALA-7444: Improve logging of opening/closing/expiring sessions.

2018-08-17 Thread Zoram Thanga (Code Review)
Hello Michael Ho, anujphadke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11234 to look at the new patch set (#4). Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions.

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-07-17 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 5: Code-Review+1 LGTM -- To

[Impala-ASF-CR] IMPALA-7014: Disable stacktrace symbolisation by default

2018-07-17 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10964 Change subject: IMPALA-7014: Disable stacktrace symbolisation by default .. IMPALA-7014: Disable stacktrace symbolisation by default

[Impala-ASF-CR] IMPALA-7508: Add Impala Python GDB module

2018-08-30 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11352 ) Change subject: IMPALA-7508: Add Impala Python GDB module .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7508: Add Impala Python GDB module

2018-08-30 Thread Zoram Thanga (Code Review)
Hello Fredy Wijaya, Philip Zeyliger, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11352 to look at the new patch set (#3). Change subject: IMPALA-7508: Add Impala Python GDB module

[Impala-ASF-CR] IMPALA-7508: Add Impala Python GDB module

2018-08-30 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11352 ) Change subject: IMPALA-7508: Add Impala Python GDB module .. Patch Set 1: (10 comments) Thanks for the comments. Uploading PS#2.

[Impala-ASF-CR] IMPALA-7508: Add Impala Python GDB module

2018-08-30 Thread Zoram Thanga (Code Review)
Hello Fredy Wijaya, Philip Zeyliger, David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11352 to look at the new patch set (#2). Change subject: IMPALA-7508: Add Impala Python GDB module

[Impala-ASF-CR] IMPALA-1760: Implement shutdown command

2018-09-10 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 ) Change subject: IMPALA-1760: Implement shutdown command .. Patch Set 18: (3 comments) Thanks for doing this.

[Impala-ASF-CR] IMPALA-7508: Add Impala Python GDB module

2018-08-29 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11352 Change subject: IMPALA-7508: Add Impala Python GDB module .. IMPALA-7508: Add Impala Python GDB module This patch adds a new Impala

[Impala-ASF-CR] IMPALA-7542: fix find-fragment-instances to find all "root threads"

2018-09-07 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11396 ) Change subject: IMPALA-7542: fix find-fragment-instances to find all "root threads" .. Patch Set 2: Code-Review+1 Thanks for fixing

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-07-06 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-7288: Fix Codegen Crash in FinalizeModule()

2018-07-12 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 ) Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() .. Patch Set 1: > I am not sure what kind of tests I can add to

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-12 Thread Zoram Thanga (Code Review)
Hello Fredy Wijaya, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10850 to look at the new patch set (#4). Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-12 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 4: (8 comments)

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-11 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-07-11 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 4: Can you also add test case

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-13 Thread Zoram Thanga (Code Review)
Hello Fredy Wijaya, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10850 to look at the new patch set (#5). Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-13 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 5: Code-Review+1 (1

[Impala-ASF-CR] IMPALA-2624: Fix a potential deadlock in statestore

2018-01-16 Thread Zoram Thanga (Code Review)
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9038 Change subject: IMPALA-2624: Fix a potential deadlock in statestore .. IMPALA-2624: Fix a potential deadlock in statestore The

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-16 Thread Zoram Thanga (Code Review)
Hello Bharath Vissapragada, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9038 to look at the new patch set (#2). Change subject: IMPALA-2642: Fix a potential deadlock in statestore

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-16 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9038 ) Change subject: IMPALA-2642: Fix a potential deadlock in statestore .. Patch Set 2: (1 comment) Fixed the Jira Id.

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-22 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 11: Let's wait for

  1   2   >