[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9530 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. IMPALA-6405: Error when string to decimal cast overflows Before this patch, when there was an error when converting a string to a decimal, a NULL was returned. In this patch, we change this behavior so that an error is returned if decimal_v2 is enabled. The reasoning is that we want stricter behavior in decimal_v2. Testing: - Added some EE tests. - Ran an exhaustive build, which passed. Change-Id: Icffccac1c1c2361447ae4b0de9b6c2ec7de071db Reviewed-on: http://gerrit.cloudera.org:8080/9339 Reviewed-by: Dan Hecht Tested-by: Impala Public Jenkins Reviewed-on: http://gerrit.cloudera.org:8080/9530 Reviewed-by: Taras Bobrovytsky --- M be/src/exprs/decimal-operators-ir.cc M fe/src/main/java/org/apache/impala/rewrite/RemoveRedundantStringCast.java M testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test 3 files changed, 55 insertions(+), 7 deletions(-) Approvals: Taras Bobrovytsky: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: merged Gerrit-Change-Id: Icffccac1c1c2361447ae4b0de9b6c2ec7de071db Gerrit-Change-Number: 9530 Gerrit-PatchSet: 3 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows
Hello Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9530 to look at the new patch set (#2). Change subject: IMPALA-6405: Error when string to decimal cast overflows .. IMPALA-6405: Error when string to decimal cast overflows Before this patch, when there was an error when converting a string to a decimal, a NULL was returned. In this patch, we change this behavior so that an error is returned if decimal_v2 is enabled. The reasoning is that we want stricter behavior in decimal_v2. Testing: - Added some EE tests. - Ran an exhaustive build, which passed. Change-Id: Icffccac1c1c2361447ae4b0de9b6c2ec7de071db Reviewed-on: http://gerrit.cloudera.org:8080/9339 Reviewed-by: Dan Hecht Tested-by: Impala Public Jenkins --- M be/src/exprs/decimal-operators-ir.cc M fe/src/main/java/org/apache/impala/rewrite/RemoveRedundantStringCast.java M testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test 3 files changed, 55 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/9530/2 -- To view, visit http://gerrit.cloudera.org:8080/9530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icffccac1c1c2361447ae4b0de9b6c2ec7de071db Gerrit-Change-Number: 9530 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Taras Bobrovytsky
[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9530 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 1: Verified-1 Both builds have failed. Can you have a look? -- To view, visit http://gerrit.cloudera.org:8080/9530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Icffccac1c1c2361447ae4b0de9b6c2ec7de071db Gerrit-Change-Number: 9530 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Fri, 09 Mar 2018 18:43:41 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9530 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 1: I had done the same, but it's still running: https://jenkins.impala.io/job/gerrit-verify-dryrun/2070/ :D -- To view, visit http://gerrit.cloudera.org:8080/9530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Icffccac1c1c2361447ae4b0de9b6c2ec7de071db Gerrit-Change-Number: 9530 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Thu, 08 Mar 2018 22:48:56 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9530 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 1: I started a dry run build: https://jenkins.impala.io/job/gerrit-verify-dryrun/2071/ I will submit the patch once the build passes. -- To view, visit http://gerrit.cloudera.org:8080/9530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Icffccac1c1c2361447ae4b0de9b6c2ec7de071db Gerrit-Change-Number: 9530 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Thu, 08 Mar 2018 22:34:19 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9530 ) Change subject: IMPALA-6405: Error when string to decimal cast overflows .. Patch Set 1: Code-Review+2 Cherry-picked and resolved conflicts -- To view, visit http://gerrit.cloudera.org:8080/9530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: Icffccac1c1c2361447ae4b0de9b6c2ec7de071db Gerrit-Change-Number: 9530 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky Gerrit-Comment-Date: Thu, 08 Mar 2018 22:05:44 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6405: Error when string to decimal cast overflows
Hello Dan Hecht, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9530 to review the following change. Change subject: IMPALA-6405: Error when string to decimal cast overflows .. IMPALA-6405: Error when string to decimal cast overflows Before this patch, when there was an error when converting a string to a decimal, a NULL was returned. In this patch, we change this behavior so that an error is returned if decimal_v2 is enabled. We also add a warning if there is an underflow. The reasoning is that we want stricter behavior in decimal_v2. Testing: - Added some EE tests. - Ran an exhaustive build, which passed. Change-Id: Icffccac1c1c2361447ae4b0de9b6c2ec7de071db Reviewed-on: http://gerrit.cloudera.org:8080/9339 Reviewed-by: Dan Hecht Tested-by: Impala Public Jenkins --- M be/src/exprs/decimal-operators-ir.cc M be/src/exprs/expr-test.cc M fe/src/main/java/org/apache/impala/rewrite/RemoveRedundantStringCast.java M testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test M tests/query_test/test_decimal_casting.py 5 files changed, 59 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/9530/1 -- To view, visit http://gerrit.cloudera.org:8080/9530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: newchange Gerrit-Change-Id: Icffccac1c1c2361447ae4b0de9b6c2ec7de071db Gerrit-Change-Number: 9530 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Taras Bobrovytsky
