[Impala-ASF-CR](2.x) IMPALA-6820: Remove impala builtins from catalogd
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10048 ) Change subject: IMPALA-6820: Remove _impala_builtins from catalogd .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8 Gerrit-Change-Number: 10048 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Thu, 12 Apr 2018 23:53:50 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6820: Remove impala builtins from catalogd
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10048 ) Change subject: IMPALA-6820: Remove _impala_builtins from catalogd .. IMPALA-6820: Remove _impala_builtins from catalogd The _impala_builtins database is initialized in the constructor of Catalog and hence is inherited by both the CatalogServiceCatalog and ImpaladCatalog. Since _impala_builtins is not used by the catalog server and to avoid the overhead of managing this database during normal metadata operations (e.g. invalidate), it is moved to the ImpaladCatalog class. Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8 Reviewed-on: http://gerrit.cloudera.org:8080/9947 Reviewed-by: Tianyi Wang Tested-by: Impala Public Jenkins (cherry picked from commit 17137d783c24d0ec0827db62bb256ec4c2c05164) Reviewed-on: http://gerrit.cloudera.org:8080/10048 Reviewed-by: Dimitris Tsirogiannis --- M fe/src/main/java/org/apache/impala/analysis/CastExpr.java M fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java M fe/src/main/java/org/apache/impala/analysis/Expr.java M fe/src/main/java/org/apache/impala/analysis/ExtractFromExpr.java M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M fe/src/main/java/org/apache/impala/analysis/FunctionName.java M fe/src/main/java/org/apache/impala/catalog/Catalog.java M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java M fe/src/main/jflex/sql-scanner.flex M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java 11 files changed, 35 insertions(+), 32 deletions(-) Approvals: Dimitris Tsirogiannis: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: merged Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8 Gerrit-Change-Number: 10048 Gerrit-PatchSet: 3 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang
[Impala-ASF-CR](2.x) IMPALA-6820: Remove impala builtins from catalogd
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10048 ) Change subject: IMPALA-6820: Remove _impala_builtins from catalogd .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2299/ -- To view, visit http://gerrit.cloudera.org:8080/10048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8 Gerrit-Change-Number: 10048 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Thu, 12 Apr 2018 20:05:39 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6820: Remove impala builtins from catalogd
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/10048 ) Change subject: IMPALA-6820: Remove _impala_builtins from catalogd .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8 Gerrit-Change-Number: 10048 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang Gerrit-Comment-Date: Thu, 12 Apr 2018 20:04:43 + Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6820: Remove impala builtins from catalogd
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10048 to look at the new patch set (#2). Change subject: IMPALA-6820: Remove _impala_builtins from catalogd .. IMPALA-6820: Remove _impala_builtins from catalogd The _impala_builtins database is initialized in the constructor of Catalog and hence is inherited by both the CatalogServiceCatalog and ImpaladCatalog. Since _impala_builtins is not used by the catalog server and to avoid the overhead of managing this database during normal metadata operations (e.g. invalidate), it is moved to the ImpaladCatalog class. Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8 Reviewed-on: http://gerrit.cloudera.org:8080/9947 Reviewed-by: Tianyi Wang Tested-by: Impala Public Jenkins (cherry picked from commit 17137d783c24d0ec0827db62bb256ec4c2c05164) --- M fe/src/main/java/org/apache/impala/analysis/CastExpr.java M fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java M fe/src/main/java/org/apache/impala/analysis/Expr.java M fe/src/main/java/org/apache/impala/analysis/ExtractFromExpr.java M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M fe/src/main/java/org/apache/impala/analysis/FunctionName.java M fe/src/main/java/org/apache/impala/catalog/Catalog.java M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java M fe/src/main/jflex/sql-scanner.flex M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java 11 files changed, 35 insertions(+), 32 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/10048/2 -- To view, visit http://gerrit.cloudera.org:8080/10048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: newpatchset Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8 Gerrit-Change-Number: 10048 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang
[Impala-ASF-CR](2.x) IMPALA-6820: Remove impala builtins from catalogd
Hello Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10048 to review the following change. Change subject: IMPALA-6820: Remove _impala_builtins from catalogd .. IMPALA-6820: Remove _impala_builtins from catalogd The _impala_builtins database is initialized in the constructor of Catalog and hence is inherited by both the CatalogServiceCatalog and ImpaladCatalog. Since _impala_builtins is not used by the catalog server and to avoid the overhead of managing this database during normal metadata operations (e.g. invalidate), it is moved to the ImpaladCatalog class. Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8 Reviewed-on: http://gerrit.cloudera.org:8080/9947 Reviewed-by: Tianyi Wang Tested-by: Impala Public Jenkins (cherry picked from commit 17137d783c24d0ec0827db62bb256ec4c2c05164) --- M fe/src/main/java/org/apache/impala/analysis/CastExpr.java M fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java M fe/src/main/java/org/apache/impala/analysis/Expr.java M fe/src/main/java/org/apache/impala/analysis/ExtractFromExpr.java M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M fe/src/main/java/org/apache/impala/analysis/FunctionName.java M fe/src/main/java/org/apache/impala/catalog/Catalog.java M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java M fe/src/main/jflex/sql-scanner.flex M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java 11 files changed, 34 insertions(+), 31 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/10048/1 -- To view, visit http://gerrit.cloudera.org:8080/10048 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: newchange Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8 Gerrit-Change-Number: 10048 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi Wang Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang
