[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/16744 )

Change subject: IMPALA-10340: Cannot set up KDC from scratch
..

IMPALA-10340: Cannot set up KDC from scratch

IMPALA-9361 added experimental support for setting up a KDC for the mini
cluster.  However, the experimental-kerberos-setup.sh script fails with
the error:

  KRB5_CONFIG: unbound variable

The problem is that impala-config.sh unsets KDC-related variables if the
cluster is not kerberized or does not exist.  However, kerberized
cluster cannot be created without installing KDC first.

This change updates impala-config.sh to allow setting the KDC-related
variables if IMPALA_KERBERIZE is set to 'true' and the cluster does not
exist yet.

Testing:
 * successfully set up KDC via experimental-kerberos-setup.sh after
   building Impala locally
 * verified that impala-config.sh sets/unsets KDC-related variables
   depending on cluster existence and config
 * started Kerberized and non-Kerberized mini clusters (after
   regenerating configs)

Change-Id: Icaed2ad2fb1e1b60951a5a4138a9386588bc6972
Reviewed-on: http://gerrit.cloudera.org:8080/16744
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins 
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/16744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icaed2ad2fb1e1b60951a5a4138a9386588bc6972
Gerrit-Change-Number: 16744
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Doroszlai 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16744 )

Change subject: IMPALA-10340: Cannot set up KDC from scratch
..


Patch Set 1: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/16744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaed2ad2fb1e1b60951a5a4138a9386588bc6972
Gerrit-Change-Number: 16744
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Doroszlai 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 18 Nov 2020 23:15:35 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16744 )

Change subject: IMPALA-10340: Cannot set up KDC from scratch
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6672/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/16744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaed2ad2fb1e1b60951a5a4138a9386588bc6972
Gerrit-Change-Number: 16744
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Doroszlai 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 18 Nov 2020 18:29:06 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16744 )

Change subject: IMPALA-10340: Cannot set up KDC from scratch
..


Patch Set 1:

Makes sense, thanks for taking the initiative to improve this


--
To view, visit http://gerrit.cloudera.org:8080/16744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaed2ad2fb1e1b60951a5a4138a9386588bc6972
Gerrit-Change-Number: 16744
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Doroszlai 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 18 Nov 2020 18:28:53 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16744 )

Change subject: IMPALA-10340: Cannot set up KDC from scratch
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaed2ad2fb1e1b60951a5a4138a9386588bc6972
Gerrit-Change-Number: 16744
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Doroszlai 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 18 Nov 2020 18:28:23 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16744 )

Change subject: IMPALA-10340: Cannot set up KDC from scratch
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6670/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/16744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaed2ad2fb1e1b60951a5a4138a9386588bc6972
Gerrit-Change-Number: 16744
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Doroszlai 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 18 Nov 2020 18:03:13 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16744 )

Change subject: IMPALA-10340: Cannot set up KDC from scratch
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/7676/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/16744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icaed2ad2fb1e1b60951a5a4138a9386588bc6972
Gerrit-Change-Number: 16744
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Doroszlai 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Wed, 18 Nov 2020 17:51:53 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-10340: Cannot set up KDC from scratch

2020-11-18 Thread Attila Doroszlai (Code Review)
Attila Doroszlai has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16744


Change subject: IMPALA-10340: Cannot set up KDC from scratch
..

IMPALA-10340: Cannot set up KDC from scratch

IMPALA-9361 added experimental support for setting up a KDC for the mini
cluster.  However, the experimental-kerberos-setup.sh script fails with
the error:

  KRB5_CONFIG: unbound variable

The problem is that impala-config.sh unsets KDC-related variables if the
cluster is not kerberized or does not exist.  However, kerberized
cluster cannot be created without installing KDC first.

This change updates impala-config.sh to allow setting the KDC-related
variables if IMPALA_KERBERIZE is set to 'true' and the cluster does not
exist yet.

Testing:
 * successfully set up KDC via experimental-kerberos-setup.sh after
   building Impala locally
 * verified that impala-config.sh sets/unsets KDC-related variables
   depending on cluster existence and config
 * started Kerberized and non-Kerberized mini clusters (after
   regenerating configs)

Change-Id: Icaed2ad2fb1e1b60951a5a4138a9386588bc6972
---
M bin/impala-config.sh
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/16744/1
--
To view, visit http://gerrit.cloudera.org:8080/16744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icaed2ad2fb1e1b60951a5a4138a9386588bc6972
Gerrit-Change-Number: 16744
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Doroszlai