[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 17: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16044/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 17 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 27 Apr 2024 23:51:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18977 to look at the new patch set (#17). Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Apache Impala uses many apache components to build it. This patch provides a way to support building Apache Impala using Apache components. Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java M java/TableFlattener/pom.xml M java/pom.xml 10 files changed, 179 insertions(+), 68 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18977/17 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 17 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 16: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/16043/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 16 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 27 Apr 2024 23:06:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18977 to look at the new patch set (#16). Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Apache Impala uses many apache components to build it. This patch provides a way to support building Apache Impala using Apache components. Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java M java/TableFlattener/pom.xml M java/pom.xml 10 files changed, 179 insertions(+), 68 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18977/16 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 16 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Quanlong Huang has posted comments on this change. (
http://gerrit.cloudera.org:8080/18977 )
Change subject: IMPALA-10408: Support build using Apache components
..
Patch Set 15:
(4 comments)
Good to know the build succeeds!
> I have one question. Why does impala use toolchains from cloudera internal
> repository when building? It is called "Apache Impala" and open source. It
> should be built with apache sources.
I think we used to support building on Apache components. But due to the
official releases are usually slow (e.g. Hive-4.0), we switch to build on
CDH/CDP components which have the bug fixes or improvements to unblock our work.
> It will be easier to build apache impala if there is a way to download or
> upload binary packages for apache components like
> https://github.com/zer0beat/apache-ranger-compiled/releases for Apache Ranger.
We can consider uploading this to the S3 bucket of our native-toolchain. An
alternative is building Apache Ranger in bin/bootstrap_system.sh if it doesn't
take long. We used to build hadoop-lzo there in 3.x (it's removed later since
we deprecated the support on LZO).
http://gerrit.cloudera.org:8080/#/c/18977/15//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18977/15//COMMIT_MSG@8
PS15, Line 8:
Could you add some notes as the commit message? E.g. overview of this patch,
what problems you have solved, what tests you have done, etc. Just like other
commits do.
http://gerrit.cloudera.org:8080/#/c/18977/15/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/18977/15/bin/impala-config.sh@249
PS15, Line 249: \export APACHE_HADOOP_VERSION=3.3.6
Redundant backslash "\"
http://gerrit.cloudera.org:8080/#/c/18977/15/bin/impala-config.sh@358
PS15, Line 358: USE_APACHE
nit: Can we use a more concrete name, e.g. USE_APACHE_BUILDS,
USE_APACHE_BINARIES, or USE_APACHE_COMPONENTS ?
http://gerrit.cloudera.org:8080/#/c/18977/15/java/TableFlattener/pom.xml
File java/TableFlattener/pom.xml:
http://gerrit.cloudera.org:8080/#/c/18977/15/java/TableFlattener/pom.xml@67
PS15, Line 67:
: commons-lang
: commons-lang
: ${commons-io.version}
:
Is this added for some reason? Could you mention the compilation error without
it in the commit message?
--
To view, visit http://gerrit.cloudera.org:8080/18977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399
Gerrit-Change-Number: 18977
Gerrit-PatchSet: 15
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Comment-Date: Mon, 22 Apr 2024 11:02:37 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 15: It will be easier to build apache impala if there is a way to download or upload binary packages for apache components like https://github.com/zer0beat/apache-ranger-compiled/releases for Apache Ranger. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 15 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sun, 21 Apr 2024 00:11:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 15: I have one question. Why does impala use toolchains from cloudera internal repository when building? It is called "Apache Impala" and open source. It should be built with apache sources. In order to support integration test with apache components, there should be a way to upload prebuilt binary packages like Apache Ranger because it doesn't provide binary package on official website like impala and kudu. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 15 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 20 Apr 2024 23:51:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 15: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15974/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 15 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 20 Apr 2024 17:22:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 15: I think "RANGER_HOME" actually means "RANGER_ADMIN_HOME" in binary package. However, it is not suitable for apache ranger because there is not binary package for apache ranger. When I configure "impala-config-local.sh" as follows: export USE_APACHE=true export DOWNLOAD_CDH_COMPONENTS=false export DOWNLOAD_APACHE_COMPONENTS=true I can build impala with following commands. ./buildall.sh -skiptests -noclean -notests -release "create-test-configuration.sh" is not suitable for apache ranger. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 15 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 20 Apr 2024 17:02:31 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18977 to look at the new patch set (#15). Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java M java/TableFlattener/pom.xml M java/pom.xml 10 files changed, 179 insertions(+), 68 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18977/15 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 15 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 14: I succeeded build with impala-config-local.sh as follows: export USE_APACHE=true export DOWNLOAD_CDH_COMPONENTS=false export DOWNLOAD_APACHE_COMPONENTS=true -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 14 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 20 Apr 2024 16:14:56 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 14: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15973/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 14 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 20 Apr 2024 16:04:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 14: I found a bug introduced by IMPALA-1261. https://github.com/apache/impala/commit/f68d91dcee76ccd90dfc7f623ea531794d03#diff-841abe4e3fe78f5890719fb1ca85dff2dff72db4297ea0a0944538f0b17536e1R20 I think "import com.cloudera.cloud.storage.relocated.protobuf.Struct" is accidently included. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 14 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 20 Apr 2024 15:41:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18977 to look at the new patch set (#14). Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java M java/TableFlattener/pom.xml M java/pom.xml 10 files changed, 179 insertions(+), 68 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18977/14 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 14 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 13: Thanks for reply. Sorry for build failure. I fixed it. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 13 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 20 Apr 2024 14:07:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 13: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/15972/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 13 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 20 Apr 2024 14:05:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18977 to look at the new patch set (#13). Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml M java/pom.xml 9 files changed, 178 insertions(+), 66 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18977/13 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 13 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 12: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/15971/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 12 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 20 Apr 2024 13:36:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18977 to look at the new patch set (#12). Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml M java/pom.xml 9 files changed, 179 insertions(+), 67 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18977/12 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 12 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 11: > Patch Set 11: > > Build Failed > > https://jenkins.impala.io/job/gerrit-code-review-checks/15968/ : Initial code > review checks failed. See linked job for details on the failure. Thanks for reviving this! There are some build failures like https://jenkins.impala.io/job/ubuntu-20.04-build-only/2260/ + ./buildall.sh -notests -so /home/ubuntu/Impala/bin/impala-config.sh: line 223: USE_APACHE_HIVE: unbound variable ERROR in bin/jenkins/build-only.sh at line 29: bin/bootstrap_build.sh BTW, I think it's easier to do this for each component separately using different patches. E.g. building on Apache HBase and Apache Ranger might be easier and we can do them first. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 11 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 20 Apr 2024 08:14:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 11: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/15968/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 11 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 20 Apr 2024 06:26:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18977 to look at the new patch set (#11). Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml M java/pom.xml 9 files changed, 176 insertions(+), 44 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18977/11 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 11 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 10: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12495/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 28 Feb 2023 22:06:06 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml M java/pom.xml 9 files changed, 176 insertions(+), 70 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18977/10 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 9: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12455/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 27 Feb 2023 11:29:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml M java/pom.xml 9 files changed, 176 insertions(+), 70 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18977/9 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 9 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 8: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/12454/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 8 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 27 Feb 2023 11:01:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml M java/pom.xml 9 files changed, 157 insertions(+), 51 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18977/8 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 8 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Quanlong Huang has posted comments on this change. (
http://gerrit.cloudera.org:8080/18977 )
Change subject: IMPALA-10408: Support build using Apache components
..
Patch Set 7:
(1 comment)
There are still some compilation errors when building with USE_APACHE=true and
USE_APACHE_HIVE=true
01:47:34 [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on
project impala-frontend: Compilation failure: Compilation failure:
01:47:34 [ERROR]
/data0/jenkins/workspace/impala-private-gerrit-parameterized/repos/Impala/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:[223,20]
cannot find symbol
01:47:34 [ERROR] symbol: method getReplicationConfig()
01:47:34 [ERROR] location: variable bucket of type
org.apache.hadoop.ozone.client.OzoneBucket
01:47:34 [ERROR]
/data0/jenkins/workspace/impala-private-gerrit-parameterized/repos/Impala/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:[228,57]
cannot find symbol
01:47:34 [ERROR] symbol: method getReplication()
01:47:34 [ERROR] location: interface
org.apache.hadoop.hdds.client.ReplicationConfig
01:47:34 [ERROR]
/data0/jenkins/workspace/impala-private-gerrit-parameterized/repos/Impala/fe/src/main/java/org/apache/impala/util/IcebergUtil.java:[1055,58]
cannot find symbol
01:47:34 [ERROR] symbol: variable IO_MANIFEST_CACHE_ENABLED
01:47:34 [ERROR] location: class org.apache.iceberg.CatalogProperties
01:47:34 [ERROR]
/data0/jenkins/workspace/impala-private-gerrit-parameterized/repos/Impala/fe/src/main/java/org/apache/impala/util/IcebergUtil.java:[1056,26]
cannot find symbol
01:47:34 [ERROR] symbol: variable IO_MANIFEST_CACHE_EXPIRATION_INTERVAL_MS
01:47:34 [ERROR] location: class org.apache.iceberg.CatalogProperties
01:47:34 [ERROR]
/data0/jenkins/workspace/impala-private-gerrit-parameterized/repos/Impala/fe/src/main/java/org/apache/impala/util/IcebergUtil.java:[1057,26]
cannot find symbol
01:47:34 [ERROR] symbol: variable IO_MANIFEST_CACHE_MAX_TOTAL_BYTES
01:47:34 [ERROR] location: class org.apache.iceberg.CatalogProperties
01:47:34 [ERROR]
/data0/jenkins/workspace/impala-private-gerrit-parameterized/repos/Impala/fe/src/main/java/org/apache/impala/util/IcebergUtil.java:[1058,26]
cannot find symbol
01:47:34 [ERROR] symbol: variable IO_MANIFEST_CACHE_MAX_CONTENT_LENGTH
01:47:34 [ERROR] location: class org.apache.iceberg.CatalogProperties
http://gerrit.cloudera.org:8080/#/c/18977/7/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/18977/7/bin/impala-config.sh@336
PS7, Line 336: export USE_APACHE_HIVE=${USE_APACHE_HIVE:=true}
USE_APACHE_HIVE is already initialized at line 77:
https://github.com/apache/impala/blob/ff7b5db6002ccb047262cd7118e2e11ab09ef40a/bin/impala-config.sh#L77
I think we need to set it to true here.
--
To view, visit http://gerrit.cloudera.org:8080/18977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399
Gerrit-Change-Number: 18977
Gerrit-PatchSet: 7
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Comment-Date: Mon, 20 Feb 2023 10:13:53 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Thu, 16 Feb 2023 04:24:00 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9051/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 15 Feb 2023 23:14:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12381/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 15 Feb 2023 20:11:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 7: I didn't notice that "commons-io.version" has been missing since IMPALA-11670. (https://github.com/apache/impala/commit/83c5e6e4098d8ed75de09a7e228d6ef10de2ee12) I fixed this error by adding it. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 15 Feb 2023 20:09:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/12380/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 15 Feb 2023 20:04:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml M java/pom.xml 9 files changed, 157 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18977/7 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 7 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml M java/pom.xml 9 files changed, 157 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18977/6 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/18977/6/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/18977/6/bin/bootstrap_toolchain.py@614 PS6, Line 614: o flake8: W504 line break after binary operator -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 15 Feb 2023 19:45:13 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Quanlong Huang has posted comments on this change. (
http://gerrit.cloudera.org:8080/18977 )
Change subject: IMPALA-10408: Support build using Apache components
..
Patch Set 5:
(3 comments)
> Patch Set 4:
>
> I think build failure is not related to changed codes.
> It caused by server certification verficiation error.
>
> "fatal: unable to access 'https://gerrit.cloudera.org/Impala-ASF/': server
> certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt
> CRLfile: none"
After the certificate issue is resolved, I retriggered the job:
https://jenkins.impala.io/job/gerrit-code-review-checks/12355/
There is a build failure on FE:
00:14:45 [ERROR] [ERROR] Some problems were encountered while processing the
POMs:
[ERROR] 'dependencies.dependency.version' for commons-lang:commons-lang:jar
must be a valid version but is '${commons-io.version}'. @
org.apache.impala:impala-frontend:[unknown-version],
/home/ubuntu/Impala/fe/pom.xml, line 284, column 16
[ERROR] 'dependencies.dependency.version' for commons-lang:commons-lang:jar
must be a valid version but is '${commons-io.version}'. @
org.apache.impala:nested-table-flattener:[unknown-version],
/home/ubuntu/Impala/java/TableFlattener/pom.xml, line 70, column 16
00:14:45 [ERROR] The build could not read 2 projects -> [Help 1]
00:14:45 [ERROR]
00:14:45 [ERROR] The project org.apache.impala:impala-frontend:4.3.0-SNAPSHOT
(/home/ubuntu/Impala/fe/pom.xml) has 1 error
00:14:45 [ERROR] 'dependencies.dependency.version' for
commons-lang:commons-lang:jar must be a valid version but is
'${commons-io.version}'. @ org.apache.impala:impala-frontend:[unknown-version],
/home/ubuntu/Impala/fe/pom.xml, line 284, column 16
00:14:45 [ERROR]
00:14:45 [ERROR] The project
org.apache.impala:nested-table-flattener:4.3.0-SNAPSHOT
(/home/ubuntu/Impala/java/TableFlattener/pom.xml) has 1 error
00:14:45 [ERROR] 'dependencies.dependency.version' for
commons-lang:commons-lang:jar must be a valid version but is
'${commons-io.version}'. @
org.apache.impala:nested-table-flattener:[unknown-version],
/home/ubuntu/Impala/java/TableFlattener/pom.xml, line 70, column 16
00:14:45 [ERROR]
00:14:45 [ERROR] To see the full stack trace of the errors, re-run Maven with
the -e switch.
00:14:45 [ERROR] Re-run Maven using the -X switch to enable full debug logging.
00:14:45 [ERROR]
00:14:45 [ERROR] For more information about the errors and possible solutions,
please read the following articles:
00:14:45 [ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
mvn -U -U -B install -DskipTests exited with code 0
More in https://jenkins.impala.io/job/ubuntu-16.04-build-only/17602/console
http://gerrit.cloudera.org:8080/#/c/18977/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18977/5//COMMIT_MSG@8
PS5, Line 8:
Please mention how this is supported and how you verified the build. Did all
the tests pass?
Please also mention why we need changes on RangerAccessRequestImpl in the
commit message.
http://gerrit.cloudera.org:8080/#/c/18977/5/bin/jenkins/build-all-flag-combinations.sh
File bin/jenkins/build-all-flag-combinations.sh:
http://gerrit.cloudera.org:8080/#/c/18977/5/bin/jenkins/build-all-flag-combinations.sh@48
PS5, Line 48: "-skiptests -noclean -use_apache_hive"
We need new options here for the apache build so we can verify it in the
pre-commit jobs.
http://gerrit.cloudera.org:8080/#/c/18977/5/java/TableFlattener/pom.xml
File java/TableFlattener/pom.xml:
http://gerrit.cloudera.org:8080/#/c/18977/5/java/TableFlattener/pom.xml@70
PS5, Line 70: commons-io.version
This need to be defined in java/pom.xml.
Could you also mention the reason of adding commons-lang in the commit message?
--
To view, visit http://gerrit.cloudera.org:8080/18977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399
Gerrit-Change-Number: 18977
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Quanlong Huang
Gerrit-Comment-Date: Wed, 15 Feb 2023 00:40:11 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 4: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/12376/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 15 Feb 2023 00:17:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 4: I think build failure is not related to changed codes. It caused by server certification verficiation error. "fatal: unable to access 'https://gerrit.cloudera.org/Impala-ASF/': server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none" -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 11 Feb 2023 02:38:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml 8 files changed, 155 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18977/4 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 4: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/12355/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Sat, 11 Feb 2023 02:33:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 3: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/12352/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Fri, 10 Feb 2023 20:18:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml 8 files changed, 141 insertions(+), 47 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18977/3 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 1: Hello Quanlong Huang. Thanks for reply. I'll do it soon. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Wed, 08 Feb 2023 15:16:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 1: Hi Yubi Lee, could you rebase the patch onto the master branch and fix the build failure? Appreciated for your contribution. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Mon, 06 Feb 2023 03:00:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 1: Thanks for your patch! I see you uploaded several patches in the same topic. In case you don't know that, you can update the patch by "git commit --amend" and then "git push asf-gerrit HEAD:refs/for/master". Gerrit will use the Change-Id to match the patch. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Quanlong Huang Gerrit-Comment-Date: Tue, 13 Sep 2022 12:28:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/11343/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 13 Sep 2022 04:07:26 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/18977 )
Change subject: IMPALA-10408: Support build using Apache components
..
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/18977/1/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:
http://gerrit.cloudera.org:8080/#/c/18977/1/bin/bootstrap_toolchain.py@519
PS1, Line 519: o
flake8: E501 line too long (140 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18977/1/bin/bootstrap_toolchain.py@524
PS1, Line 524: s
flake8: E501 line too long (171 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18977/1/bin/bootstrap_toolchain.py@539
PS1, Line 539: m
flake8: E501 line too long (130 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18977/1/bin/bootstrap_toolchain.py@544
PS1, Line 544: b
flake8: E501 line too long (132 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18977/1/bin/bootstrap_toolchain.py@605
PS1, Line 605: _
flake8: E501 line too long (123 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18977/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/18977/1/buildall.sh@415
PS1, Line 415: if [[ "${DOWNLOAD_CDH_COMPONENTS}" = true ]] || [[
"${DOWNLOAD_APACHE_COMPONENTS}" = true ]]; then
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/18977/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
File
fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java:
http://gerrit.cloudera.org:8080/#/c/18977/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@324
PS1, Line 324: req.setResource(new
RangerAccessResourceImpl(Collections.unmodifiableMap(resource)));
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/18977
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399
Gerrit-Change-Number: 18977
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Tue, 13 Sep 2022 04:04:10 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18977 Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml 8 files changed, 142 insertions(+), 51 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18977/1 -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/18976 ) Change subject: IMPALA-10408: Support build using Apache components .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/18976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: If89173150db1869172b2eddb0e444b4aa7af08eb Gerrit-Change-Number: 18976 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18976 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/11342/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If89173150db1869172b2eddb0e444b4aa7af08eb Gerrit-Change-Number: 18976 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 13 Sep 2022 03:56:15 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/18975 ) Change subject: IMPALA-10408: Support build using Apache components .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/18975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I0cde807856d39e94c6d3eb8738fa7f27d31ce782 Gerrit-Change-Number: 18975 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/18976 )
Change subject: IMPALA-10408: Support build using Apache components
..
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/18976/1/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:
http://gerrit.cloudera.org:8080/#/c/18976/1/bin/bootstrap_toolchain.py@519
PS1, Line 519: o
flake8: E501 line too long (140 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18976/1/bin/bootstrap_toolchain.py@524
PS1, Line 524: s
flake8: E501 line too long (171 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18976/1/bin/bootstrap_toolchain.py@539
PS1, Line 539: m
flake8: E501 line too long (130 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18976/1/bin/bootstrap_toolchain.py@544
PS1, Line 544: b
flake8: E501 line too long (132 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18976/1/bin/bootstrap_toolchain.py@605
PS1, Line 605: _
flake8: E501 line too long (123 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18976/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/18976/1/buildall.sh@415
PS1, Line 415: if [[ "${DOWNLOAD_CDH_COMPONENTS}" = true ]] || [[
"${DOWNLOAD_APACHE_COMPONENTS}" = true ]]; then
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/18976/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
File
fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java:
http://gerrit.cloudera.org:8080/#/c/18976/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@324
PS1, Line 324: req.setResource(new
RangerAccessResourceImpl(Collections.unmodifiableMap(resource)));
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/18976
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If89173150db1869172b2eddb0e444b4aa7af08eb
Gerrit-Change-Number: 18976
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Tue, 13 Sep 2022 03:53:05 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has restored this change. ( http://gerrit.cloudera.org:8080/18976 ) Change subject: IMPALA-10408: Support build using Apache components .. Restored -- To view, visit http://gerrit.cloudera.org:8080/18976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: restore Gerrit-Change-Id: If89173150db1869172b2eddb0e444b4aa7af08eb Gerrit-Change-Number: 18976 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/18976 ) Change subject: IMPALA-10408: Support build using Apache components .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/18976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: If89173150db1869172b2eddb0e444b4aa7af08eb Gerrit-Change-Number: 18976 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18976 Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: If89173150db1869172b2eddb0e444b4aa7af08eb --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml 8 files changed, 142 insertions(+), 51 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/18976/1 -- To view, visit http://gerrit.cloudera.org:8080/18976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If89173150db1869172b2eddb0e444b4aa7af08eb Gerrit-Change-Number: 18976 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18975 Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: I0cde807856d39e94c6d3eb8738fa7f27d31ce782 --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml M java/executor-deps/pom.xml 9 files changed, 167 insertions(+), 52 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/18975/1 -- To view, visit http://gerrit.cloudera.org:8080/18975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0cde807856d39e94c6d3eb8738fa7f27d31ce782 Gerrit-Change-Number: 18975 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18975 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/11341/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0cde807856d39e94c6d3eb8738fa7f27d31ce782 Gerrit-Change-Number: 18975 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 13 Sep 2022 03:38:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/18966 ) Change subject: IMPALA-10408: Support build using Apache components .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/18966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e Gerrit-Change-Number: 18966 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has restored this change. ( http://gerrit.cloudera.org:8080/18966 ) Change subject: IMPALA-10408: Support build using Apache components .. Restored -- To view, visit http://gerrit.cloudera.org:8080/18966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: restore Gerrit-Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e Gerrit-Change-Number: 18966 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/18975 )
Change subject: IMPALA-10408: Support build using Apache components
..
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/18975/1/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:
http://gerrit.cloudera.org:8080/#/c/18975/1/bin/bootstrap_toolchain.py@519
PS1, Line 519: o
flake8: E501 line too long (140 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18975/1/bin/bootstrap_toolchain.py@524
PS1, Line 524: s
flake8: E501 line too long (171 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18975/1/bin/bootstrap_toolchain.py@539
PS1, Line 539: m
flake8: E501 line too long (130 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18975/1/bin/bootstrap_toolchain.py@544
PS1, Line 544: b
flake8: E501 line too long (132 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18975/1/bin/bootstrap_toolchain.py@605
PS1, Line 605: _
flake8: E501 line too long (123 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18975/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/18975/1/buildall.sh@415
PS1, Line 415: if [[ "${DOWNLOAD_CDH_COMPONENTS}" = true ]] || [[
"${DOWNLOAD_APACHE_COMPONENTS}" = true ]]; then
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/18975/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
File
fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java:
http://gerrit.cloudera.org:8080/#/c/18975/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@324
PS1, Line 324: req.setResource(new
RangerAccessResourceImpl(Collections.unmodifiableMap(resource)));
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/18975
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0cde807856d39e94c6d3eb8738fa7f27d31ce782
Gerrit-Change-Number: 18975
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Tue, 13 Sep 2022 03:35:05 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has abandoned this change. ( http://gerrit.cloudera.org:8080/18966 ) Change subject: IMPALA-10408: Support build using Apache components .. Abandoned fix bug -- To view, visit http://gerrit.cloudera.org:8080/18966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e Gerrit-Change-Number: 18966 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18966 ) Change subject: IMPALA-10408: Support build using Apache components .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/11332/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/18966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e Gerrit-Change-Number: 18966 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Sun, 11 Sep 2022 00:29:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
Impala Public Jenkins has posted comments on this change. (
http://gerrit.cloudera.org:8080/18966 )
Change subject: IMPALA-10408: Support build using Apache components
..
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/18966/1/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:
http://gerrit.cloudera.org:8080/#/c/18966/1/bin/bootstrap_toolchain.py@519
PS1, Line 519: o
flake8: E501 line too long (140 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18966/1/bin/bootstrap_toolchain.py@524
PS1, Line 524: s
flake8: E501 line too long (171 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18966/1/bin/bootstrap_toolchain.py@539
PS1, Line 539: m
flake8: E501 line too long (130 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18966/1/bin/bootstrap_toolchain.py@544
PS1, Line 544: b
flake8: E501 line too long (132 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18966/1/bin/bootstrap_toolchain.py@605
PS1, Line 605: _
flake8: E501 line too long (123 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/18966/1/buildall.sh
File buildall.sh:
http://gerrit.cloudera.org:8080/#/c/18966/1/buildall.sh@415
PS1, Line 415: if [[ "${DOWNLOAD_CDH_COMPONENTS}" = true ]] || [[
"${DOWNLOAD_APACHE_COMPONENTS}" = true ]]; then
line too long (102 > 90)
http://gerrit.cloudera.org:8080/#/c/18966/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java
File
fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java:
http://gerrit.cloudera.org:8080/#/c/18966/1/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@324
PS1, Line 324: req.setResource(new
RangerAccessResourceImpl(Collections.unmodifiableMap(resource)));
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/18966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e
Gerrit-Change-Number: 18966
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Sun, 11 Sep 2022 00:26:18 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10408: Support build using Apache components
eubn...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18966 Change subject: IMPALA-10408: Support build using Apache components .. IMPALA-10408: Support build using Apache components Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e --- M README-build.md M bin/bootstrap_toolchain.py M bin/impala-config.sh M buildall.sh M fe/pom.xml M fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java M fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java M java/TableFlattener/pom.xml M java/executor-deps/pom.xml 9 files changed, 167 insertions(+), 52 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/18966/1 -- To view, visit http://gerrit.cloudera.org:8080/18966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id6499d03aac89233d92cd401e58b67c5fb043b5e Gerrit-Change-Number: 18966 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward
