[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 10: Thank you all for your reviews! -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 10 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 11 Apr 2025 14:34:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. IMPALA-13930: ImpylaHS2Connection should only open cursor as needed Before this patch, ImpylaHS2Connection unconditionally opened a cursor (and HS2 session) as it connected, followed by running a "SET ALL" query to populate the default query options. This patch changes the behavior of ImpylaHS2Connection to open the default cursor only when querying is needed for the first time. This helps preserve assertions for a test that is sensitive about client connection, like IMPALA-13925. Default query options are now parsed from newly instantiated TQueryOptions object rather than issuing a "SET ALL" query or making BeeswaxService.get_default_configuration() RPC. Fix test_query_profile_contains_query_compilation_metadata_cached_event slightly by setting the 'sync_ddl' option because the test is flaky without it. Tweak test_max_hs2_sessions_per_user to run queries so that sessions will open. Deduplicate test cases between utc-timestamp-functions.test and local-timestamp-functions.test. Rename TestUtcTimestampFunctions to TestTimestampFunctions, and expand it to also tests local-timestamp-functions.test and file-formats-with-local-tz-conversion.test. The table_format is now contrained to 'test/none' because it is unnecessary to permute other table_format. Deprecate 'use_local_tz_for_unix_timestamp_conversions' in favor of query option with the same name. Filed IMPALA-13953 to update the documentation of 'use_local_tz_for_unix_timestamp_conversions' flag/option. Testing: Run and pass a few pytests such as: test_admission_controller.py test_observability.py test_runtime_filters.py test_session_expiration.py. test_set.py Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Reviewed-on: http://gerrit.cloudera.org:8080/22731 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/service/impala-server.cc M testdata/workloads/functional-query/queries/QueryTest/local-timestamp-functions.test M testdata/workloads/functional-query/queries/QueryTest/utc-timestamp-functions.test M tests/common/impala_connection.py M tests/custom_cluster/test_local_tz_conversion.py M tests/custom_cluster/test_session_expiration.py M tests/query_test/test_exprs.py M tests/query_test/test_observability.py 8 files changed, 105 insertions(+), 179 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 10 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 9 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 11 Apr 2025 04:37:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 9 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Thu, 10 Apr 2025 23:03:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 9: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11723/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 9 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Thu, 10 Apr 2025 23:03:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 8: Code-Review+2 Thanks for addressing my previous comments Riza! -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Thu, 10 Apr 2025 23:02:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/18883/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Thu, 10 Apr 2025 23:00:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/22731/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22731/6//COMMIT_MSG@9 PS6, Line 9: Before this patch, ImpylaHS2Connection unconditionally opened a : cursor (and HS2 session) as it connected, followed by running a "SET : ALL" que > Could we slightly change this paragraph to the following so that it would b Done http://gerrit.cloudera.org:8080/#/c/22731/6//COMMIT_MSG@20 PS6, Line 20: Fix test_query_profile_contains_query_compilation_metadata_cached_event : slightly by setting the 'sync_ddl' option because the test is flaky : without it. > It's just for my own understanding. Nothing has to be changed here. I just deflake it along with this patch. Without this patch, It should be possible to reproduce the flakiness with sufficient loop. -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Thu, 10 Apr 2025 22:35:49 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Hello Fang-Yu Rao, Yida Wu, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/22731 to look at the new patch set (#8). Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. IMPALA-13930: ImpylaHS2Connection should only open cursor as needed Before this patch, ImpylaHS2Connection unconditionally opened a cursor (and HS2 session) as it connected, followed by running a "SET ALL" query to populate the default query options. This patch changes the behavior of ImpylaHS2Connection to open the default cursor only when querying is needed for the first time. This helps preserve assertions for a test that is sensitive about client connection, like IMPALA-13925. Default query options are now parsed from newly instantiated TQueryOptions object rather than issuing a "SET ALL" query or making BeeswaxService.get_default_configuration() RPC. Fix test_query_profile_contains_query_compilation_metadata_cached_event slightly by setting the 'sync_ddl' option because the test is flaky without it. Tweak test_max_hs2_sessions_per_user to run queries so that sessions will open. Deduplicate test cases between utc-timestamp-functions.test and local-timestamp-functions.test. Rename TestUtcTimestampFunctions to TestTimestampFunctions, and expand it to also tests local-timestamp-functions.test and file-formats-with-local-tz-conversion.test. The table_format is now contrained to 'test/none' because it is unnecessary to permute other table_format. Deprecate 'use_local_tz_for_unix_timestamp_conversions' in favor of query option with the same name. Filed IMPALA-13953 to update the documentation of 'use_local_tz_for_unix_timestamp_conversions' flag/option. Testing: Run and pass a few pytests such as: test_admission_controller.py test_observability.py test_runtime_filters.py test_session_expiration.py. test_set.py Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 --- M be/src/service/impala-server.cc M testdata/workloads/functional-query/queries/QueryTest/local-timestamp-functions.test M testdata/workloads/functional-query/queries/QueryTest/utc-timestamp-functions.test M tests/common/impala_connection.py M tests/custom_cluster/test_local_tz_conversion.py M tests/custom_cluster/test_session_expiration.py M tests/query_test/test_exprs.py M tests/query_test/test_observability.py 8 files changed, 105 insertions(+), 179 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/22731/8 -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Hello Fang-Yu Rao, Yida Wu, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/22731 to look at the new patch set (#7). Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. IMPALA-13930: ImpylaHS2Connection should only open cursor as needed ImpylaHS2Connection open a cursor (and HS2 session) as it connect, followed by running a "SET ALL" query to populate the default query options. This patch changes the behavior of ImpylaHS2Connection to open the default cursor only when querying is needed for the first time. This helps preserve assertions for a test that is sensitive about client connection, like IMPALA-13925. Default query options are now parsed from newly instantiated TQueryOptions object rather than issuing a "SET ALL" query or making BeeswaxService.get_default_configuration() RPC. Fix test_query_profile_contains_query_compilation_metadata_cached_event slightly by setting the 'sync_ddl' option because the test is flaky without it. Tweak test_max_hs2_sessions_per_user to run queries so that sessions will open. Deduplicate test cases between utc-timestamp-functions.test and local-timestamp-functions.test. Rename TestUtcTimestampFunctions to TestTimestampFunctions, and expand it to also tests local-timestamp-functions.test and file-formats-with-local-tz-conversion.test. The table_format is now contrained to 'test/none' because it is unnecessary to permute other table_format. Deprecate 'use_local_tz_for_unix_timestamp_conversions' in favor of query option with the same name. Filed IMPALA-13953 to update the documentation of 'use_local_tz_for_unix_timestamp_conversions' flag/option. Testing: Run and pass a few pytests such as: test_admission_controller.py test_observability.py test_runtime_filters.py test_session_expiration.py. test_set.py Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 --- M be/src/service/impala-server.cc M testdata/workloads/functional-query/queries/QueryTest/local-timestamp-functions.test M testdata/workloads/functional-query/queries/QueryTest/utc-timestamp-functions.test M tests/common/impala_connection.py M tests/custom_cluster/test_local_tz_conversion.py M tests/custom_cluster/test_session_expiration.py M tests/query_test/test_exprs.py M tests/query_test/test_observability.py 8 files changed, 105 insertions(+), 179 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/22731/7 -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 6: Code-Review+1 (2 comments) Thanks for taking care of this Riza! I left 2 minor comments. I do not have any other suggestion. http://gerrit.cloudera.org:8080/#/c/22731/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22731/6//COMMIT_MSG@9 PS6, Line 9: ImpylaHS2Connection open a cursor (and HS2 session) as it connect, : followed by running a "SET ALL" query to populate the default query : options. Could we slightly change this paragraph to the following so that it would be clear as to what ImpylaHS2Connection behaved before this patch? Before this patch, ImpylaHS2Connection unconditionally opened a cursor (and HS2 session) as it connected, followed by running a "SET ALL" query to populate the default query options. http://gerrit.cloudera.org:8080/#/c/22731/6//COMMIT_MSG@20 PS6, Line 20: Fix test_query_profile_contains_query_compilation_metadata_cached_event : slightly by setting the 'sync_ddl' option because the test is flaky : without it. It's just for my own understanding. Nothing has to be changed here. Does 'test_query_profile_contains_query_compilation_metadata_cached_event' become flaky because of this patch? Or you just deflaked the test along with the changes to how default query options are collected? -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Thu, 10 Apr 2025 21:55:45 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/18816/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 04 Apr 2025 02:11:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22731/5/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22731/5/tests/common/impala_connection.py@a448 PS5, Line 448: > Ah, so this would do a beeswax-only rpc that didn't establish a session? That is correct. -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 04 Apr 2025 20:06:41 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22731/5/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22731/5/tests/common/impala_connection.py@a448 PS5, Line 448: Ah, so this would do a beeswax-only rpc that didn't establish a session? -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 04 Apr 2025 19:33:23 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Hello Fang-Yu Rao, Yida Wu, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/22731 to look at the new patch set (#5). Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. IMPALA-13930: ImpylaHS2Connection should only open cursor as needed ImpylaHS2Connection open a cursor (and HS2 session) as it connect, followed by running a "SET ALL" query to populate the default query options. This patch changes the behavior of ImpylaHS2Connection to open the default cursor only when querying is needed for the first time. This helps preserve assertions for a test that is sensitive about client connection, like IMPALA-13925. Default query options are now parsed from newly instantiated TQueryOptions object rather than issuing a "SET ALL" query or making BeeswaxService.get_default_configuration() RPC. Fix test_query_profile_contains_query_compilation_metadata_cached_event slightly by setting the 'sync_ddl' option because the test is flaky without it. Tweak test_max_hs2_sessions_per_user to run queries so that sessions will open. Testing: Run and pass a few pytests such as: test_admission_controller.py test_observability.py test_runtime_filters.py test_session_expiration.py. test_set.py Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 --- M tests/common/impala_connection.py M tests/custom_cluster/test_session_expiration.py M tests/query_test/test_observability.py 3 files changed, 61 insertions(+), 61 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/22731/5 -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Riza Suminto has posted comments on this change. (
http://gerrit.cloudera.org:8080/22731 )
Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as
needed
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22731/4/tests/common/impala_connection.py
File tests/common/impala_connection.py:
http://gerrit.cloudera.org:8080/#/c/22731/4/tests/common/impala_connection.py@632
PS4, Line 632: self.__default_query_options = {}
Really, this can just be a constant, set above, regardless of connection types.
--
To view, visit http://gerrit.cloudera.org:8080/22731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5
Gerrit-Change-Number: 22731
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto
Gerrit-Reviewer: Fang-Yu Rao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Smith
Gerrit-Reviewer: Riza Suminto
Gerrit-Reviewer: Yida Wu
Gerrit-Comment-Date: Fri, 04 Apr 2025 14:39:56 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 5: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/18823/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 04 Apr 2025 16:05:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22731/4/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/22731/4/tests/common/impala_connection.py@632 PS4, Line 632: name = name.lower() > Really, this can just be a constant, set above, regardless of connection ty Done -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 04 Apr 2025 15:38:05 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/18819/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 04 Apr 2025 14:41:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Hello Fang-Yu Rao, Yida Wu, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/22731 to look at the new patch set (#4). Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. IMPALA-13930: ImpylaHS2Connection should only open cursor as needed ImpylaHS2Connection open a cursor (and HS2 session) as it connect, followed by running a "SET ALL" query to populate the default query options. This patch changes the behavior of ImpylaHS2Connection to open the default cursor only when querying is needed for the first time. This helps preserve assertions for a test that is sensitive about client connection, like IMPALA-13925. Changed the default query option parsing technique from running a "SET ALL" query to parsing newly instantiated TQueryOptions object. Fix test_query_profile_contains_query_compilation_metadata_cached_event slightly by setting the 'sync_ddl' option because the test is flaky without it. Tweak test_max_hs2_sessions_per_user to run queries so that sessions will open. Testing: Run and pass a few pytests such as test_runtime_filters.py, test_observability.py, test_admission_controller.py, and test_session_expiration.py. Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 --- M tests/common/impala_connection.py M tests/custom_cluster/test_session_expiration.py M tests/query_test/test_observability.py 3 files changed, 58 insertions(+), 35 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/22731/4 -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11696/ -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 04 Apr 2025 10:44:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Hello Fang-Yu Rao, Yida Wu, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/22731 to look at the new patch set (#3). Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. IMPALA-13930: ImpylaHS2Connection should only open cursor as needed ImpylaHS2Connection open a cursor (and HS2 session) as it connect, followed by running a "SET ALL" query to populate the default query options. This patch changes the behavior of ImpylaHS2Connection to open the default cursor only when querying is needed for the first time. This helps preserve assertions for a test that is sensitive about client connection, like IMPALA-13925. Changed the default query option parsing technique from running a "SET ALL" query to parsing newly instantiated TQueryOptions object. Fix test_query_profile_contains_query_compilation_metadata_cached_event slightly by setting the 'sync_ddl' option because the test is flaky without it. Testing: Run and pass a few pytests such as test_runtime_filters.py, test_observability.py, and test_admission_controller.py. Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 --- M tests/common/impala_connection.py M tests/query_test/test_observability.py 2 files changed, 52 insertions(+), 33 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/22731/3 -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/18818/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 04 Apr 2025 05:34:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 ) Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11696/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu Gerrit-Comment-Date: Fri, 04 Apr 2025 05:10:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Hello Fang-Yu Rao, Yida Wu, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/22731 to look at the new patch set (#2). Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. IMPALA-13930: ImpylaHS2Connection should only open cursor as needed ImpylaHS2Connection open a cursor (and HS2 session) as it connect, followed by running a "SET ALL" query to populate the default query options. This patch changes the behavior of ImpylaHS2Connection to open the default cursor only when querying is needed for the first time. This helps preserve assertions for a test that is sensitive about client connection, like IMPALA-13925. Changed the default query option parsing technique from running a "SET ALL" query to parsing newly instantiated TQueryOptions object. Fix test_query_profile_contains_query_compilation_metadata_cached_event slightly by setting the 'sync_ddl' option because the test is flaky without it. Testing: Run and pass a few pytests such as test_runtime_filters.py, test_observability.py, and test_admission_controller.py. Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 --- M tests/common/impala_connection.py M tests/query_test/test_observability.py 2 files changed, 52 insertions(+), 33 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/22731/2 -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Riza Suminto Gerrit-Reviewer: Yida Wu
[Impala-ASF-CR] IMPALA-13930: ImpylaHS2Connection should only open cursor as needed
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22731 Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed .. IMPALA-13930: ImpylaHS2Connection should only open cursor as needed ImpylaHS2Connection used to open a cursor (and HS2 session) as it connect, followed by running "SET ALL" query to populate default query options. This patch change the behavior of ImpylaHS2Connection to open cursor only when querying is needed for the very first time. This help preserve assertion for test that sensitive about client connection, like IMPALA-13925. Changed the default query option parsing technique from running "SET ALL" query to parsing newly instantiated TQueryOptions object. Fix test_query_profile_contains_query_compilation_metadata_cached_event slightly with 'sync_ddl' options because the test is flaky without it. Testing: Run and pass few pytest such as test_runtime_filters.py, test_observability.py, and test_admission_controller.py. Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 --- M tests/common/impala_connection.py M tests/query_test/test_observability.py 2 files changed, 52 insertions(+), 33 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/22731/1 -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto
