[Impala-ASF-CR] IMPALA-14436: Calcite planner: Fix min/max runtime filters

2026-03-31 Thread Michael Smith (Code Review) 
Michael Smith has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/23912 )

Change subject: IMPALA-14436: Calcite planner: Fix min/max runtime filters
..

IMPALA-14436: Calcite planner: Fix min/max runtime filters

This patch fixes an issue where min/max runtime filters were not getting
created for nested loop joins. The conjuncts need to be placed in
the right variables when initializing the NestedLoopJoinNode.

For inner joins, all the conjuncts need to be in the filterConjuncts
in order to be processed for the min/max runtime filter.

This patch is needed to allow overlap_min_max_filters.test to succeed
for the Calcite planner.

An extra minor fix has been thrown into the patch: When the conjunct
is "IS NOT DISCTINCT FROM", this should be treated as an equi-join
conjunct.

Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
Reviewed-on: http://gerrit.cloudera.org:8080/23912
Reviewed-by: Michael Smith 
Reviewed-by: Joe McDonnell 
Tested-by: Impala Public Jenkins 
---
M 
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java
M 
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java
M 
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/phys/ImpalaNestedLoopJoinNode.java
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14a.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14b.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23a.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23b.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24a.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24b.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q44.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q54.test
11 files changed, 119 insertions(+), 82 deletions(-)

Approvals:
  Michael Smith: Looks good to me, but someone else must approve
  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/23912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
Gerrit-Change-Number: 23912
Gerrit-PatchSet: 10
Gerrit-Owner: Steve Carlin 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Fang-Yu Rao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Steve Carlin

[Impala-ASF-CR] IMPALA-14436: Calcite planner: Fix min/max runtime filters

2026-03-31 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23912 )

Change subject: IMPALA-14436: Calcite planner: Fix min/max runtime filters
..


Patch Set 9: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/23912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
Gerrit-Change-Number: 23912
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Fang-Yu Rao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Steve Carlin 
Gerrit-Comment-Date: Tue, 31 Mar 2026 21:12:17 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14436: Calcite planner: Fix min/max runtime filters

2026-03-31 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23912 )

Change subject: IMPALA-14436: Calcite planner: Fix min/max runtime filters
..


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13292/ 
DRY_RUN=true


--
To view, visit http://gerrit.cloudera.org:8080/23912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
Gerrit-Change-Number: 23912
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Fang-Yu Rao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Steve Carlin 
Gerrit-Comment-Date: Tue, 31 Mar 2026 16:44:51 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14436: Calcite planner: Fix min/max runtime filters

2026-03-31 Thread Joe McDonnell (Code Review) 
Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23912 )

Change subject: IMPALA-14436: Calcite planner: Fix min/max runtime filters
..


Patch Set 9: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/23912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
Gerrit-Change-Number: 23912
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Fang-Yu Rao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Steve Carlin 
Gerrit-Comment-Date: Tue, 31 Mar 2026 16:42:03 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14436: Calcite planner: Fix min/max runtime filters

2026-03-31 Thread Michael Smith (Code Review) 
Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23912 )

Change subject: IMPALA-14436: Calcite planner: Fix min/max runtime filters
..


Patch Set 9: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/23912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
Gerrit-Change-Number: 23912
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Fang-Yu Rao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Steve Carlin 
Gerrit-Comment-Date: Tue, 31 Mar 2026 16:22:29 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14436: Calcite planner: Fix min/max runtime filters

2026-03-30 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23912 )

Change subject: IMPALA-14436: Calcite planner: Fix min/max runtime filters
..


Patch Set 9:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/22049/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/23912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
Gerrit-Change-Number: 23912
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Fang-Yu Rao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Steve Carlin 
Gerrit-Comment-Date: Mon, 30 Mar 2026 17:14:43 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14436: Calcite planner: Fix min/max runtime filters

2026-03-30 Thread Steve Carlin (Code Review) 
Hello Aman Sinha, Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/23912

to look at the new patch set (#9).

Change subject: IMPALA-14436: Calcite planner: Fix min/max runtime filters
..

IMPALA-14436: Calcite planner: Fix min/max runtime filters

This patch fixes an issue where min/max runtime filters were not getting
created for nested loop joins. The conjuncts need to be placed in
the right variables when initializing the NestedLoopJoinNode.

For inner joins, all the conjuncts need to be in the filterConjuncts
in order to be processed for the min/max runtime filter.

This patch is needed to allow overlap_min_max_filters.test to succeed
for the Calcite planner.

An extra minor fix has been thrown into the patch: When the conjunct
is "IS NOT DISCTINCT FROM", this should be treated as an equi-join
conjunct.

Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
---
M 
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java
M 
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java
M 
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/phys/ImpalaNestedLoopJoinNode.java
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14a.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14b.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23a.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23b.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24a.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24b.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q44.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q54.test
11 files changed, 119 insertions(+), 82 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/23912/9
--
To view, visit http://gerrit.cloudera.org:8080/23912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
Gerrit-Change-Number: 23912
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Fang-Yu Rao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Steve Carlin

[Impala-ASF-CR] IMPALA-14436: Calcite planner: Fix min/max runtime filters

2026-03-10 Thread Michael Smith (Code Review) 
Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23912 )

Change subject: IMPALA-14436: Calcite planner: Fix min/max runtime filters
..


Patch Set 8: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23912/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java
File 
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java:

http://gerrit.cloudera.org:8080/#/c/23912/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java@151
PS8, Line 151: if (returnsSingleRow(this)) {
> It is still indeed needed despite the latest change. This line seems to be
Ack



--
To view, visit http://gerrit.cloudera.org:8080/23912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
Gerrit-Change-Number: 23912
Gerrit-PatchSet: 8
Gerrit-Owner: Steve Carlin 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Fang-Yu Rao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Steve Carlin 
Gerrit-Comment-Date: Tue, 10 Mar 2026 16:04:04 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14436: Calcite planner: Fix min/max runtime filters

2026-03-10 Thread Steve Carlin (Code Review) 
Steve Carlin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23912 )

Change subject: IMPALA-14436: Calcite planner: Fix min/max runtime filters
..


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23912/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java
File 
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java:

http://gerrit.cloudera.org:8080/#/c/23912/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java@151
PS8, Line 151: if (returnsSingleRow(this)) {
> Is this still needed? Does it map to similar code in Impala's older planner
It is still indeed needed despite the latest change. This line seems to be the 
reason: 
https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java#L477

The query that fails when removing this line is:
explain select count(*) from tpcds_parquet.store_sales
where ss_sales_price < (select min(ss_wholesale_cost) from 
tpcds_parquet.store_sales);

I verified in the code that the IsNonCorrelatedScalarQuery is set in the 
original planner.  Based on the comment, this seems to be needed.



--
To view, visit http://gerrit.cloudera.org:8080/23912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
Gerrit-Change-Number: 23912
Gerrit-PatchSet: 8
Gerrit-Owner: Steve Carlin 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Fang-Yu Rao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Steve Carlin 
Gerrit-Comment-Date: Tue, 10 Mar 2026 12:40:21 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14436: Calcite planner: Fix min/max runtime filters

2026-03-09 Thread Michael Smith (Code Review) 
Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23912 )

Change subject: IMPALA-14436: Calcite planner: Fix min/max runtime filters
..


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23912/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java
File 
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java:

http://gerrit.cloudera.org:8080/#/c/23912/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java@151
PS8, Line 151: if (returnsSingleRow(this)) {
Is this still needed? Does it map to similar code in Impala's older planner?



--
To view, visit http://gerrit.cloudera.org:8080/23912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
Gerrit-Change-Number: 23912
Gerrit-PatchSet: 8
Gerrit-Owner: Steve Carlin 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Fang-Yu Rao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Steve Carlin 
Gerrit-Comment-Date: Mon, 09 Mar 2026 23:11:21 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14436: Calcite planner: Fix min/max runtime filters

2026-03-07 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23912 )

Change subject: IMPALA-14436: Calcite planner: Fix min/max runtime filters
..


Patch Set 8:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/21884/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/23912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
Gerrit-Change-Number: 23912
Gerrit-PatchSet: 8
Gerrit-Owner: Steve Carlin 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Fang-Yu Rao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Steve Carlin 
Gerrit-Comment-Date: Sat, 07 Mar 2026 23:47:05 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14436: Calcite planner: Fix min/max runtime filters

2026-03-07 Thread Steve Carlin (Code Review) 
Steve Carlin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23912 )

Change subject: IMPALA-14436: Calcite planner: Fix min/max runtime filters
..


Patch Set 8:

(4 comments)

The code has been changed based on the suggestions made in IMPALA-14436.

http://gerrit.cloudera.org:8080/#/c/23912/7//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23912/7//COMMIT_MSG@9
PS7, Line 9: This patch fixes an issue where min/max runtime filters were not 
getting
   : created for nested loop joins. The conju
> I don't understand what the optimization does. What original Impala test ca
Addressed in general comment


http://gerrit.cloudera.org:8080/#/c/23912/7//COMMIT_MSG@18
PS7, Line 18:
: An extra minor fix h
> Is this still true? I'm not seeing a difference other than conjuncts vs joi
Comment changed


http://gerrit.cloudera.org:8080/#/c/23912/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java
File 
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java:

http://gerrit.cloudera.org:8080/#/c/23912/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java@567
PS7, Line 567:   private static class
> Can there be a limit 1 on HDFSSCAN nodes?
code removed


http://gerrit.cloudera.org:8080/#/c/23912/7/testdata/workloads/functional-query/queries/QueryTest/calcite.test
File testdata/workloads/functional-query/queries/QueryTest/calcite.test:

http://gerrit.cloudera.org:8080/#/c/23912/7/testdata/workloads/functional-query/queries/QueryTest/calcite.test@1263
PS7, Line 1263:
  :
> If I put this in Impala, I get the same plan whether this is limit 1 or lim
Test removed.  This is gonna be tested in the Jenkins run for 
overlap_min_max_filters.test so a new test is not needed.  The test fails 
without this patch.



--
To view, visit http://gerrit.cloudera.org:8080/23912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
Gerrit-Change-Number: 23912
Gerrit-PatchSet: 8
Gerrit-Owner: Steve Carlin 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Fang-Yu Rao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Steve Carlin 
Gerrit-Comment-Date: Sat, 07 Mar 2026 23:21:42 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14436: Calcite planner: Fix min/max runtime filters

2026-03-07 Thread Steve Carlin (Code Review) 
Hello Aman Sinha, Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public 
Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/23912

to look at the new patch set (#8).

Change subject: IMPALA-14436: Calcite planner: Fix min/max runtime filters
..

IMPALA-14436: Calcite planner: Fix min/max runtime filters

This patch fixes an issue where min/max runtime filters were not getting
created for nested loop joins. The conjuncts need to be placed in
the right variables when initializing the NestedLoopJoinNode.

For inner joins, all the conjuncts need to be in the filterConjuncts
in order to be processed for the min/max runtime filter.

This patch is needed to allow overlap_min_max_filters.test to succeed
for the Calcite planner.

An extra minor fix has been thrown into the patch: When the conjunct
is "IS NOT DISCTINCT FROM", this should be treated as an equi-join
conjunct.

Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
---
M 
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAggRel.java
M 
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java
M 
java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/phys/ImpalaNestedLoopJoinNode.java
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14a.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q14b.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23a.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q23b.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24a.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q24b.test
M 
testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q54.test
10 files changed, 119 insertions(+), 78 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/23912/8
--
To view, visit http://gerrit.cloudera.org:8080/23912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e5f9be67a775a771c0868ac4407410385e8a755
Gerrit-Change-Number: 23912
Gerrit-PatchSet: 8
Gerrit-Owner: Steve Carlin 
Gerrit-Reviewer: Aman Sinha 
Gerrit-Reviewer: Fang-Yu Rao 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Reviewer: Steve Carlin