[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. IMPALA-14719: Fixed race condition for Calcite property IMPALA-14710 was filed for a flaky test involving the calcite.default.charset property. Setting this property before the jar file is loaded fixes this issue. This commit also fixes two other issues: - IMPALA-14384: Class.forName() is only called once now. The compiler factory is stored in a singleton. - The Calcite planner is now part of the build and should be in the target directory. If the user explicitly sets the calcite planner option and the calcite jar file not found, an error is thrown rather than falling back. Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Reviewed-on: http://gerrit.cloudera.org:8080/23935 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/service/Frontend.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java 2 files changed, 22 insertions(+), 18 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Thu, 12 Feb 2026 08:36:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13073/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Thu, 12 Feb 2026 03:49:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 8: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13071/ -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 11 Feb 2026 22:42:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13071/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 11 Feb 2026 17:59:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 7: Clicked on verified by mistake. Starting GVO -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 11 Feb 2026 17:58:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 11 Feb 2026 17:59:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 11 Feb 2026 17:58:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Csaba Ringhofer has removed a vote on this change. Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Removed Verified+1 by Csaba Ringhofer -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 11 Feb 2026 17:57:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 7: Code-Review+2 This looks good to me -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 11 Feb 2026 17:22:03 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 7: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/21623/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Tue, 10 Feb 2026 23:07:10 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Tue, 10 Feb 2026 22:51:02 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/23935/6/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/23935/6/fe/src/main/java/org/apache/impala/service/Frontend.java@313 PS6, Line 313: private static CompilerFactory calciteCompilerFactory = null; > nit: could be a function call to initialize this instead of a static block. Yeah, you're right, I think it's better the way you suggested. -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Tue, 10 Feb 2026 22:43:12 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Hello Aman Sinha, Fang-Yu Rao, Peter Rozsa, Joe McDonnell, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/23935 to look at the new patch set (#7). Change subject: IMPALA-14719: Fixed race condition for Calcite property .. IMPALA-14719: Fixed race condition for Calcite property IMPALA-14710 was filed for a flaky test involving the calcite.default.charset property. Setting this property before the jar file is loaded fixes this issue. This commit also fixes two other issues: - IMPALA-14384: Class.forName() is only called once now. The compiler factory is stored in a singleton. - The Calcite planner is now part of the build and should be in the target directory. If the user explicitly sets the calcite planner option and the calcite jar file not found, an error is thrown rather than falling back. Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff --- M fe/src/main/java/org/apache/impala/service/Frontend.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java 2 files changed, 22 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/23935/7 -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 6: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23935/6/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/23935/6/fe/src/main/java/org/apache/impala/service/Frontend.java@313 PS6, Line 313: private static CompilerFactory calciteCompilerFactory = null; nit: could be a function call to initialize this instead of a static block. -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Tue, 10 Feb 2026 21:29:43 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/21622/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Tue, 10 Feb 2026 20:49:35 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Hello Aman Sinha, Fang-Yu Rao, Peter Rozsa, Joe McDonnell, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/23935 to look at the new patch set (#6). Change subject: IMPALA-14719: Fixed race condition for Calcite property .. IMPALA-14719: Fixed race condition for Calcite property IMPALA-14710 was filed for a flaky test involving the calcite.default.charset property. Setting this property before the jar file is loaded fixes this issue. This commit also fixes two other issues: - IMPALA-14384: Class.forName() is only called once now. The compiler factory is stored in a singleton. - The Calcite planner is now part of the build and should be in the target directory. If the user explicitly sets the calcite planner option and the calcite jar file not found, an error is thrown rather than falling back. Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff --- M fe/src/main/java/org/apache/impala/service/Frontend.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java 2 files changed, 20 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/23935/6 -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/23935/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23935/5//COMMIT_MSG@7 PS5, Line 7: MPALA-14719: Fixed race condition for Calcite property > This JIRA got cut off Done http://gerrit.cloudera.org:8080/#/c/23935/5/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/23935/5/fe/src/main/java/org/apache/impala/service/Frontend.java@313 PS5, Line 313: public > Can this be private? Done -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Tue, 10 Feb 2026 20:30:30 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Hello Aman Sinha, Fang-Yu Rao, Peter Rozsa, Joe McDonnell, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/23935 to look at the new patch set (#4). Change subject: IMPALA-14719: Fixed race condition for Calcite property .. IMPALA-14719: Fixed race condition for Calcite property IMPALA-14710 was filed for a flaky test involving the calcite.default.charset property. Setting this property before the jar file is loaded fixes this issue. This commit also fixes two other issues: - IMPALA-14384: Class.forName() is only called once now. The compiler factory is stored in a singleton. - The Calcite planner is now part of the build and should be in the target directory. If the user explicitly sets the calcite planner option and the calcite jar file not found, an error is thrown rather than falling back. Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff --- M fe/src/main/java/org/apache/impala/service/Frontend.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java 2 files changed, 18 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/23935/4 -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Csaba Ringhofer has posted comments on this change. (
http://gerrit.cloudera.org:8080/23935 )
Change subject: IMPALA-14719: Fixed race condition for Calcite property
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23935/3/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:
http://gerrit.cloudera.org:8080/#/c/23935/3/fe/src/main/java/org/apache/impala/service/Frontend.java@3780
PS3, Line 3780: private CompilerFactory getCalciteCompilerFactory(PlanCtx ctx)
: throws ImpalaException {
Can't we have threading issues here and set the singleton multiple times?
BTW what is the reason for initializing calcite compiler only on demand - is it
slow / needs a lot of memory? It seems simple to me to always initialize it on
startup.
--
To view, visit http://gerrit.cloudera.org:8080/23935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff
Gerrit-Change-Number: 23935
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin
Gerrit-Reviewer: Aman Sinha
Gerrit-Reviewer: Csaba Ringhofer
Gerrit-Reviewer: Fang-Yu Rao
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell
Gerrit-Reviewer: Michael Smith
Gerrit-Reviewer: Peter Rozsa
Gerrit-Comment-Date: Wed, 04 Feb 2026 09:10:36 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 3: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/21559/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Tue, 03 Feb 2026 19:16:34 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/21558/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Tue, 03 Feb 2026 19:16:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/21557/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Tue, 03 Feb 2026 19:14:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Hello Aman Sinha, Fang-Yu Rao, Peter Rozsa, Joe McDonnell, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/23935 to look at the new patch set (#3). Change subject: IMPALA-14719: Fixed race condition for Calcite property .. IMPALA-14719: Fixed race condition for Calcite property IMPALA-14710 was filed for a flaky test involving the calcite.default.charset property. Setting this property before the jar file is loaded fixes this issue. This commit also fixes two other issues: - IMPALA-14384: Class.forName() is only called once now. The compiler factory is stored in a singleton. - The Calcite planner is now part of the build and should be in the target directory. If the user explicitly sets the calcite planner option and the calcite jar file not found, an error is thrown rather than falling back. Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff --- M fe/src/main/java/org/apache/impala/service/Frontend.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java 2 files changed, 18 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/23935/3 -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 2: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23935/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/23935/2/fe/src/main/java/org/apache/impala/service/Frontend.java@3780 PS2, Line 3780: private CompilerFactory getCalciteCompilerFactory(PlanCtx ctx) line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Peter Rozsa Gerrit-Comment-Date: Tue, 03 Feb 2026 18:05:48 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. Patch Set 1: (1 comment) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23935/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/23935/1/fe/src/main/java/org/apache/impala/service/Frontend.java@3780 PS1, Line 3780: private CompilerFactory getCalciteCompilerFactory(PlanCtx ctx) line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Tue, 03 Feb 2026 18:03:40 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Steve Carlin has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/23935 ) Change subject: IMPALA-14719: Fixed race condition for Calcite property .. IMPALA-14719: Fixed race condition for Calcite property IMPALA-14710 was filed for a flaky test involving the calcite.default.charset property. Setting this property before the jar file is loaded fixes this issue. This commit also fixes two other issues: - IMPALA-14384: Class.forName() is only called once now. The compiler factory is stored in a singleton. - The Calcite planner is now part of the build and should be in the target directory. If the user explicitly sets the calcite planner option and the calcite jar file not found, an error is thrown rather than falling back. Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff --- M fe/src/main/java/org/apache/impala/service/Frontend.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java 2 files changed, 18 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/23935/2 -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin
[Impala-ASF-CR] IMPALA-14719: Fixed race condition for Calcite property
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23935 Change subject: IMPALA-14719: Fixed race condition for Calcite property .. IMPALA-14719: Fixed race condition for Calcite property IMPALA-14710 was filed for a flaky test involving the calcite.default.charset property. Setting this property before the jar file is loaded fixes this issue. This commit also fixes two other issues: - IMPALA-14384: Class.forName() is only called once now. The compiler factory is stored in a singleton. - The Calcite planner is now part of the build and should be in the target directory. If the user explicitly sets the calcite planner option and the calcite jar file not found, an error is thrown rather than falling back. Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff --- M fe/src/main/java/org/apache/impala/service/Frontend.java M java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java 2 files changed, 17 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/23935/1 -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin
