[Impala-ASF-CR] IMPALA-14731: Fix LIKE starting with % ending with escaped %
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23953 ) Change subject: IMPALA-14731: Fix LIKE starting with % ending with escaped % .. IMPALA-14731: Fix LIKE starting with % ending with escaped % The escape before the % at the end was not parsed properly as an escape wildcard. As an example, "%abc\%" matched for anything containing "abc\" (containing the backslash character), instead of any any string with the suffix "abc%". The fix is basically the same as the one for IMPALA-10849 but for the case when the pattern starts with %. New test cases were added to exprs.test. Change-Id: I6eebfaeffdb59d5d2c1cfbd331fa98d0391325e7 Reviewed-on: http://gerrit.cloudera.org:8080/23953 Reviewed-by: Csaba Ringhofer Tested-by: Impala Public Jenkins --- M be/src/exprs/like-predicate.cc M testdata/workloads/functional-query/queries/QueryTest/exprs.test 2 files changed, 41 insertions(+), 1 deletion(-) Approvals: Csaba Ringhofer: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/23953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6eebfaeffdb59d5d2c1cfbd331fa98d0391325e7 Gerrit-Change-Number: 23953 Gerrit-PatchSet: 3 Gerrit-Owner: Balazs Hevele Gerrit-Reviewer: Balazs Hevele Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell
[Impala-ASF-CR] IMPALA-14731: Fix LIKE starting with % ending with escaped %
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23953 ) Change subject: IMPALA-14731: Fix LIKE starting with % ending with escaped % .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/23953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6eebfaeffdb59d5d2c1cfbd331fa98d0391325e7 Gerrit-Change-Number: 23953 Gerrit-PatchSet: 2 Gerrit-Owner: Balazs Hevele Gerrit-Reviewer: Balazs Hevele Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Mon, 09 Feb 2026 18:57:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14731: Fix LIKE starting with % ending with escaped %
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23953 ) Change subject: IMPALA-14731: Fix LIKE starting with % ending with escaped % .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/21604/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/23953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6eebfaeffdb59d5d2c1cfbd331fa98d0391325e7 Gerrit-Change-Number: 23953 Gerrit-PatchSet: 2 Gerrit-Owner: Balazs Hevele Gerrit-Reviewer: Balazs Hevele Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Mon, 09 Feb 2026 14:28:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14731: Fix LIKE starting with % ending with escaped %
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23953 ) Change subject: IMPALA-14731: Fix LIKE starting with % ending with escaped % .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13056/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/23953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6eebfaeffdb59d5d2c1cfbd331fa98d0391325e7 Gerrit-Change-Number: 23953 Gerrit-PatchSet: 2 Gerrit-Owner: Balazs Hevele Gerrit-Reviewer: Balazs Hevele Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Mon, 09 Feb 2026 14:13:32 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14731: Fix LIKE starting with % ending with escaped %
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23953 ) Change subject: IMPALA-14731: Fix LIKE starting with % ending with escaped % .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/23953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6eebfaeffdb59d5d2c1cfbd331fa98d0391325e7 Gerrit-Change-Number: 23953 Gerrit-PatchSet: 2 Gerrit-Owner: Balazs Hevele Gerrit-Reviewer: Balazs Hevele Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 09 Feb 2026 14:10:44 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14731: Fix LIKE starting with % ending with escaped %
Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/23953 ) Change subject: IMPALA-14731: Fix LIKE starting with % ending with escaped % .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23953/1/testdata/workloads/functional-query/queries/QueryTest/exprs.test File testdata/workloads/functional-query/queries/QueryTest/exprs.test: http://gerrit.cloudera.org:8080/#/c/23953/1/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3312 PS1, Line 3312: > can you add a test where before the fix true was returned incorrectly and n The test query in line 3291 is such a case. I flipped the logic, so that it is now clear that the pattern should _not_ match the string. -- To view, visit http://gerrit.cloudera.org:8080/23953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6eebfaeffdb59d5d2c1cfbd331fa98d0391325e7 Gerrit-Change-Number: 23953 Gerrit-PatchSet: 2 Gerrit-Owner: Balazs Hevele Gerrit-Reviewer: Balazs Hevele Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 09 Feb 2026 14:06:13 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14731: Fix LIKE starting with % ending with escaped %
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/23953 to look at the new patch set (#2). Change subject: IMPALA-14731: Fix LIKE starting with % ending with escaped % .. IMPALA-14731: Fix LIKE starting with % ending with escaped % The escape before the % at the end was not parsed properly as an escape wildcard. As an example, "%abc\%" matched for anything containing "abc\" (containing the backslash character), instead of any any string with the suffix "abc%". The fix is basically the same as the one for IMPALA-10849 but for the case when the pattern starts with %. New test cases were added to exprs.test. Change-Id: I6eebfaeffdb59d5d2c1cfbd331fa98d0391325e7 --- M be/src/exprs/like-predicate.cc M testdata/workloads/functional-query/queries/QueryTest/exprs.test 2 files changed, 41 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/23953/2 -- To view, visit http://gerrit.cloudera.org:8080/23953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6eebfaeffdb59d5d2c1cfbd331fa98d0391325e7 Gerrit-Change-Number: 23953 Gerrit-PatchSet: 2 Gerrit-Owner: Balazs Hevele Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-14731: Fix LIKE starting with % ending with escaped %
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23953 ) Change subject: IMPALA-14731: Fix LIKE starting with % ending with escaped % .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/21603/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/23953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6eebfaeffdb59d5d2c1cfbd331fa98d0391325e7 Gerrit-Change-Number: 23953 Gerrit-PatchSet: 1 Gerrit-Owner: Balazs Hevele Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 09 Feb 2026 12:17:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14731: Fix LIKE starting with % ending with escaped %
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23953 ) Change subject: IMPALA-14731: Fix LIKE starting with % ending with escaped % .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23953/1/testdata/workloads/functional-query/queries/QueryTest/exprs.test File testdata/workloads/functional-query/queries/QueryTest/exprs.test: http://gerrit.cloudera.org:8080/#/c/23953/1/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3312 PS1, Line 3312: can you add a test where before the fix true was returned incorrectly and now Impala returns false? -- To view, visit http://gerrit.cloudera.org:8080/23953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6eebfaeffdb59d5d2c1cfbd331fa98d0391325e7 Gerrit-Change-Number: 23953 Gerrit-PatchSet: 1 Gerrit-Owner: Balazs Hevele Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Mon, 09 Feb 2026 12:01:00 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14731: Fix LIKE starting with % ending with escaped %
Balazs Hevele has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23953 Change subject: IMPALA-14731: Fix LIKE starting with % ending with escaped % .. IMPALA-14731: Fix LIKE starting with % ending with escaped % The escape before the % at the end was not parsed properly as an escape wildcard. As an example, "%abc\%" matched for anything containing "abc\" (containing the backslash character), instead of any any string with the suffix "abc%". The fix is basically the same as the one for IMPALA-10849 but for the case when the pattern starts with %. New test cases were added to exprs.test. Change-Id: I6eebfaeffdb59d5d2c1cfbd331fa98d0391325e7 --- M be/src/exprs/like-predicate.cc M testdata/workloads/functional-query/queries/QueryTest/exprs.test 2 files changed, 41 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/23953/1 -- To view, visit http://gerrit.cloudera.org:8080/23953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6eebfaeffdb59d5d2c1cfbd331fa98d0391325e7 Gerrit-Change-Number: 23953 Gerrit-PatchSet: 1 Gerrit-Owner: Balazs Hevele
