[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Steve Carlin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. IMPALA-14789 (part 2): Modify some tests for Calcite planner More tests that have been modified. Most of these tests have a Jira attached to them so some of these changes are temporary until the Jira is addressed. Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Reviewed-on: http://gerrit.cloudera.org:8080/24077 Tested-by: Impala Public Jenkins Reviewed-by: Steve Carlin --- M testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test M testdata/workloads/functional-query/queries/QueryTest/geospatial-esri-planner.test M testdata/workloads/functional-query/queries/QueryTest/orc-stats.test M testdata/workloads/functional-query/queries/QueryTest/parquet-dictionary-runtime-filter.test M testdata/workloads/functional-query/queries/QueryTest/parquet-stats.test M testdata/workloads/functional-query/queries/QueryTest/spilling-naaj-no-deny-reservation.test M testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test M testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test M tests/authorization/test_ranger.py M tests/common/skip.py M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_executor_groups.py M tests/custom_cluster/test_kudu.py M tests/custom_cluster/test_query_log.py M tests/query_test/test_join_queries.py M tests/query_test/test_observability.py 16 files changed, 315 insertions(+), 89 deletions(-) Approvals: Impala Public Jenkins: Verified Steve Carlin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Sat, 18 Apr 2026 16:29:50 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Sat, 18 Apr 2026 16:24:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13337/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Sat, 18 Apr 2026 12:09:25 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 6: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13336/ -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Sat, 18 Apr 2026 08:29:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13335/ -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Sat, 18 Apr 2026 07:49:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13336/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 6 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Sat, 18 Apr 2026 04:04:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13335/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Sat, 18 Apr 2026 03:27:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 5: Code-Review+2 This makes sense to me -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Fri, 17 Apr 2026 21:25:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 5: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/22141/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 15 Apr 2026 19:18:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 15 Apr 2026 18:43:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/24077/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test File testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test: http://gerrit.cloudera.org:8080/#/c/24077/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test@334 PS3, Line 334: row_regex: 47:AGGREGATE * 2 * 2 > These should be collapsed into https://gerrit.cloudera.org/c/24075/7/testda Ah, I misunderstood what you said. Fixed http://gerrit.cloudera.org:8080/#/c/24077/4/testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test File testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test: http://gerrit.cloudera.org:8080/#/c/24077/4/testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test@a99 PS4, Line 99: > I think this change should also be reverted. Done -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 15 Apr 2026 18:40:32 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Hello Aman Sinha, Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/24077 to look at the new patch set (#5). Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. IMPALA-14789 (part 2): Modify some tests for Calcite planner More tests that have been modified. Most of these tests have a Jira attached to them so some of these changes are temporary until the Jira is addressed. Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c --- M testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test M testdata/workloads/functional-query/queries/QueryTest/geospatial-esri-planner.test M testdata/workloads/functional-query/queries/QueryTest/orc-stats.test M testdata/workloads/functional-query/queries/QueryTest/parquet-dictionary-runtime-filter.test M testdata/workloads/functional-query/queries/QueryTest/parquet-stats.test M testdata/workloads/functional-query/queries/QueryTest/spilling-naaj-no-deny-reservation.test M testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test M testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test M tests/authorization/test_ranger.py M tests/common/skip.py M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_executor_groups.py M tests/custom_cluster/test_kudu.py M tests/custom_cluster/test_query_log.py M tests/query_test/test_join_queries.py M tests/query_test/test_observability.py 16 files changed, 315 insertions(+), 89 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/24077/5 -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/24077/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test File testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test: http://gerrit.cloudera.org:8080/#/c/24077/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test@334 PS3, Line 334: row_regex: 47:AGGREGATE * 2 * 2 > These lines are part of the explain plan. The explain plan changed due to These should be collapsed into https://gerrit.cloudera.org/c/24075/7/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test instead. There are no code changes in the part 2 patch that would generate these changes. http://gerrit.cloudera.org:8080/#/c/24077/4/testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test File testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test: http://gerrit.cloudera.org:8080/#/c/24077/4/testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test@a99 PS4, Line 99: I think this change should also be reverted. -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 15 Apr 2026 15:53:58 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 4: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/22137/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 15 Apr 2026 13:32:47 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24077/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test File testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test: http://gerrit.cloudera.org:8080/#/c/24077/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test@334 PS3, Line 334: row_regex: 47:AGGREGATE * 2 * 2 > This was added in the parent patch, why's it changed in this one? These lines are part of the explain plan. The explain plan changed due to one of the recent commits http://gerrit.cloudera.org:8080/#/c/24077/3/testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test File testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test: http://gerrit.cloudera.org:8080/#/c/24077/3/testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test@94 PS3, Line 94: RESULTS: VERIFY_IS_SUBSET > Why change this when there's also a CALCITE_PLANNER_RESULTS section? Prolly changed this while testing and realized I needed a different subsection after. Reverted it. -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Reviewer: Steve Carlin Gerrit-Comment-Date: Wed, 15 Apr 2026 13:09:48 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Hello Aman Sinha, Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/24077 to look at the new patch set (#4). Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. IMPALA-14789 (part 2): Modify some tests for Calcite planner More tests that have been modified. Most of these tests have a Jira attached to them so some of these changes are temporary until the Jira is addressed. Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c --- M testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test M testdata/workloads/functional-query/queries/QueryTest/geospatial-esri-planner.test M testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test M testdata/workloads/functional-query/queries/QueryTest/orc-stats.test M testdata/workloads/functional-query/queries/QueryTest/parquet-dictionary-runtime-filter.test M testdata/workloads/functional-query/queries/QueryTest/parquet-stats.test M testdata/workloads/functional-query/queries/QueryTest/spilling-naaj-no-deny-reservation.test M testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test M testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test M tests/authorization/test_ranger.py M tests/common/skip.py M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_executor_groups.py M tests/custom_cluster/test_kudu.py M tests/custom_cluster/test_query_log.py M tests/query_test/test_join_queries.py M tests/query_test/test_observability.py 17 files changed, 332 insertions(+), 107 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/24077/4 -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24077/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test File testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test: http://gerrit.cloudera.org:8080/#/c/24077/3/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test@334 PS3, Line 334: row_regex: 47:AGGREGATE * 2 * 2 This was added in the parent patch, why's it changed in this one? http://gerrit.cloudera.org:8080/#/c/24077/3/testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test File testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test: http://gerrit.cloudera.org:8080/#/c/24077/3/testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test@94 PS3, Line 94: RESULTS: VERIFY_IS_SUBSET Why change this when there's also a CALCITE_PLANNER_RESULTS section? -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 14 Apr 2026 21:06:35 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 3: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/22114/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Mon, 13 Apr 2026 03:11:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Hello Aman Sinha, Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/24077 to look at the new patch set (#3). Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. IMPALA-14789 (part 2): Modify some tests for Calcite planner More tests that have been modified. Most of these tests have a Jira attached to them so some of these changes are temporary until the Jira is addressed. Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c --- M testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test M testdata/workloads/functional-query/queries/QueryTest/geospatial-esri-planner.test M testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test M testdata/workloads/functional-query/queries/QueryTest/orc-stats.test M testdata/workloads/functional-query/queries/QueryTest/parquet-dictionary-runtime-filter.test M testdata/workloads/functional-query/queries/QueryTest/parquet-stats.test M testdata/workloads/functional-query/queries/QueryTest/spilling-naaj-no-deny-reservation.test M testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test M testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test M tests/authorization/test_ranger.py M tests/common/skip.py M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_executor_groups.py M tests/custom_cluster/test_kudu.py M tests/custom_cluster/test_query_log.py M tests/query_test/test_join_queries.py M tests/query_test/test_observability.py 17 files changed, 333 insertions(+), 108 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/24077/3 -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 2: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/22058/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Tue, 31 Mar 2026 21:57:04 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Hello Aman Sinha, Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/24077 to look at the new patch set (#2). Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. IMPALA-14789 (part 2): Modify some tests for Calcite planner More tests that have been modified. Most of these tests have a Jira attached to them so some of these changes are temporary until the Jira is addressed. Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c --- M testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test M testdata/workloads/functional-query/queries/QueryTest/geospatial-esri-planner.test M testdata/workloads/functional-query/queries/QueryTest/orc-stats.test M testdata/workloads/functional-query/queries/QueryTest/parquet-dictionary-runtime-filter.test M testdata/workloads/functional-query/queries/QueryTest/parquet-stats.test M testdata/workloads/functional-query/queries/QueryTest/spilling-naaj-no-deny-reservation.test M testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test M testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test M tests/authorization/test_ranger.py M tests/common/skip.py M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_executor_groups.py M tests/custom_cluster/test_kudu.py M tests/custom_cluster/test_query_log.py M tests/query_test/test_join_queries.py M tests/query_test/test_observability.py 16 files changed, 316 insertions(+), 91 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/24077/2 -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24077 ) Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. Patch Set 1: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/21889/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith Gerrit-Comment-Date: Sun, 08 Mar 2026 18:49:22 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14789 (part 2): Modify some tests for Calcite planner
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24077 Change subject: IMPALA-14789 (part 2): Modify some tests for Calcite planner .. IMPALA-14789 (part 2): Modify some tests for Calcite planner More tests that have been modified. Most of these tests have a Jira attached to them so some of these changes are temporary until the Jira is addressed. Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c --- M testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test M testdata/workloads/functional-query/queries/QueryTest/geospatial-esri-planner.test M testdata/workloads/functional-query/queries/QueryTest/orc-stats.test M testdata/workloads/functional-query/queries/QueryTest/parquet-dictionary-runtime-filter.test M testdata/workloads/functional-query/queries/QueryTest/parquet-stats.test M testdata/workloads/functional-query/queries/QueryTest/spilling-naaj-no-deny-reservation.test M testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test M testdata/workloads/functional-query/queries/QueryTest/stats-extrapolation.test M tests/authorization/test_ranger.py M tests/custom_cluster/test_admission_controller.py M tests/custom_cluster/test_executor_groups.py M tests/custom_cluster/test_kudu.py M tests/custom_cluster/test_query_log.py M tests/query_test/test_join_queries.py M tests/query_test/test_observability.py 15 files changed, 307 insertions(+), 89 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/24077/1 -- To view, visit http://gerrit.cloudera.org:8080/24077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ide41663f54fcd505098a0f7ba98f55f2692cf74c Gerrit-Change-Number: 24077 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin Gerrit-Reviewer: Aman Sinha Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Michael Smith
