[Impala-ASF-CR] IMPALA-2138: part 1: initial cleanup
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14265 ) Change subject: IMPALA-2138: part 1: initial cleanup .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75d2c8cab79988300c1a9c6c23d6ccea53da7d23 Gerrit-Change-Number: 14265 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 20 Sep 2019 22:15:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2138: part 1: initial cleanup
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14265 ) Change subject: IMPALA-2138: part 1: initial cleanup .. IMPALA-2138: part 1: initial cleanup This is a mixed bag of simplifications, debugging improvements and test fixes that came up in the projection work. I had to update some planner tests because some expressions now include their arguments. Various things in the planner tests were stale, so there are spurious changes in the expected output that are ignored by the plan verification. Change-Id: I75d2c8cab79988300c1a9c6c23d6ccea53da7d23 Reviewed-on: http://gerrit.cloudera.org:8080/14265 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/exprs/slot-ref.cc M fe/src/main/java/org/apache/impala/analysis/CaseExpr.java M fe/src/main/java/org/apache/impala/analysis/SortInfo.java M fe/src/main/java/org/apache/impala/analysis/TupleIsNullPredicate.java M fe/src/main/java/org/apache/impala/analysis/ValidTupleIdExpr.java M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java M fe/src/main/java/org/apache/impala/common/Id.java M fe/src/main/java/org/apache/impala/planner/DataPartition.java M fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java M fe/src/main/java/org/apache/impala/planner/ExchangeNode.java M testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test M testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test M testdata/workloads/functional-planner/queries/PlannerTest/joins.test M testdata/workloads/functional-planner/queries/PlannerTest/multiple-distinct-limit.test M testdata/workloads/functional-planner/queries/PlannerTest/multiple-distinct-materialization.test M testdata/workloads/functional-planner/queries/PlannerTest/multiple-distinct-predicates.test M testdata/workloads/functional-planner/queries/PlannerTest/multiple-distinct.test M testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test M testdata/workloads/functional-query/queries/QueryTest/nested-types-runtime.test 19 files changed, 680 insertions(+), 687 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I75d2c8cab79988300c1a9c6c23d6ccea53da7d23 Gerrit-Change-Number: 14265 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-2138: part 1: initial cleanup
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14265 ) Change subject: IMPALA-2138: part 1: initial cleanup .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4982/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75d2c8cab79988300c1a9c6c23d6ccea53da7d23 Gerrit-Change-Number: 14265 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 20 Sep 2019 17:15:20 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2138: part 1: initial cleanup
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14265 ) Change subject: IMPALA-2138: part 1: initial cleanup .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75d2c8cab79988300c1a9c6c23d6ccea53da7d23 Gerrit-Change-Number: 14265 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 20 Sep 2019 17:15:19 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2138: part 1: initial cleanup
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14265 ) Change subject: IMPALA-2138: part 1: initial cleanup .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75d2c8cab79988300c1a9c6c23d6ccea53da7d23 Gerrit-Change-Number: 14265 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 20 Sep 2019 16:51:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2138: part 1: initial cleanup
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14265 ) Change subject: IMPALA-2138: part 1: initial cleanup .. Patch Set 6: The failure was IMPALA-8957 -- To view, visit http://gerrit.cloudera.org:8080/14265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75d2c8cab79988300c1a9c6c23d6ccea53da7d23 Gerrit-Change-Number: 14265 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Fri, 20 Sep 2019 03:50:07 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2138: part 1: initial cleanup
Tim Armstrong has removed a vote on this change. Change subject: IMPALA-2138: part 1: initial cleanup .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/14265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I75d2c8cab79988300c1a9c6c23d6ccea53da7d23 Gerrit-Change-Number: 14265 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-2138: part 1: initial cleanup
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14265 ) Change subject: IMPALA-2138: part 1: initial cleanup .. Patch Set 6: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4970/ -- To view, visit http://gerrit.cloudera.org:8080/14265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75d2c8cab79988300c1a9c6c23d6ccea53da7d23 Gerrit-Change-Number: 14265 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 20 Sep 2019 01:23:09 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2138: part 1: initial cleanup
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14265 ) Change subject: IMPALA-2138: part 1: initial cleanup .. Patch Set 6: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4600/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75d2c8cab79988300c1a9c6c23d6ccea53da7d23 Gerrit-Change-Number: 14265 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 20 Sep 2019 00:15:45 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-2138: part 1: initial cleanup
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14265 Change subject: IMPALA-2138: part 1: initial cleanup .. IMPALA-2138: part 1: initial cleanup This is a mixed bag of simplifications, debugging improvements and test fixes that came up in the projection work. I had to update some planner tests because some expressions now include their arguments. Various things in the planner tests were stale, so there are spurious changes in the expected output that are ignored by the plan verification. Change-Id: I75d2c8cab79988300c1a9c6c23d6ccea53da7d23 --- M be/src/exprs/slot-ref.cc M fe/src/main/java/org/apache/impala/analysis/CaseExpr.java M fe/src/main/java/org/apache/impala/analysis/SortInfo.java M fe/src/main/java/org/apache/impala/analysis/TupleIsNullPredicate.java M fe/src/main/java/org/apache/impala/analysis/ValidTupleIdExpr.java M fe/src/main/java/org/apache/impala/catalog/ColumnStats.java M fe/src/main/java/org/apache/impala/common/Id.java M fe/src/main/java/org/apache/impala/planner/DataPartition.java M fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java M fe/src/main/java/org/apache/impala/planner/ExchangeNode.java M testdata/workloads/functional-planner/queries/PlannerTest/analytic-fns.test M testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test M testdata/workloads/functional-planner/queries/PlannerTest/joins.test M testdata/workloads/functional-planner/queries/PlannerTest/multiple-distinct-limit.test M testdata/workloads/functional-planner/queries/PlannerTest/multiple-distinct-materialization.test M testdata/workloads/functional-planner/queries/PlannerTest/multiple-distinct-predicates.test M testdata/workloads/functional-planner/queries/PlannerTest/multiple-distinct.test M testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test M testdata/workloads/functional-query/queries/QueryTest/nested-types-runtime.test 19 files changed, 680 insertions(+), 687 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/14265/6 -- To view, visit http://gerrit.cloudera.org:8080/14265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I75d2c8cab79988300c1a9c6c23d6ccea53da7d23 Gerrit-Change-Number: 14265 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins
