[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-16 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 12: docs:

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-10 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 12: I appreciate all your reviews! @John,

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 11: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 11: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 10: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-06 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 9: Tho examples for INSERT/UPSERT are

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 9: Code-Review+2 Can you also an

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-04 Thread Kim Jin Chul (Code Review)
Hello John Russell, Dimitris Tsirogiannis, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8676 to look at the new patch set (#9). Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-04 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2018-01-02 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-16 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 7: (2 comments) Thanks for the finding

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-16 Thread Kim Jin Chul (Code Review)
Hello John Russell, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8676 to look at the new patch set (#8). Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 7: (2 comments) Patch looks good, just two

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 7: Code-Review+1 lgtm, thanks for the

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 6: (3 comments) several more follow-up

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Kim Jin Chul (Code Review)
Hello John Russell, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8676 to look at the new patch set (#6). Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Kim Jin Chul (Code Review)
Hello John Russell, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8676 to look at the new patch set (#5). Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 4: (20 comments) thanks for the changes!

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Kim Jin Chul (Code Review)
Hello John Russell, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8676 to look at the new patch set (#4). Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8676 ) Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT .. Patch Set 2: (4 comments) Thanks a lot for your

[Impala-ASF-CR] IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT

2017-12-13 Thread Kim Jin Chul (Code Review)
Hello John Russell, Alex Behm, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8676 to look at the new patch set (#3). Change subject: IMPALA-4168: Adds Oracle-style hint placement for INSERT/UPSERT