[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. IMPALA-5842: Write page index in Parquet files This c

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 20: Verified+1 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 20: Build started: https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 20: Code-Review+2 Fixed clang-tidy issue, adjusted stat

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#20). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 19: Verified-1 Build failed: https://jenkins.impala

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 19: Build started: https://jenkins.impala.io/job/ge

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 19: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/96

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#19). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 18: Code-Review+2 (2 comments) LGTM, had one remaining nit.

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 18: (4 comments) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#18). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 17: (5 comments) Only a few minor comments, otherwise looks

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 17: (19 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#17). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 16: Code-Review+1 (1 comment) LGTM aside from one bug htt

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 16: (20 comments) http://gerrit.cloudera.org:8080/#/c/9693/1

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 15: (29 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#16). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 15: (25 comments) Still need to do a pass over the tests. h

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 15: (5 comments) Thanks for your patience. I'm read to +2

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 13: (15 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#15). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#14). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 13: (15 comments) I spent a bit of time trying to break th

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 13: (5 comments) Thanks, Csaba! Yes, we have tests for

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#13). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 12: (5 comments) Do we have tests for the edge cases? Fo

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 10: (9 comments) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#12). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/9693/1

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/9693/10/

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/96

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 10: (9 comments) Overall this is looking good. I had some

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/96

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#9). Change subject: IMPALA-5842: Write page index in Parquet files .

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/9693

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/969

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#8). Change subject: IMPALA-5842: Write page index in Parquet files .

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/9693

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 6: (10 comments) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Anonymous Coward #248, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#7). Change subject: IMPALA-5842: Write page index in Parquet files .

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/9693/2/b

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/9693

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Anonymous Coward #248 has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 6: (2 comments) I have 2 minor findings only. Othe

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 5: (1 comment) Thanks, I fixed a few other comments as

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#6). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9693/

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 5: (16 comments) Thanks Csaba! (and I also updated my

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Tim Armstrong, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#5). Change subject: IMPALA-5842: Write page index in Parquet files

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 4: (17 comments) I have added a lot of nits, feel free t

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#4). Change subject: IMPALA-5842: Write page index in Parquet files .. I

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 2: (20 comments) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9693/2/be

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 3: (19 comments) http://gerrit.cloudera.org:8080/#/c/9693/2/

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/9693/2

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 2: (12 comments) Thanks for the comments! I fixed what

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#3). Change subject: IMPALA-5842: Write page index in Parquet files .. I

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 2: (12 comments) I, too, left some high level comments. htt

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9693 ) Change subject: IMPALA-5842: Write page index in Parquet files .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/9693/2

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9693 to look at the new patch set (#2). Change subject: IMPALA-5842: Write page index in Parquet files .. I

[Impala-ASF-CR] IMPALA-5842: Write page index in Parquet files

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9693 Change subject: IMPALA-5842: Write page index in Parquet files .. IMPALA-5842: Write page index in Parquet files This commit builds