[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 7 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Fri, 20 Apr 2018 21:40:12 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. IMPALA-5893: Remove old kinit code for Impala 3 We've gone through a couple of releases with Kudu's kinit as the default way to use kerberos and we've not come across any major issues. Since we're going to have a major release soon, it's time to get rid of the old Kinit code that's largely unused for a while now. Testing: Made sure that our current kerberos tests continue to work without the old code. Cherry-picks: not for 2.x Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Reviewed-on: http://gerrit.cloudera.org:8080/9941 Reviewed-by: Sailesh Mukil Tested-by: Impala Public Jenkins --- M be/src/common/global-flags.cc M be/src/rpc/auth-provider.h M be/src/rpc/authentication.cc M be/src/rpc/rpc-mgr-kerberized-test.cc M be/src/rpc/thrift-server-test.cc M be/src/testutil/mini-kdc-wrapper.h 6 files changed, 11 insertions(+), 110 deletions(-) Approvals: Sailesh Mukil: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 8 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2346/ -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 7 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Fri, 20 Apr 2018 17:50:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 7: Code-Review+2 Another flaky test. Carry +2. -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 7 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Fri, 20 Apr 2018 17:50:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 6: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2343/ -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 6 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Fri, 20 Apr 2018 06:23:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2343/ -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 6 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Fri, 20 Apr 2018 02:32:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 6: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2341/ -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 6 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Fri, 20 Apr 2018 02:03:11 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2341/ -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 6 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Thu, 19 Apr 2018 22:07:28 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 6: Code-Review+2 Hit flaky test. Rebase, carry +2. -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 6 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Thu, 19 Apr 2018 22:07:14 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2334/ -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 5 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Thu, 19 Apr 2018 21:49:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2334/ -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 5 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Thu, 19 Apr 2018 17:50:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 5: Code-Review+2 (1 comment) GVO failed due to PyPi issue. Rebase, Carry +2. http://gerrit.cloudera.org:8080/#/c/9941/4/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/9941/4/be/src/rpc/authentication.cc@a80 PS4, Line 80: > Maybe this needs to be moved to the "graveyard" rather than removed altoget Yes, I added a reference in the graveyard now. -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 5 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Thu, 19 Apr 2018 17:50:19 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Hello Michael Ho, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9941 to look at the new patch set (#5). Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. IMPALA-5893: Remove old kinit code for Impala 3 We've gone through a couple of releases with Kudu's kinit as the default way to use kerberos and we've not come across any major issues. Since we're going to have a major release soon, it's time to get rid of the old Kinit code that's largely unused for a while now. Testing: Made sure that our current kerberos tests continue to work without the old code. Cherry-picks: not for 2.x Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b --- M be/src/common/global-flags.cc M be/src/rpc/auth-provider.h M be/src/rpc/authentication.cc M be/src/rpc/rpc-mgr-kerberized-test.cc M be/src/rpc/thrift-server-test.cc M be/src/testutil/mini-kdc-wrapper.h 6 files changed, 11 insertions(+), 110 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/9941/5 -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 5 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/9941/4/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/9941/4/be/src/rpc/authentication.cc@a80 PS4, Line 80: Maybe this needs to be moved to the "graveyard" rather than removed altogether, to avoid upgrade issues? -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 4 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Tue, 17 Apr 2018 19:48:27 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2314/ -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 4 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Tue, 17 Apr 2018 02:47:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 4: Code-Review+2 (1 comment) Rebase, carry +2. http://gerrit.cloudera.org:8080/#/c/9941/3/be/src/rpc/rpc-mgr-kerberized-test.cc File be/src/rpc/rpc-mgr-kerberized-test.cc: http://gerrit.cloudera.org:8080/#/c/9941/3/be/src/rpc/rpc-mgr-kerberized-test.cc@56 PS3, Line 56: ::testing::Values(KERBEROS_ON)); > Do we still need this switch ? Can we simplify RpcMgrTestBase to be not tem Yes, it is possible. But that's a slightly larger change, so I'll do it as part of a separate JIRA. Filed IMPALA-6859 -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 4 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Mon, 16 Apr 2018 20:03:24 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2314/ -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 4 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Mon, 16 Apr 2018 20:03:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/9941/3/be/src/rpc/rpc-mgr-kerberized-test.cc File be/src/rpc/rpc-mgr-kerberized-test.cc: http://gerrit.cloudera.org:8080/#/c/9941/3/be/src/rpc/rpc-mgr-kerberized-test.cc@56 PS3, Line 56: ::testing::Values(KERBEROS_ON)); Do we still need this switch ? Can we simplify RpcMgrTestBase to be not templatized ? -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Mon, 16 Apr 2018 18:52:08 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9941 to look at the new patch set (#3). Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. IMPALA-5893: Remove old kinit code for Impala 3 We've gone through a couple of releases with Kudu's kinit as the default way to use kerberos and we've not come across any major issues. Since we're going to have a major release soon, it's time to get rid of the old Kinit code that's largely unused for a while now. Testing: Made sure that our current kerberos tests continue to work without the old code. Cherry-picks: not for 2.x Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b --- M be/src/rpc/auth-provider.h M be/src/rpc/authentication.cc M be/src/rpc/rpc-mgr-kerberized-test.cc M be/src/rpc/thrift-server-test.cc M be/src/testutil/mini-kdc-wrapper.h 5 files changed, 9 insertions(+), 110 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/9941/3 -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Sailesh Mukil has posted comments on this change. (
http://gerrit.cloudera.org:8080/9941 )
Change subject: IMPALA-5893: Remove old kinit code for Impala 3
..
Patch Set 3:
(1 comment)
Thanks for the review! I'll ask Michael to look at it too.
http://gerrit.cloudera.org:8080/#/c/9941/2/be/src/rpc/authentication.cc
File be/src/rpc/authentication.cc:
http://gerrit.cloudera.org:8080/#/c/9941/2/be/src/rpc/authentication.cc@104
PS2, Line 104: namespace impala {
:
: // Sasl callbacks. Why are these here? Well, Sasl isn't that
bright, and
: // instead of copying the callbacks, it just saves a pointer to
them. If
: // they're on the stack, this means that they *go away* when the
function
: // exits... so make these
> can't we remove that too?
Done
--
To view, visit http://gerrit.cloudera.org:8080/9941
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b
Gerrit-Change-Number: 9941
Gerrit-PatchSet: 3
Gerrit-Owner: Sailesh Mukil
Gerrit-Reviewer: Dan Hecht
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Sailesh Mukil
Gerrit-Comment-Date: Fri, 06 Apr 2018 22:41:41 +
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. Patch Set 2: Code-Review+1 (1 comment) Good riddance. Please have Michael take a look too. http://gerrit.cloudera.org:8080/#/c/9941/2/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/9941/2/be/src/rpc/authentication.cc@104 PS2, Line 104: // TODO: Remove this flag and the old kerberos code once we remove 'use_krpc' flag. : // (IMPALA-5893) : DEFINE_bool(use_kudu_kinit, true, "If true, Impala will programatically perform kinit " : "by calling into the libkrb5 library using the provided APIs. If false, it will fork " : "off a kinit process. If use_krpc=true, this flag is treated as true regardless of " : "what it's set to."); can't we remove that too? -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil Gerrit-Reviewer: Dan Hecht Gerrit-Comment-Date: Fri, 06 Apr 2018 16:17:23 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Sailesh Mukil has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9941 ) Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. IMPALA-5893: Remove old kinit code for Impala 3 We've gone through a couple of releases with Kudu's kinit as the default way to use kerberos and we've not come across any major issues. Since we're going to have a major release soon, it's time to get rid of the old Kinit code that's largely unused for a while now. Testing: Made sure that our current kerberos tests continue to work without the old code. Cherry-picks: not for 2.x Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b --- M be/src/rpc/auth-provider.h M be/src/rpc/authentication.cc M be/src/rpc/rpc-mgr-kerberized-test.cc M be/src/rpc/thrift-server-test.cc M be/src/testutil/mini-kdc-wrapper.h 5 files changed, 9 insertions(+), 102 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/9941/2 -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 2 Gerrit-Owner: Sailesh Mukil
[Impala-ASF-CR] IMPALA-5893: Remove old kinit code for Impala 3
Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9941 Change subject: IMPALA-5893: Remove old kinit code for Impala 3 .. IMPALA-5893: Remove old kinit code for Impala 3 We've gone through a couple of releases with Kudu's kinit as the default way to use kerberos and we've not come across any major issues. Since we're going to have a major release soon, it's time to get rid of the old Kinit code that's largely unused for a while now. Testing: Made sure that our current kerberos tests continue to work without the old code. Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b --- M be/src/rpc/auth-provider.h M be/src/rpc/authentication.cc M be/src/rpc/rpc-mgr-kerberized-test.cc M be/src/rpc/thrift-server-test.cc M be/src/testutil/mini-kdc-wrapper.h 5 files changed, 9 insertions(+), 102 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/9941/1 -- To view, visit http://gerrit.cloudera.org:8080/9941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic78de10f3fb9ec36537de7a090916e4be123234b Gerrit-Change-Number: 9941 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil
