[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9555 )

Change subject: IMPALA-6227: more logging in test_admission_controller
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb58a9be4a5d023c1ee3fd76e5992dfba03188c
Gerrit-Change-Number: 9555
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 09 Mar 2018 00:00:17 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9555 )

Change subject: IMPALA-6227: more logging in test_admission_controller
..

IMPALA-6227: more logging in test_admission_controller

To enable debugging the occasional flakiness, lets log what each query
is doing by default.

Change-Id: Icbb58a9be4a5d023c1ee3fd76e5992dfba03188c
Reviewed-on: http://gerrit.cloudera.org:8080/9555
Reviewed-by: Tim Armstrong 
Tested-by: Impala Public Jenkins
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 19 insertions(+), 19 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbb58a9be4a5d023c1ee3fd76e5992dfba03188c
Gerrit-Change-Number: 9555
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9555 )

Change subject: IMPALA-6227: more logging in test_admission_controller
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9555/1/tests/custom_cluster/test_admission_controller.py
File tests/custom_cluster/test_admission_controller.py:

http://gerrit.cloudera.org:8080/#/c/9555/1/tests/custom_cluster/test_admission_controller.py@545
PS1, Line 545:   LOG.debug("DeltaSum=%s Deltas=%s (Expected=%s for 
metrics=%s)",\
> Up to you to decide, just making sure you didn't forget it. If you omitted
Yeah it seems like it's worth including.



--
To view, visit http://gerrit.cloudera.org:8080/9555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb58a9be4a5d023c1ee3fd76e5992dfba03188c
Gerrit-Change-Number: 9555
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 08 Mar 2018 21:53:12 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9555 )

Change subject: IMPALA-6227: more logging in test_admission_controller
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9555/1/tests/custom_cluster/test_admission_controller.py
File tests/custom_cluster/test_admission_controller.py:

http://gerrit.cloudera.org:8080/#/c/9555/1/tests/custom_cluster/test_admission_controller.py@545
PS1, Line 545:   LOG.debug("DeltaSum=%s Deltas=%s (Expected=%s for 
metrics=%s)",\
> I thought that maybe it would be too chatty in this loop, but I guess we're
Up to you to decide, just making sure you didn't forget it. If you omitted on 
purpose, that's totally fine.



--
To view, visit http://gerrit.cloudera.org:8080/9555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb58a9be4a5d023c1ee3fd76e5992dfba03188c
Gerrit-Change-Number: 9555
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 08 Mar 2018 21:47:20 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Tim Armstrong (Code Review) 
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9555 )

Change subject: IMPALA-6227: more logging in test_admission_controller
..


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9555/1/tests/custom_cluster/test_admission_controller.py
File tests/custom_cluster/test_admission_controller.py:

http://gerrit.cloudera.org:8080/#/c/9555/1/tests/custom_cluster/test_admission_controller.py@545
PS1, Line 545:   LOG.info("DeltaSum=%s Deltas=%s (Expected=%s for 
metrics=%s)",\
> what about this one?
I thought that maybe it would be too chatty in this loop, but I guess we're 
already logging in this loop.



--
To view, visit http://gerrit.cloudera.org:8080/9555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb58a9be4a5d023c1ee3fd76e5992dfba03188c
Gerrit-Change-Number: 9555
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 08 Mar 2018 20:17:35 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Tim Armstrong (Code Review) 
Hello Lars Volker, Alex Behm,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9555

to look at the new patch set (#2).

Change subject: IMPALA-6227: more logging in test_admission_controller
..

IMPALA-6227: more logging in test_admission_controller

To enable debugging the occasional flakiness, lets log what each query
is doing by default.

Change-Id: Icbb58a9be4a5d023c1ee3fd76e5992dfba03188c
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 19 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/9555/2
--
To view, visit http://gerrit.cloudera.org:8080/9555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icbb58a9be4a5d023c1ee3fd76e5992dfba03188c
Gerrit-Change-Number: 9555
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Lars Volker

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9555 )

Change subject: IMPALA-6227: more logging in test_admission_controller
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2069/


--
To view, visit http://gerrit.cloudera.org:8080/9555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb58a9be4a5d023c1ee3fd76e5992dfba03188c
Gerrit-Change-Number: 9555
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 08 Mar 2018 20:17:48 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Lars Volker (Code Review) 
Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9555 )

Change subject: IMPALA-6227: more logging in test_admission_controller
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb58a9be4a5d023c1ee3fd76e5992dfba03188c
Gerrit-Change-Number: 9555
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Lars Volker 
Gerrit-Comment-Date: Thu, 08 Mar 2018 17:17:25 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Alex Behm (Code Review) 
Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9555 )

Change subject: IMPALA-6227: more logging in test_admission_controller
..


Patch Set 1:

(1 comment)

Seems fine to me, let's hope the extra logging does not disturb the timing and 
"fix" the issue.

http://gerrit.cloudera.org:8080/#/c/9555/1/tests/custom_cluster/test_admission_controller.py
File tests/custom_cluster/test_admission_controller.py:

http://gerrit.cloudera.org:8080/#/c/9555/1/tests/custom_cluster/test_admission_controller.py@545
PS1, Line 545:   LOG.debug("DeltaSum=%s Deltas=%s (Expected=%s for 
metrics=%s)",\
what about this one?



--
To view, visit http://gerrit.cloudera.org:8080/9555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb58a9be4a5d023c1ee3fd76e5992dfba03188c
Gerrit-Change-Number: 9555
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Comment-Date: Thu, 08 Mar 2018 17:17:22 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6227: more logging in test admission controller

2018-03-08 Thread Tim Armstrong (Code Review) 
Tim Armstrong has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9555


Change subject: IMPALA-6227: more logging in test_admission_controller
..

IMPALA-6227: more logging in test_admission_controller

To enable debugging the occasional flakiness, lets log what each query
is doing by default.

Change-Id: Icbb58a9be4a5d023c1ee3fd76e5992dfba03188c
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 18 insertions(+), 18 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/9555/1
--
To view, visit http://gerrit.cloudera.org:8080/9555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icbb58a9be4a5d023c1ee3fd76e5992dfba03188c
Gerrit-Change-Number: 9555
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong