[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8669 )

Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names
..

IMPALA-6255: Add device names to DiskIoMgr thread names

This change adds device names to the DiskIoMgr thread names. It will
make them easier to identify during debugging.

Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
Reviewed-on: http://gerrit.cloudera.org:8080/8669
Reviewed-by: Lars Volker 
Tested-by: Impala Public Jenkins
---
M be/src/runtime/io/disk-io-mgr.cc
M tests/webserver/test_web_pages.py
2 files changed, 25 insertions(+), 1 deletion(-)

Approvals:
  Lars Volker: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/8669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
Gerrit-Change-Number: 8669
Gerrit-PatchSet: 7
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8669 )

Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names
..


Patch Set 6: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/8669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
Gerrit-Change-Number: 8669
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 01 Dec 2017 05:51:58 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8669 )

Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names
..


Patch Set 6: Code-Review+2

Changed thread names for out-of-range disks in tests back to the old behavior.


--
To view, visit http://gerrit.cloudera.org:8080/8669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
Gerrit-Change-Number: 8669
Gerrit-PatchSet: 6
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 01 Dec 2017 02:14:31 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8669 )

Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names
..


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1554/


--
To view, visit http://gerrit.cloudera.org:8080/8669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
Gerrit-Change-Number: 8669
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 01 Dec 2017 02:07:30 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

[Lars Volker (Code Review)]

Hello Tim Armstrong, Alex Behm, Bikramjeet Vig, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8669

to look at the new patch set (#5).

Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names
..

IMPALA-6255: Add device names to DiskIoMgr thread names

This change adds device names to the DiskIoMgr thread names. It will
make them easier to identify during debugging.

Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
---
M be/src/runtime/io/disk-io-mgr.cc
M tests/webserver/test_web_pages.py
2 files changed, 23 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/8669/5
--
To view, visit http://gerrit.cloudera.org:8080/8669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
Gerrit-Change-Number: 8669
Gerrit-PatchSet: 5
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8669 )

Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1551/


--
To view, visit http://gerrit.cloudera.org:8080/8669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
Gerrit-Change-Number: 8669
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 30 Nov 2017 21:57:12 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8669 )

Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1550/


--
To view, visit http://gerrit.cloudera.org:8080/8669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
Gerrit-Change-Number: 8669
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 30 Nov 2017 21:56:28 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

[Lars Volker (Code Review)]

Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8669 )

Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names
..


Patch Set 4: Code-Review+2

(1 comment)

Carrying Tim's +2

http://gerrit.cloudera.org:8080/#/c/8669/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8669/3//COMMIT_MSG@12
PS3, Line 12: Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
> Needs updating?
Thanks for catching this, done.



--
To view, visit http://gerrit.cloudera.org:8080/8669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
Gerrit-Change-Number: 8669
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 30 Nov 2017 21:56:22 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

[Lars Volker (Code Review)]

Hello Tim Armstrong, Alex Behm, Bikramjeet Vig, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8669

to look at the new patch set (#4).

Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names
..

IMPALA-6255: Add device names to DiskIoMgr thread names

This change adds device names to the DiskIoMgr thread names. It will
make them easier to identify during debugging.

Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
---
M be/src/runtime/disk-io-mgr.cc
M tests/webserver/test_web_pages.py
2 files changed, 23 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/8669/4
--
To view, visit http://gerrit.cloudera.org:8080/8669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
Gerrit-Change-Number: 8669
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8669 )

Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names
..


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1546/


--
To view, visit http://gerrit.cloudera.org:8080/8669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
Gerrit-Change-Number: 8669
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 30 Nov 2017 09:20:28 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8669 )

Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names
..


Patch Set 2:

For future reference here's a good place for such tests:
webserver/test_web_pages.py

No need to hold up the patch, change seems easy enough.


--
To view, visit http://gerrit.cloudera.org:8080/8669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
Gerrit-Change-Number: 8669
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 30 Nov 2017 05:59:43 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8669 )

Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1546/


--
To view, visit http://gerrit.cloudera.org:8080/8669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
Gerrit-Change-Number: 8669
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 30 Nov 2017 05:55:39 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

[Tim Armstrong (Code Review)]

Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8669 )

Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
Gerrit-Change-Number: 8669
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 29 Nov 2017 22:33:26 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

[Bikramjeet Vig (Code Review)]

Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8669 )

Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names
..


Patch Set 2: Code-Review+1

lgtm


--
To view, visit http://gerrit.cloudera.org:8080/8669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
Gerrit-Change-Number: 8669
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker 
Gerrit-Reviewer: Bikramjeet Vig 
Gerrit-Comment-Date: Wed, 29 Nov 2017 20:35:16 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

[Lars Volker (Code Review)]

Lars Volker has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8669


Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names
..

IMPALA-6255: Add device names to DiskIoMgr thread names

This change adds device names to the DiskIoMgr thread names. It will
make them easier to identify during debugging.

We don't seem to have any automatic tests for /threadz, so I tested this
manually by looking at the debug webpage on my development system.

Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
---
M be/src/runtime/disk-io-mgr.cc
1 file changed, 7 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/8669/1
--
To view, visit http://gerrit.cloudera.org:8080/8669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30faeda6db8846e4aad64ce29ca811366d84910b
Gerrit-Change-Number: 8669
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker