[Impala-ASF-CR] IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10070 ) Change subject: IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns .. IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a Reviewed-on: http://gerrit.cloudera.org:8080/10070 Reviewed-by: Vuk Ercegovac Tested-by: Impala Public Jenkins --- M docs/topics/impala_compute_stats.xml 1 file changed, 77 insertions(+), 39 deletions(-) Approvals: Vuk Ercegovac: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a Gerrit-Change-Number: 10070 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10070 ) Change subject: IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a Gerrit-Change-Number: 10070 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 16 Apr 2018 20:28:33 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10070 ) Change subject: IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/243/ -- To view, visit http://gerrit.cloudera.org:8080/10070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a Gerrit-Change-Number: 10070 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 16 Apr 2018 20:19:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10070 ) Change subject: IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a Gerrit-Change-Number: 10070 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 16 Apr 2018 19:05:24 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10070 ) Change subject: IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10070/3/docs/topics/impala_compute_stats.xml File docs/topics/impala_compute_stats.xml: http://gerrit.cloudera.org:8080/#/c/10070/3/docs/topics/impala_compute_stats.xml@53 PS3, Line 53: column_list > this is a non-terminal; I see the verbal expansion on L81-83. If you typica The syntax was updated. For examples, we will add examples in the Stats concept doc that explains more in detail. -- To view, visit http://gerrit.cloudera.org:8080/10070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a Gerrit-Change-Number: 10070 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 16 Apr 2018 18:38:29 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns
Hello Alex Behm, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10070 to look at the new patch set (#4). Change subject: IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns .. IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a --- M docs/topics/impala_compute_stats.xml 1 file changed, 77 insertions(+), 39 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/10070/4 -- To view, visit http://gerrit.cloudera.org:8080/10070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a Gerrit-Change-Number: 10070 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10070 ) Change subject: IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10070/3/docs/topics/impala_compute_stats.xml File docs/topics/impala_compute_stats.xml: http://gerrit.cloudera.org:8080/#/c/10070/3/docs/topics/impala_compute_stats.xml@53 PS3, Line 53: column_list this is a non-terminal; I see the verbal expansion on L81-83. If you typically expand this more formally (as done for example on L59), pls do so for this as well for consistency. does it make sense to have an example, since it can be a large resource saver for wide tables, large datatypes? -- To view, visit http://gerrit.cloudera.org:8080/10070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a Gerrit-Change-Number: 10070 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 16 Apr 2018 18:22:40 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10070 ) Change subject: IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10070/1/docs/topics/impala_compute_stats.xml File docs/topics/impala_compute_stats.xml: http://gerrit.cloudera.org:8080/#/c/10070/1/docs/topics/impala_compute_stats.xml@95 PS1, Line 95: an unsupported type > lets state complex types as the example of a type that is not supported for Done -- To view, visit http://gerrit.cloudera.org:8080/10070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a Gerrit-Change-Number: 10070 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 16 Apr 2018 05:32:42 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns
Hello Alex Behm, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10070 to look at the new patch set (#3). Change subject: IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns .. IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a --- M docs/topics/impala_compute_stats.xml 1 file changed, 61 insertions(+), 29 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/10070/3 -- To view, visit http://gerrit.cloudera.org:8080/10070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a Gerrit-Change-Number: 10070 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10070 ) Change subject: IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10070/1/docs/topics/impala_compute_stats.xml File docs/topics/impala_compute_stats.xml: http://gerrit.cloudera.org:8080/#/c/10070/1/docs/topics/impala_compute_stats.xml@95 PS1, Line 95: not be analyzed, su > Either I can remove this or be more specific? Please advise. lets state complex types as the example of a type that is not supported for compute stats. -- To view, visit http://gerrit.cloudera.org:8080/10070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a Gerrit-Change-Number: 10070 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 16 Apr 2018 05:23:49 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns
Hello Alex Behm, Impala Public Jenkins, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10070 to look at the new patch set (#2). Change subject: IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns .. IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a --- M docs/topics/impala_compute_stats.xml 1 file changed, 59 insertions(+), 29 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/10070/2 -- To view, visit http://gerrit.cloudera.org:8080/10070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a Gerrit-Change-Number: 10070 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10070 ) Change subject: IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10070/1/docs/topics/impala_compute_stats.xml File docs/topics/impala_compute_stats.xml: http://gerrit.cloudera.org:8080/#/c/10070/1/docs/topics/impala_compute_stats.xml@82 PS1, Line 82: you can specify an optional comma-separated list of columns for : which stats should be computed > seems too informal. how about: Done http://gerrit.cloudera.org:8080/#/c/10070/1/docs/topics/impala_compute_stats.xml@95 PS1, Line 95: an unsupported type > this is vague; should the types that are supported or unsupported (for what Either I can remove this or be more specific? Please advise. -- To view, visit http://gerrit.cloudera.org:8080/10070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a Gerrit-Change-Number: 10070 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Alex Rodoni Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 16 Apr 2018 05:18:34 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10070 ) Change subject: IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10070/1/docs/topics/impala_compute_stats.xml File docs/topics/impala_compute_stats.xml: http://gerrit.cloudera.org:8080/#/c/10070/1/docs/topics/impala_compute_stats.xml@82 PS1, Line 82: you can specify an optional comma-separated list of columns for : which stats should be computed seems too informal. how about: "columns for which statistics are computed can be specified with an optional comma-separate list of columns." http://gerrit.cloudera.org:8080/#/c/10070/1/docs/topics/impala_compute_stats.xml@95 PS1, Line 95: an unsupported type this is vague; should the types that are supported or unsupported (for what?) be explicitly listed? -- To view, visit http://gerrit.cloudera.org:8080/10070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a Gerrit-Change-Number: 10070 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Mon, 16 Apr 2018 04:54:44 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10070 Change subject: IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns .. IMPALA-6464: [DOCS] COMPUTE STATS supports a list of columns Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a --- M docs/topics/impala_compute_stats.xml 1 file changed, 58 insertions(+), 29 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/10070/1 -- To view, visit http://gerrit.cloudera.org:8080/10070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I609c38eac29e36eca008bfb66f5e78f5491e719a Gerrit-Change-Number: 10070 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni
