[Impala-ASF-CR] IMPALA-6489: use correct template tuple size

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9288 )

Change subject: IMPALA-6489: use correct template tuple size
..

IMPALA-6489: use correct template tuple size

The bug was that we mixed up the size of the top-level tuple with the
size of the nested tuple. The upshot in this case was that the wrong
amount of data was memcpy()ed over and we read past the bounds of the
original allocation.

Testing:
TestParquetArrayEncodings.test_avro_primitive_in_list reliably
reproduced the problem under ASAN. After the fix it not longer
reproduces.

Change-Id: I8193c04673f15e5057f457cc8a3a91a8fef64be2
Reviewed-on: http://gerrit.cloudera.org:8080/9288
Reviewed-by: Alex Behm 
Reviewed-by: Dan Hecht 
Tested-by: Impala Public Jenkins
---
M be/src/exec/hdfs-scanner.h
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Alex Behm: Looks good to me, but someone else must approve
  Dan Hecht: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8193c04673f15e5057f457cc8a3a91a8fef64be2
Gerrit-Change-Number: 9288
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins

[Impala-ASF-CR] IMPALA-6489: use correct template tuple size

[Impala Public Jenkins (Code Review)]

Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9288 )

Change subject: IMPALA-6489: use correct template tuple size
..


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1922/


--
To view, visit http://gerrit.cloudera.org:8080/9288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8193c04673f15e5057f457cc8a3a91a8fef64be2
Gerrit-Change-Number: 9288
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Comment-Date: Mon, 12 Feb 2018 23:29:38 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6489: use correct template tuple size

[Dan Hecht (Code Review)]

Dan Hecht has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9288 )

Change subject: IMPALA-6489: use correct template tuple size
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8193c04673f15e5057f457cc8a3a91a8fef64be2
Gerrit-Change-Number: 9288
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-Comment-Date: Mon, 12 Feb 2018 23:17:53 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6489: use correct template tuple size

[Alex Behm (Code Review)]

Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9288 )

Change subject: IMPALA-6489: use correct template tuple size
..


Patch Set 1: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/9288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8193c04673f15e5057f457cc8a3a91a8fef64be2
Gerrit-Change-Number: 9288
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alex Behm 
Gerrit-Comment-Date: Mon, 12 Feb 2018 23:02:47 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6489: use correct template tuple size

[Tim Armstrong (Code Review)]

Tim Armstrong has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9288


Change subject: IMPALA-6489: use correct template tuple size
..

IMPALA-6489: use correct template tuple size

The bug was that we mixed up the size of the top-level tuple with the
size of the nested tuple. The upshot in this case was that the wrong
amount of data was memcpy()ed over and we read past the bounds of the
original allocation.

Testing:
TestParquetArrayEncodings.test_avro_primitive_in_list reliably
reproduced the problem under ASAN. After the fix it not longer
reproduces.

Change-Id: I8193c04673f15e5057f457cc8a3a91a8fef64be2
---
M be/src/exec/hdfs-scanner.h
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/9288/1
--
To view, visit http://gerrit.cloudera.org:8080/9288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8193c04673f15e5057f457cc8a3a91a8fef64be2
Gerrit-Change-Number: 9288
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong