[Impala-ASF-CR] IMPALA-6495: fix targeted-perf for new column alias syntax

2018-02-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9268 )

Change subject: IMPALA-6495: fix targeted-perf for new column alias syntax
..

IMPALA-6495: fix targeted-perf for new column alias syntax

I was able to run bin/single_node_perf_run.py after these changes.

Change-Id: Ib25139873b1c67f8039ac6c85e936135e008101b
Reviewed-on: http://gerrit.cloudera.org:8080/9268
Reviewed-by: Philip Zeyliger 
Tested-by: Tim Armstrong 
---
M 
testdata/workloads/targeted-perf/queries/primitive_shuffle_join_one_to_many_string_with_groupby.test
M 
testdata/workloads/targeted-perf/queries/primitive_shuffle_join_union_all_with_groupby.test
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Philip Zeyliger: Looks good to me, approved
  Tim Armstrong: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib25139873b1c67f8039ac6c85e936135e008101b
Gerrit-Change-Number: 9268
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-6495: fix targeted-perf for new column alias syntax

2018-02-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9268 )

Change subject: IMPALA-6495: fix targeted-perf for new column alias syntax
..


Patch Set 1: Verified+1

Precommit tests don't exercise this. Manually verified it.


--
To view, visit http://gerrit.cloudera.org:8080/9268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib25139873b1c67f8039ac6c85e936135e008101b
Gerrit-Change-Number: 9268
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 09 Feb 2018 16:49:52 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6495: fix targeted-perf for new column alias syntax

2018-02-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9268 )

Change subject: IMPALA-6495: fix targeted-perf for new column alias syntax
..


Patch Set 1:

Yeah, I think we could even consider just run the workload on scale factor 1 in 
the precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/9268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib25139873b1c67f8039ac6c85e936135e008101b
Gerrit-Change-Number: 9268
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Fri, 09 Feb 2018 16:48:39 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6495: fix targeted-perf for new column alias syntax

2018-02-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9268 )

Change subject: IMPALA-6495: fix targeted-perf for new column alias syntax
..


Patch Set 1: Code-Review+2

Change looks fine. Should we be running this in some CI job so that these 
things are spotted more quickly?


--
To view, visit http://gerrit.cloudera.org:8080/9268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib25139873b1c67f8039ac6c85e936135e008101b
Gerrit-Change-Number: 9268
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Comment-Date: Fri, 09 Feb 2018 16:45:27 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6495: fix targeted-perf for new column alias syntax

2018-02-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9268


Change subject: IMPALA-6495: fix targeted-perf for new column alias syntax
..

IMPALA-6495: fix targeted-perf for new column alias syntax

I was able to run bin/single_node_perf_run.py after these changes.

Change-Id: Ib25139873b1c67f8039ac6c85e936135e008101b
---
M 
testdata/workloads/targeted-perf/queries/primitive_shuffle_join_one_to_many_string_with_groupby.test
M 
testdata/workloads/targeted-perf/queries/primitive_shuffle_join_union_all_with_groupby.test
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/9268/1
--
To view, visit http://gerrit.cloudera.org:8080/9268
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib25139873b1c67f8039ac6c85e936135e008101b
Gerrit-Change-Number: 9268
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong