[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. test_query_profile_thrift_timestamps uses ImapaTestSuite.client.close() to force cancellation/unregistration of the query, so that 'EndTime' of the query shows up in the profile. Since other test cases also need a valid ImpalaTestSuite.client, we move the test case in question to its own test suite. Have also reduced the query to 'select sleep(5)', as the earlier 'select sleep(1)' is just really excessively long. Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Reviewed-on: http://gerrit.cloudera.org:8080/9590 Reviewed-by: Thomas Tauber-Marshall Reviewed-by: Michael Ho Tested-by: Impala Public Jenkins --- M tests/query_test/test_observability.py 1 file changed, 56 insertions(+), 49 deletions(-) Approvals: Thomas Tauber-Marshall: Looks good to me, but someone else must approve Michael Ho: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 5 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Zoram Thanga
[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Thu, 15 Mar 2018 02:13:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2100/ -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Wed, 14 Mar 2018 22:30:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 4: > GVO does not seem to have kicked in for this? A committer needs to manually run it. I'll do it -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Wed, 14 Mar 2018 22:30:08 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 4: GVO does not seem to have kicked in for this? -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Wed, 14 Mar 2018 22:28:53 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Wed, 14 Mar 2018 19:33:27 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Tue, 13 Mar 2018 22:04:48 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 3: (1 comment) Thanks for the review. Please have a look at PS #4. http://gerrit.cloudera.org:8080/#/c/9590/3/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/9590/3/tests/query_test/test_observability.py@198 PS3, Line 198: Moving this test to its own suite (IMPALA-6498). This test case forces Unregistration : # of the query, so that we force computation of query end time, which shows up as : # a non-empty 'End Time' in the profile. We use self.client.close() since the : # Beeswax client does not have a cencellation interface. self.client cannot be used : # after close(), so if new test cases are added to this suite, the test cases must be : # executed before this one. > Always better to keep comments brief, if possible. I think all of this can Done -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 3 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Tue, 13 Mar 2018 21:59:16 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.
Hello Michael Ho, Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9590 to look at the new patch set (#4). Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. test_query_profile_thrift_timestamps uses ImapaTestSuite.client.close() to force cancellation/unregistration of the query, so that 'EndTime' of the query shows up in the profile. Since other test cases also need a valid ImpalaTestSuite.client, we move the test case in question to its own test suite. Have also reduced the query to 'select sleep(5)', as the earlier 'select sleep(1)' is just really excessively long. Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 --- M tests/query_test/test_observability.py 1 file changed, 56 insertions(+), 49 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/9590/4 -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Zoram Thanga
[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9590/3/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/9590/3/tests/query_test/test_observability.py@198 PS3, Line 198: Moving this test to its own suite (IMPALA-6498). This test case forces Unregistration : # of the query, so that we force computation of query end time, which shows up as : # a non-empty 'End Time' in the profile. We use self.client.close() since the : # Beeswax client does not have a cencellation interface. self.client cannot be used : # after close(), so if new test cases are added to this suite, the test cases must be : # executed before this one. Always better to keep comments brief, if possible. I think all of this can be simplified to something like: "This test needs to call self.client.close() to force computation of query end time, so it has to be in its own suite (IMPALA-6498)." -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 3 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Mon, 12 Mar 2018 22:22:44 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 3: (1 comment) Please have a look at ps #3 http://gerrit.cloudera.org:8080/#/c/9590/2/tests/query_test/test_thrift_profile.py File tests/query_test/test_thrift_profile.py: http://gerrit.cloudera.org:8080/#/c/9590/2/tests/query_test/test_thrift_profile.py@24 PS2, Line 24: > It should be sufficient just to put it into its own class still within the Done -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 3 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Mon, 12 Mar 2018 22:17:53 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 3: > (1 comment) Thanks for the suggestion. I've moved it back to the old file, but a separate class. -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 3 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Reviewer: Zoram Thanga Gerrit-Comment-Date: Mon, 12 Mar 2018 22:17:18 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.
Hello Michael Ho, Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9590 to look at the new patch set (#3). Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. test_query_profile_thrift_timestamps uses ImapaTestSuite.client.close() to force cancellation/unregistration of the query, so that 'EndTime' of the query shows up in the profile. Since other test cases also need a valid ImpalaTestSuite.client, we move the test case in question to its own test suite. Have also reduced the query to 'select sleep(5)', as the earlier 'select sleep(1)' is just really excessively long. Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 --- M tests/query_test/test_observability.py 1 file changed, 60 insertions(+), 49 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/9590/3 -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 3 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/9590/2/tests/query_test/test_thrift_profile.py File tests/query_test/test_thrift_profile.py: http://gerrit.cloudera.org:8080/#/c/9590/2/tests/query_test/test_thrift_profile.py@24 PS2, Line 24: class TestThriftProfile(ImpalaTestSuite): It should be sufficient just to put it into its own class still within the original file. -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 2 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Mon, 12 Mar 2018 22:00:35 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.
Hello Michael Ho, Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9590 to look at the new patch set (#2). Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. test_query_profile_thrift_timestamps uses ImapaTestSuite.client.close() to force cancellation/unregistration of the query, so that 'EndTime' of the query shows up in the profile. Since other test cases also need a valid ImpalaTestSuite.client, we move the test case in question to its own test suite. Have also reduced the query to 'select sleep(5)', as the earlier 'select sleep(1)' is just really excessively long. Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 --- M tests/query_test/test_observability.py A tests/query_test/test_thrift_profile.py 2 files changed, 82 insertions(+), 49 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/9590/2 -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 2 Gerrit-Owner: Zoram Thanga Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.
Zoram Thanga has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9590 Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. test_query_profile_thrift_timestamps uses ImapaTestSuite.client.close() to force cancellation/unregistration of the query, so that 'EndTime' of the query shows up in the profile. Since other test cases also need a valid ImpalaTestSuite.client, we move the test case in question to its own test suite. Have also reduced the query to 'select sleep(5)', as the earlier 'select sleep(1)' is just really excessively long. Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 --- A tests/query_test/test_thrift_profile.py 1 file changed, 82 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/9590/1 -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 1 Gerrit-Owner: Zoram Thanga
