[Impala-ASF-CR] IMPALA-6517: bootstrap toolchain.py fails to recognize lsb release output from RHEL OS

2018-02-21 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9310 )

Change subject: IMPALA-6517: bootstrap_toolchain.py fails to recognize 
lsb_release output from RHEL OS
..

IMPALA-6517: bootstrap_toolchain.py fails to recognize lsb_release
output from RHEL OS

The OS map that we currently use to check platform/OS release
against in bootstrap_toolchain.py does not contain key-value pairs
for Redhat platforms.
e.g.
lsb_release -irs
RedHatEnterpriseServer 6.9

This change adds RHEL5, RHEL6 and RHEL7 to the OS map. It also
relaxes the matching criteria for RHEL and CentOS to only major
version.

Testing: I manually cloned a repo locally and called
bootstrap_toolchain.py to verify that it can detect the platform.
Testing was done against RHEL6, RHEL7, Ubuntu16.04 and Centos7.

Change-Id: I83874220bd424a452df49520b5dad7bfa2124ca6
Reviewed-on: http://gerrit.cloudera.org:8080/9310
Reviewed-by: Lars Volker 
Reviewed-by: Philip Zeyliger 
Tested-by: Impala Public Jenkins
---
M bin/bootstrap_toolchain.py
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Lars Volker: Looks good to me, but someone else must approve
  Philip Zeyliger: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I83874220bd424a452df49520b5dad7bfa2124ca6
Gerrit-Change-Number: 9310
Gerrit-PatchSet: 5
Gerrit-Owner: Vincent Tran 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vincent Tran

[Impala-ASF-CR] IMPALA-6517: bootstrap toolchain.py fails to recognize lsb release output from RHEL OS

2018-02-21 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9310 )

Change subject: IMPALA-6517: bootstrap_toolchain.py fails to recognize 
lsb_release output from RHEL OS
..


Patch Set 4: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83874220bd424a452df49520b5dad7bfa2124ca6
Gerrit-Change-Number: 9310
Gerrit-PatchSet: 4
Gerrit-Owner: Vincent Tran 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vincent Tran 
Gerrit-Comment-Date: Thu, 22 Feb 2018 03:28:20 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6517: bootstrap toolchain.py fails to recognize lsb release output from RHEL OS

2018-02-21 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9310 )

Change subject: IMPALA-6517: bootstrap_toolchain.py fails to recognize 
lsb_release output from RHEL OS
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1979/


--
To view, visit http://gerrit.cloudera.org:8080/9310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83874220bd424a452df49520b5dad7bfa2124ca6
Gerrit-Change-Number: 9310
Gerrit-PatchSet: 4
Gerrit-Owner: Vincent Tran 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vincent Tran 
Gerrit-Comment-Date: Wed, 21 Feb 2018 23:51:22 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6517: bootstrap toolchain.py fails to recognize lsb release output from RHEL OS

2018-02-21 Thread Philip Zeyliger (Code Review) 
Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9310 )

Change subject: IMPALA-6517: bootstrap_toolchain.py fails to recognize 
lsb_release output from RHEL OS
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/9310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83874220bd424a452df49520b5dad7bfa2124ca6
Gerrit-Change-Number: 9310
Gerrit-PatchSet: 4
Gerrit-Owner: Vincent Tran 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vincent Tran 
Gerrit-Comment-Date: Wed, 21 Feb 2018 23:51:03 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6517: bootstrap toolchain.py fails to recognize lsb release output from RHEL OS

2018-02-20 Thread Lars Volker (Code Review) 
Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9310 )

Change subject: IMPALA-6517: bootstrap_toolchain.py fails to recognize 
lsb_release output from RHEL OS
..


Patch Set 4: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/9310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83874220bd424a452df49520b5dad7bfa2124ca6
Gerrit-Change-Number: 9310
Gerrit-PatchSet: 4
Gerrit-Owner: Vincent Tran 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vincent Tran 
Gerrit-Comment-Date: Wed, 21 Feb 2018 02:29:27 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6517: bootstrap toolchain.py fails to recognize lsb release output from RHEL OS

2018-02-20 Thread Vincent Tran (Code Review) 
Hello Lars Volker, Philip Zeyliger,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9310

to look at the new patch set (#4).

Change subject: IMPALA-6517: bootstrap_toolchain.py fails to recognize 
lsb_release output from RHEL OS
..

IMPALA-6517: bootstrap_toolchain.py fails to recognize lsb_release
output from RHEL OS

The OS map that we currently use to check platform/OS release
against in bootstrap_toolchain.py does not contain key-value pairs
for Redhat platforms.
e.g.
lsb_release -irs
RedHatEnterpriseServer 6.9

This change adds RHEL5, RHEL6 and RHEL7 to the OS map. It also
relaxes the matching criteria for RHEL and CentOS to only major
version.

Testing: I manually cloned a repo locally and called
bootstrap_toolchain.py to verify that it can detect the platform.
Testing was done against RHEL6, RHEL7, Ubuntu16.04 and Centos7.

Change-Id: I83874220bd424a452df49520b5dad7bfa2124ca6
---
M bin/bootstrap_toolchain.py
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/9310/4
--
To view, visit http://gerrit.cloudera.org:8080/9310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I83874220bd424a452df49520b5dad7bfa2124ca6
Gerrit-Change-Number: 9310
Gerrit-PatchSet: 4
Gerrit-Owner: Vincent Tran 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vincent Tran

[Impala-ASF-CR] IMPALA-6517: bootstrap toolchain.py fails to recognize lsb release output from RHEL OS

2018-02-20 Thread Vincent Tran (Code Review) 
Vincent Tran has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9310 )

Change subject: IMPALA-6517: bootstrap_toolchain.py fails to recognize 
lsb_release output from RHEL OS
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9310/3/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

http://gerrit.cloudera.org:8080/#/c/9310/3/bin/bootstrap_toolchain.py@115
PS3, Line 115:   if any(platform in release for platform in 
enterprise_linux):
> I feel this would be more readable as
Done



--
To view, visit http://gerrit.cloudera.org:8080/9310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83874220bd424a452df49520b5dad7bfa2124ca6
Gerrit-Change-Number: 9310
Gerrit-PatchSet: 3
Gerrit-Owner: Vincent Tran 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vincent Tran 
Gerrit-Comment-Date: Wed, 21 Feb 2018 02:18:15 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6517: bootstrap toolchain.py fails to recognize lsb release output from RHEL OS

2018-02-20 Thread Lars Volker (Code Review) 
Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9310 )

Change subject: IMPALA-6517: bootstrap_toolchain.py fails to recognize 
lsb_release output from RHEL OS
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9310/3/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

http://gerrit.cloudera.org:8080/#/c/9310/3/bin/bootstrap_toolchain.py@115
PS3, Line 115:   if any(platform in release for platform in 
enterprise_linux):
I feel this would be more readable as

  for platform in ['centos', '...']:
if platform in release:
  release = ...
  break



--
To view, visit http://gerrit.cloudera.org:8080/9310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83874220bd424a452df49520b5dad7bfa2124ca6
Gerrit-Change-Number: 9310
Gerrit-PatchSet: 3
Gerrit-Owner: Vincent Tran 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vincent Tran 
Gerrit-Comment-Date: Wed, 21 Feb 2018 01:52:57 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6517: bootstrap toolchain.py fails to recognize lsb release output from RHEL OS

2018-02-13 Thread Vincent Tran (Code Review) 
Hello Philip Zeyliger,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/9310

to look at the new patch set (#3).

Change subject: IMPALA-6517: bootstrap_toolchain.py fails to recognize 
lsb_release output from RHEL OS
..

IMPALA-6517: bootstrap_toolchain.py fails to recognize lsb_release
output from RHEL OS

The OS map that we currently use to check platform / release
against in bootstrap_toolchain.py does not contain key-value pairs
for:
lsb_release -irs
RedHatEnterpriseServer 6.9

This change adds RHEL5, RHEL6 and RHEL7 to the OS map.

Testing was done by cloning a repo locally and calling
bootstrap_toolchain.py
Testing was done against RHEL6, RHEL7, Ubuntu16.x and Centos7.x

Change-Id: I83874220bd424a452df49520b5dad7bfa2124ca6
---
M bin/bootstrap_toolchain.py
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/9310/3
--
To view, visit http://gerrit.cloudera.org:8080/9310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I83874220bd424a452df49520b5dad7bfa2124ca6
Gerrit-Change-Number: 9310
Gerrit-PatchSet: 3
Gerrit-Owner: Vincent Tran 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vincent Tran

[Impala-ASF-CR] IMPALA-6517: bootstrap toolchain.py fails to recognize lsb release output from RHEL OS

2018-02-13 Thread Vincent Tran (Code Review) 
Vincent Tran has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9310 )

Change subject: IMPALA-6517: bootstrap_toolchain.py fails to recognize 
lsb_release output from RHEL OS
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9310/1/bin/bootstrap_toolchain.py
File bin/bootstrap_toolchain.py:

http://gerrit.cloudera.org:8080/#/c/9310/1/bin/bootstrap_toolchain.py@63
PS1, Line 63:   "ubuntu12" : "ec2-package-ubuntu-12-04",
> This is problematic. Ubuntu has a 12.10 and 14.10 and 16.10 release per htt
Ah. I didn't realize that.
The way we mapped Ubuntu 14.04, 15.04, and 15.10 all to 
ec2-package-ubuntu-14-04 had me thinking that minor version was unimportant.

Fixed



--
To view, visit http://gerrit.cloudera.org:8080/9310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83874220bd424a452df49520b5dad7bfa2124ca6
Gerrit-Change-Number: 9310
Gerrit-PatchSet: 1
Gerrit-Owner: Vincent Tran 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Vincent Tran 
Gerrit-Comment-Date: Wed, 14 Feb 2018 03:01:59 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6517: bootstrap toolchain.py fails to recognize lsb release output from RHEL OS

2018-02-13 Thread Vincent Tran (Code Review) 
Vincent Tran has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9310


Change subject: IMPALA-6517: bootstrap_toolchain.py fails to recognize 
lsb_release output from RHEL OS
..

IMPALA-6517: bootstrap_toolchain.py fails to recognize lsb_release
output from RHEL OS

The OS map that we currently use to check platform / release
against in bootstrap_toolchain.py does not contain key-value pairs
for:
lsb_release -irs
RedHatEnterpriseServer 6.9

This change adds RHEL5, RHEL6 and RHEL7  to the list and
relaxes the matching rule to only check the platform's major
release.

Testing was done by cloning a repo locally and calling
bootstrap_toolchain.py
Testing was done against RHEL6, RHEL7, Ubuntu16.x and Centos7.x

Change-Id: I83874220bd424a452df49520b5dad7bfa2124ca6
---
M bin/bootstrap_toolchain.py
1 file changed, 11 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/9310/1
--
To view, visit http://gerrit.cloudera.org:8080/9310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83874220bd424a452df49520b5dad7bfa2124ca6
Gerrit-Change-Number: 9310
Gerrit-PatchSet: 1
Gerrit-Owner: Vincent Tran