[Impala-ASF-CR] IMPALA-6820: Remove impala builtins from catalogd

2018-04-10 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9947 )

Change subject: IMPALA-6820: Remove _impala_builtins from catalogd
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/9947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Gerrit-Change-Number: 9947
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Wed, 11 Apr 2018 03:55:06 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6820: Remove impala builtins from catalogd

2018-04-10 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/9947 )

Change subject: IMPALA-6820: Remove _impala_builtins from catalogd
..

IMPALA-6820: Remove _impala_builtins from catalogd

The _impala_builtins database is initialized in the constructor of
Catalog and hence is inherited by both the CatalogServiceCatalog and
ImpaladCatalog. Since  _impala_builtins is not used by the catalog
server and to avoid the overhead of managing this database during normal
metadata operations (e.g. invalidate), it is moved to the ImpaladCatalog
class.

Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Reviewed-on: http://gerrit.cloudera.org:8080/9947
Reviewed-by: Tianyi Wang 
Tested-by: Impala Public Jenkins 
---
M fe/src/main/java/org/apache/impala/analysis/CastExpr.java
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/main/java/org/apache/impala/analysis/ExtractFromExpr.java
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
M fe/src/main/java/org/apache/impala/analysis/FunctionName.java
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
10 files changed, 34 insertions(+), 29 deletions(-)

Approvals:
  Tianyi Wang: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/9947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Gerrit-Change-Number: 9947
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang

[Impala-ASF-CR] IMPALA-6820: Remove impala builtins from catalogd

2018-04-10 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9947 )

Change subject: IMPALA-6820: Remove _impala_builtins from catalogd
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2277/


--
To view, visit http://gerrit.cloudera.org:8080/9947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Gerrit-Change-Number: 9947
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Wed, 11 Apr 2018 00:04:39 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6820: Remove impala builtins from catalogd

2018-04-10 Thread Tianyi Wang (Code Review) 
Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9947 )

Change subject: IMPALA-6820: Remove _impala_builtins from catalogd
..


Patch Set 2:

> Patch Set 2: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2264/

It hit IMPALA-6092


--
To view, visit http://gerrit.cloudera.org:8080/9947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Gerrit-Change-Number: 9947
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Wed, 11 Apr 2018 00:04:25 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6820: Remove impala builtins from catalogd

2018-04-09 Thread Tianyi Wang (Code Review) 
Tianyi Wang has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/9947 )

Change subject: IMPALA-6820: Remove _impala_builtins from catalogd
..

IMPALA-6820: Remove _impala_builtins from catalogd

The _impala_builtins database is initialized in the constructor of
Catalog and hence is inherited by both the CatalogServiceCatalog and
ImpaladCatalog. Since  _impala_builtins is not used by the catalog
server and to avoid the overhead of managing this database during normal
metadata operations (e.g. invalidate), it is moved to the ImpaladCatalog
class.

Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
---
M fe/src/main/java/org/apache/impala/analysis/CastExpr.java
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/main/java/org/apache/impala/analysis/ExtractFromExpr.java
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
M fe/src/main/java/org/apache/impala/analysis/FunctionName.java
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
10 files changed, 34 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/9947/2
--
To view, visit http://gerrit.cloudera.org:8080/9947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Gerrit-Change-Number: 9947
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis

[Impala-ASF-CR] IMPALA-6820: Remove impala builtins from catalogd

2018-04-09 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9947 )

Change subject: IMPALA-6820: Remove _impala_builtins from catalogd
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2264/


--
To view, visit http://gerrit.cloudera.org:8080/9947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Gerrit-Change-Number: 9947
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Mon, 09 Apr 2018 23:44:39 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-6820: Remove impala builtins from catalogd

2018-04-09 Thread Tianyi Wang (Code Review) 
Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9947 )

Change subject: IMPALA-6820: Remove _impala_builtins from catalogd
..


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9947/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9947/1//COMMIT_MSG@9
PS1, Line 9: The _impala_builtins database is initialized in the constructor of
   : Catalog and hence is i
> The _impala_builtins database is initialized in the constructor of Catalog
Done



--
To view, visit http://gerrit.cloudera.org:8080/9947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Gerrit-Change-Number: 9947
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Mon, 09 Apr 2018 23:44:28 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6820: Remove impala builtins from catalogd

2018-04-09 Thread Dimitris Tsirogiannis (Code Review) 
Dimitris Tsirogiannis has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9947 )

Change subject: IMPALA-6820: Remove _impala_builtins from catalogd
..


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9947/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9947/1//COMMIT_MSG@9
PS1, Line 9: _impala_builtins is created in the constructor of
   : CatalogServiceCatalog.
The _impala_builtins database is initialized in the constructor of Catalog and 
hence is inherited by both the CatalogServiceCatalog and ImpaladCatalog. Since  
_impala_builtins is not used by the catalog server and to avoid the overhead of 
managing this database during normal metadata operations (e.g. invalidate), it 
is moved to the ImpaladCatalog class.



--
To view, visit http://gerrit.cloudera.org:8080/9947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Gerrit-Change-Number: 9947
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang 
Gerrit-Reviewer: Dimitris Tsirogiannis 
Gerrit-Comment-Date: Mon, 09 Apr 2018 23:35:07 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-6820: Remove impala builtins from catalogd

2018-04-06 Thread Tianyi Wang (Code Review) 
Tianyi Wang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/9947


Change subject: IMPALA-6820: Remove _impala_builtins from catalogd
..

IMPALA-6820: Remove _impala_builtins from catalogd

_impala_builtins is created in the constructor of
CatalogServiceCatalog. But it will then be deleted by
CatalogServiceCatalog.reset(), leaving a delete log in catalogd and it
will be sent to statestored. Though statestore doesn't send it to
impalad, it's still a potential problem. This patch removes
_impala_builtins from catalogd entirely, making it a impalad-only
member.

Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
---
M fe/src/main/java/org/apache/impala/analysis/CastExpr.java
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/main/java/org/apache/impala/analysis/ExtractFromExpr.java
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
M fe/src/main/java/org/apache/impala/analysis/FunctionName.java
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java
M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
10 files changed, 34 insertions(+), 29 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/9947/1
--
To view, visit http://gerrit.cloudera.org:8080/9947
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I166d8086db1d2920408f38dc56fe7c70a4c143a8
Gerrit-Change-Number: 9947
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang