[Impala-ASF-CR] IMPALA-6835: Add table name and node id to Kudu scanner errors

2018-06-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10671 )

Change subject: IMPALA-6835: Add table name and node id to Kudu scanner errors
..


Patch Set 4: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0377fc8591738dc45092d228fcf292ddbb367825
Gerrit-Change-Number: 10671
Gerrit-PatchSet: 4
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 13 Jun 2018 20:49:10 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6835: Add table name and node id to Kudu scanner errors

2018-06-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10671 )

Change subject: IMPALA-6835: Add table name and node id to Kudu scanner errors
..

IMPALA-6835: Add table name and node id to Kudu scanner errors

Previously, the error messages in KuduScanner only contained the
reason for failure. They did not contain the KuduTable name or the
TPlanNode id which made it inconveient to debug. This change adds
the TPlanNode id to all error messages and the KuduTable name
whenever applicable.

This change was manually tested by explicitly returning failure
while scanning kudu tables.

Change-Id: I0377fc8591738dc45092d228fcf292ddbb367825
Reviewed-on: http://gerrit.cloudera.org:8080/10671
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M be/src/exec/kudu-scanner.cc
M be/src/exec/kudu-scanner.h
M be/src/exec/kudu-util.h
3 files changed, 27 insertions(+), 14 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/10671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0377fc8591738dc45092d228fcf292ddbb367825
Gerrit-Change-Number: 10671
Gerrit-PatchSet: 5
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-6835: Add table name and node id to Kudu scanner errors

2018-06-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10671 )

Change subject: IMPALA-6835: Add table name and node id to Kudu scanner errors
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0377fc8591738dc45092d228fcf292ddbb367825
Gerrit-Change-Number: 10671
Gerrit-PatchSet: 4
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 13 Jun 2018 17:23:54 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6835: Add table name and node id to Kudu scanner errors

2018-06-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10671 )

Change subject: IMPALA-6835: Add table name and node id to Kudu scanner errors
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2653/


--
To view, visit http://gerrit.cloudera.org:8080/10671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0377fc8591738dc45092d228fcf292ddbb367825
Gerrit-Change-Number: 10671
Gerrit-PatchSet: 4
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 13 Jun 2018 17:23:55 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6835: Add table name and node id to Kudu scanner errors

2018-06-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10671 )

Change subject: IMPALA-6835: Add table name and node id to Kudu scanner errors
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0377fc8591738dc45092d228fcf292ddbb367825
Gerrit-Change-Number: 10671
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 13 Jun 2018 17:23:41 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6835: Add table name and node id to Kudu scanner errors

2018-06-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10671 )

Change subject: IMPALA-6835: Add table name and node id to Kudu scanner errors
..


Patch Set 3: Code-Review+1


--
To view, visit http://gerrit.cloudera.org:8080/10671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0377fc8591738dc45092d228fcf292ddbb367825
Gerrit-Change-Number: 10671
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 13 Jun 2018 15:33:51 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-6835: Add table name and node id to Kudu scanner errors

2018-06-12 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#3). ( 
http://gerrit.cloudera.org:8080/10671 )

Change subject: IMPALA-6835: Add table name and node id to Kudu scanner errors
..

IMPALA-6835: Add table name and node id to Kudu scanner errors

Previously, the error messages in KuduScanner only contained the
reason for failure. They did not contain the KuduTable name or the
TPlanNode id which made it inconveient to debug. This change adds
the TPlanNode id to all error messages and the KuduTable name
whenever applicable.

This change was manually tested by explicitly returning failure
while scanning kudu tables.

Change-Id: I0377fc8591738dc45092d228fcf292ddbb367825
---
M be/src/exec/kudu-scanner.cc
M be/src/exec/kudu-scanner.h
M be/src/exec/kudu-util.h
3 files changed, 27 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/10671/3
-- 
To view, visit http://gerrit.cloudera.org:8080/10671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0377fc8591738dc45092d228fcf292ddbb367825
Gerrit-Change-Number: 10671
Gerrit-PatchSet: 3
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR] IMPALA-6835: Add table name and node id to Kudu scanner errors

2018-06-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10671 )

Change subject: IMPALA-6835: Add table name and node id to Kudu scanner errors
..


Patch Set 2:

(2 comments)

Looks good, just a couple of style nits.

http://gerrit.cloudera.org:8080/#/c/10671/2/be/src/exec/kudu-scanner.h
File be/src/exec/kudu-scanner.h:

http://gerrit.cloudera.org:8080/#/c/10671/2/be/src/exec/kudu-scanner.h@93
PS2, Line 93: inline
nit: inline isn't necessary, this isn't perf-critical code.

I think it would be better to put this function definition in the .cc file as 
well - no reason to add more code to headers when not necessary, it hurts build 
times.


http://gerrit.cloudera.org:8080/#/c/10671/2/be/src/exec/kudu-scanner.h@93
PS2, Line 93: AppendInfo
Maybe this could be something more specific like "BuildErrorString"?



--
To view, visit http://gerrit.cloudera.org:8080/10671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0377fc8591738dc45092d228fcf292ddbb367825
Gerrit-Change-Number: 10671
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Tue, 12 Jun 2018 00:21:02 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-6835: Add table name and node id to Kudu scanner errors

2018-06-11 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#2). ( 
http://gerrit.cloudera.org:8080/10671 )

Change subject: IMPALA-6835: Add table name and node id to Kudu scanner errors
..

IMPALA-6835: Add table name and node id to Kudu scanner errors

Previously, the error messages in KuduScanner only contained the
reason for failure. They did not contain the KuduTable name or the
TPlanNode id which made it inconveient to debug. This change adds
the TPlanNode id to all error messages and the KuduTable name
whenever applicable.

This change was manually tested by explicitly returning failure
while scanning kudu tables.

Change-Id: I0377fc8591738dc45092d228fcf292ddbb367825
---
M be/src/exec/kudu-scanner.cc
M be/src/exec/kudu-scanner.h
M be/src/exec/kudu-util.h
3 files changed, 26 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/10671/2
-- 
To view, visit http://gerrit.cloudera.org:8080/10671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0377fc8591738dc45092d228fcf292ddbb367825
Gerrit-Change-Number: 10671
Gerrit-PatchSet: 2
Gerrit-Owner: Pooja Nilangekar 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Pooja Nilangekar 
Gerrit-Reviewer: Tim Armstrong