[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10064 ) Change subject: IMPALA-6850: Print actual error message on Sentry error .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76627bb5b986a548ec6e4f12b555bd6fc8c4dab8 Gerrit-Change-Number: 10064 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Sat, 14 Apr 2018 01:41:37 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10064 ) Change subject: IMPALA-6850: Print actual error message on Sentry error .. IMPALA-6850: Print actual error message on Sentry error The patch puts the output of Sentry to $IMPALA_CLUSTER_LOGS_DIR/sentry/sentry.out to follow the same convention as other service output logs. Testing: - Injected some failure in run-sentry-service.sh script to see if the error message was captured Change-Id: I76627bb5b986a548ec6e4f12b555bd6fc8c4dab8 Reviewed-on: http://gerrit.cloudera.org:8080/10064 Reviewed-by: Vuk Ercegovac Reviewed-by: Philip Zeyliger Tested-by: Impala Public Jenkins --- M testdata/bin/run-all.sh M testdata/bin/run-sentry-service.sh 2 files changed, 8 insertions(+), 5 deletions(-) Approvals: Vuk Ercegovac: Looks good to me, approved Philip Zeyliger: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I76627bb5b986a548ec6e4f12b555bd6fc8c4dab8 Gerrit-Change-Number: 10064 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10064 ) Change subject: IMPALA-6850: Print actual error message on Sentry error .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2311/ -- To view, visit http://gerrit.cloudera.org:8080/10064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76627bb5b986a548ec6e4f12b555bd6fc8c4dab8 Gerrit-Change-Number: 10064 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 13 Apr 2018 21:52:55 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10064 ) Change subject: IMPALA-6850: Print actual error message on Sentry error .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76627bb5b986a548ec6e4f12b555bd6fc8c4dab8 Gerrit-Change-Number: 10064 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 13 Apr 2018 21:08:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10064 ) Change subject: IMPALA-6850: Print actual error message on Sentry error .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76627bb5b986a548ec6e4f12b555bd6fc8c4dab8 Gerrit-Change-Number: 10064 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 13 Apr 2018 20:51:29 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10064 ) Change subject: IMPALA-6850: Print actual error message on Sentry error .. Patch Set 3: Please re-review it again. I found a bug earlier where the parent stdout wasn't closed properly due to the way we start Sentry service. -- To view, visit http://gerrit.cloudera.org:8080/10064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76627bb5b986a548ec6e4f12b555bd6fc8c4dab8 Gerrit-Change-Number: 10064 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac Gerrit-Comment-Date: Fri, 13 Apr 2018 20:29:23 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10064 ) Change subject: IMPALA-6850: Print actual error message on Sentry error .. IMPALA-6850: Print actual error message on Sentry error The patch puts the output of Sentry to $IMPALA_CLUSTER_LOGS_DIR/sentry/sentry.out to follow the same convention as other service output logs. Testing: - Injected some failure in run-sentry-service.sh script to see if the error message was captured Change-Id: I76627bb5b986a548ec6e4f12b555bd6fc8c4dab8 --- M testdata/bin/run-all.sh M testdata/bin/run-sentry-service.sh 2 files changed, 8 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/10064/3 -- To view, visit http://gerrit.cloudera.org:8080/10064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I76627bb5b986a548ec6e4f12b555bd6fc8c4dab8 Gerrit-Change-Number: 10064 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error
Fredy Wijaya has removed a vote on this change. Change subject: IMPALA-6850: Print actual error message on Sentry error .. Removed Code-Review+2 by Vuk Ercegovac -- To view, visit http://gerrit.cloudera.org:8080/10064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I76627bb5b986a548ec6e4f12b555bd6fc8c4dab8 Gerrit-Change-Number: 10064 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error
Fredy Wijaya has removed a vote on this change. Change subject: IMPALA-6850: Print actual error message on Sentry error .. Removed Code-Review+2 by Philip Zeyliger -- To view, visit http://gerrit.cloudera.org:8080/10064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I76627bb5b986a548ec6e4f12b555bd6fc8c4dab8 Gerrit-Change-Number: 10064 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya Gerrit-Reviewer: Fredy Wijaya Gerrit-Reviewer: Philip Zeyliger Gerrit-Reviewer: Vuk Ercegovac
[Impala-ASF-CR] IMPALA-6850: Print actual error message on Sentry error
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10064 Change subject: IMPALA-6850: Print actual error message on Sentry error .. IMPALA-6850: Print actual error message on Sentry error Testing: - Injected some failure in run-sentry-service.sh script to see if the error message was captured Change-Id: I76627bb5b986a548ec6e4f12b555bd6fc8c4dab8 --- M testdata/bin/run-all.sh 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/10064/1 -- To view, visit http://gerrit.cloudera.org:8080/10064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I76627bb5b986a548ec6e4f12b555bd6fc8c4dab8 Gerrit-Change-Number: 10064 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya
