[Impala-ASF-CR] IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes.

2018-05-23 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10487 )

Change subject: IMPALA-7063: Fix compilation for MiniProfile2 after Erasure 
Coding changes.
..


Patch Set 2: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I423087078f84b0806545322519f224d58815123d
Gerrit-Change-Number: 10487
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Wed, 23 May 2018 21:45:08 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes.

2018-05-23 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10487 )

Change subject: IMPALA-7063: Fix compilation for MiniProfile2 after Erasure 
Coding changes.
..

IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes.

This commit shims out HDFS's FileStatus.isErasureCoded() to manage
working with multiple versions of Hadoop.

I tested compilation with both profiles.

Cherry-picks: not for 2.x.

Change-Id: I423087078f84b0806545322519f224d58815123d
Reviewed-on: http://gerrit.cloudera.org:8080/10487
Reviewed-by: Philip Zeyliger 
Tested-by: Impala Public Jenkins 
---
A 
fe/src/compat-minicluster-profile-2/java/org/apache/impala/compat/HdfsShim.java
A 
fe/src/compat-minicluster-profile-3/java/org/apache/impala/compat/HdfsShim.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
3 files changed, 64 insertions(+), 2 deletions(-)

Approvals:
  Philip Zeyliger: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I423087078f84b0806545322519f224d58815123d
Gerrit-Change-Number: 10487
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang

[Impala-ASF-CR] IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes.

2018-05-23 Thread Tianyi Wang (Code Review) 
Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10487 )

Change subject: IMPALA-7063: Fix compilation for MiniProfile2 after Erasure 
Coding changes.
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10487/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:

http://gerrit.cloudera.org:8080/#/c/10487/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@67
PS1, Line 67: import org.apache.impala.compat.HdfsShim;
> I think they are? common < compat < fb?
I misread



--
To view, visit http://gerrit.cloudera.org:8080/10487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I423087078f84b0806545322519f224d58815123d
Gerrit-Change-Number: 10487
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Wed, 23 May 2018 18:25:34 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes.

2018-05-23 Thread Impala Public Jenkins (Code Review) 
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10487 )

Change subject: IMPALA-7063: Fix compilation for MiniProfile2 after Erasure 
Coding changes.
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2535/


--
To view, visit http://gerrit.cloudera.org:8080/10487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I423087078f84b0806545322519f224d58815123d
Gerrit-Change-Number: 10487
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Wed, 23 May 2018 18:22:37 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes.

2018-05-23 Thread Philip Zeyliger (Code Review) 
Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10487 )

Change subject: IMPALA-7063: Fix compilation for MiniProfile2 after Erasure 
Coding changes.
..


Patch Set 2: Code-Review+2

Carrying +2.


--
To view, visit http://gerrit.cloudera.org:8080/10487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I423087078f84b0806545322519f224d58815123d
Gerrit-Change-Number: 10487
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Wed, 23 May 2018 18:22:30 +
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes.

2018-05-23 Thread Tianyi Wang (Code Review) 
Tianyi Wang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10487 )

Change subject: IMPALA-7063: Fix compilation for MiniProfile2 after Erasure 
Coding changes.
..


Patch Set 1: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10487/1/fe/src/compat-minicluster-profile-2/java/org/apache/impala/compat/HdfsShim.java
File 
fe/src/compat-minicluster-profile-2/java/org/apache/impala/compat/HdfsShim.java:

http://gerrit.cloudera.org:8080/#/c/10487/1/fe/src/compat-minicluster-profile-2/java/org/apache/impala/compat/HdfsShim.java@23
PS1, Line 23: diffences betwen
typo


http://gerrit.cloudera.org:8080/#/c/10487/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:

http://gerrit.cloudera.org:8080/#/c/10487/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@67
PS1, Line 67: import org.apache.impala.compat.HdfsShim;
The imports should be sorted



--
To view, visit http://gerrit.cloudera.org:8080/10487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I423087078f84b0806545322519f224d58815123d
Gerrit-Change-Number: 10487
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger 
Gerrit-Reviewer: Tianyi Wang 
Gerrit-Comment-Date: Wed, 23 May 2018 18:20:03 +
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes.

2018-05-23 Thread Philip Zeyliger (Code Review) 
Philip Zeyliger has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10487


Change subject: IMPALA-7063: Fix compilation for MiniProfile2 after Erasure 
Coding changes.
..

IMPALA-7063: Fix compilation for MiniProfile2 after Erasure Coding changes.

This commit shims out HDFS's FileStatus.isErasureCoded() to manage
working with multiple versions of Hadoop.

I tested compilation with both profiles.

Cherry-picks: not for 2.x.

Change-Id: I423087078f84b0806545322519f224d58815123d
---
A 
fe/src/compat-minicluster-profile-2/java/org/apache/impala/compat/HdfsShim.java
A 
fe/src/compat-minicluster-profile-3/java/org/apache/impala/compat/HdfsShim.java
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
3 files changed, 63 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/10487/1
--
To view, visit http://gerrit.cloudera.org:8080/10487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I423087078f84b0806545322519f224d58815123d
Gerrit-Change-Number: 10487
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger