[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10703 )

Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..

IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Reviewed-on: http://gerrit.cloudera.org:8080/10703
Reviewed-by: Vuk Ercegovac 
Tested-by: Impala Public Jenkins 
---
M docs/shared/impala_common.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_runtime_filtering.xml
3 files changed, 99 insertions(+), 61 deletions(-)

Approvals:
  Vuk Ercegovac: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vuk Ercegovac 


[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10703 )

Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..


Patch Set 4: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Thu, 14 Jun 2018 16:16:10 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10703 )

Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/317/


--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Thu, 14 Jun 2018 16:02:48 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10703 )

Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Thu, 14 Jun 2018 16:02:00 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-14 Thread Alex Rodoni (Code Review)
Hello Henry Robinson, Gabor Kaszab, Impala Public Jenkins, Vuk Ercegovac,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10703

to look at the new patch set (#4).

Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..

IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
---
M docs/shared/impala_common.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_runtime_filtering.xml
3 files changed, 99 insertions(+), 61 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/10703/4
--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vuk Ercegovac 


[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10703 )

Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10703/2/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/10703/2/docs/shared/impala_common.xml@a1883
PS2, Line 1883:
> did this text get moved to the other file?
This text was now restored.


http://gerrit.cloudera.org:8080/#/c/10703/2/docs/topics/impala_runtime_filtering.xml
File docs/topics/impala_runtime_filtering.xml:

http://gerrit.cloudera.org:8080/#/c/10703/2/docs/topics/impala_runtime_filtering.xml@348
PS2, Line 348: labelled
> labeled
Done



--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 13 Jun 2018 23:27:44 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10703 )

Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..


Patch Set 2:

The original example mixed in some static partition pruning (because the 
planner could infer that the probe-side join key was also subject to the 
BETWEEN predicate applied to the build-side).

It wasn't wrong, but was a bit confusing because the plan showed a reduction in 
the number of partitions read that wasn't due to DPP.


--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 13 Jun 2018 23:30:30 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10703 )

Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..


Patch Set 3:

ah, thanks for the explanation!


--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 13 Jun 2018 23:36:38 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-13 Thread Alex Rodoni (Code Review)
Hello Henry Robinson, Gabor Kaszab, Impala Public Jenkins, Vuk Ercegovac,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10703

to look at the new patch set (#3).

Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..

IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
---
M docs/shared/impala_common.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_runtime_filtering.xml
3 files changed, 96 insertions(+), 58 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/10703/3
--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vuk Ercegovac 


[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10703 )

Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..


Patch Set 2:

(2 comments)

what was missing/incorrect in the example?

http://gerrit.cloudera.org:8080/#/c/10703/2/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/10703/2/docs/shared/impala_common.xml@a1883
PS2, Line 1883:
did this text get moved to the other file?


http://gerrit.cloudera.org:8080/#/c/10703/2/docs/topics/impala_runtime_filtering.xml
File docs/topics/impala_runtime_filtering.xml:

http://gerrit.cloudera.org:8080/#/c/10703/2/docs/topics/impala_runtime_filtering.xml@348
PS2, Line 348: labelled
labeled



--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 13 Jun 2018 23:19:23 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10703 )

Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/316/


--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 13 Jun 2018 23:16:38 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10703 )

Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 13 Jun 2018 23:09:48 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10703 )

Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/10703/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/10703/1/docs/shared/impala_common.xml@1873
PS1, Line 1873: STORED AS PARQUET
> This doesn't depend on file format, so that can be dropped as well.
Done


http://gerrit.cloudera.org:8080/#/c/10703/1/docs/shared/impala_common.xml@1878
PS1, Line 1878: PARTITIONED
> this table doesn't need to be partitioned. It would make sense not to have
Done


http://gerrit.cloudera.org:8080/#/c/10703/1/docs/shared/impala_common.xml@1884
PS1, Line 1884: SUMMARY; -- Shows 2 rows in yy were pruned, and 3 out of 5 rows 
were scanned.
> I think it's helpful to show the plan for the SELECT query. It shows that r
Done


http://gerrit.cloudera.org:8080/#/c/10703/1/docs/shared/impala_common.xml@1884
PS1, Line 1884: SUMMARY
> agreed that explain and an extract from "profile;" (not summary) would be m
Done



--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Alex Rodoni 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 13 Jun 2018 22:15:07 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-13 Thread Alex Rodoni (Code Review)
Hello Henry Robinson, Gabor Kaszab, Impala Public Jenkins, Vuk Ercegovac,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10703

to look at the new patch set (#2).

Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..

IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
---
M docs/shared/impala_common.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_runtime_filtering.xml
3 files changed, 92 insertions(+), 59 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/10703/2
--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vuk Ercegovac 


[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10703 )

Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10703/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/10703/1/docs/shared/impala_common.xml@1873
PS1, Line 1873: STORED AS PARQUET
This doesn't depend on file format, so that can be dropped as well.


http://gerrit.cloudera.org:8080/#/c/10703/1/docs/shared/impala_common.xml@1884
PS1, Line 1884: SUMMARY
agreed that explain and an extract from "profile;" (not summary) would be more 
helpful.



--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 13 Jun 2018 21:55:37 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10703 )

Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..


Patch Set 1:

(2 comments)

Thank you for taking a look at this!

http://gerrit.cloudera.org:8080/#/c/10703/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/10703/1/docs/shared/impala_common.xml@1878
PS1, Line 1878: PARTITIONED
this table doesn't need to be partitioned. It would make sense not to have it 
partitioned because that should reinforce that Impala will actually read the 
join keys from the table and filter out the build side at run-time rather than 
looking at the partition metadata at planning-time.


http://gerrit.cloudera.org:8080/#/c/10703/1/docs/shared/impala_common.xml@1884
PS1, Line 1884: SUMMARY; -- Shows 2 rows in yy were pruned, and 3 out of 5 rows 
were scanned.
I think it's helpful to show the plan for the SELECT query. It shows that 
runtime filters are enabled, and also will show that the plan _expects_ to read 
all 5 partitions of yy (so static partition pruning isn't happening).

Then to show that some filtering actually happened, you can excerpt the 
following from the profile:

 Filter 0 (1.00 MB):
 - Files processed: 3 (3)
 - Files rejected: 1 (1)
 - Files total: 3 (3)

which shows (via files rejected) that the scan node filtered out a file based 
on a runtime filter. The total number of files rejected should sum across all 
scan nodes to 2 in this case, but each individual scan node will reject 0, 1 or 
2 files depending how the work is scheduled. If you run this on one node and 
take the profile output from there, the numbers will more obviously look like 
what the novice user might expect.



--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni 
Gerrit-Reviewer: Gabor Kaszab 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vuk Ercegovac 
Gerrit-Comment-Date: Wed, 13 Jun 2018 18:53:21 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

2018-06-12 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/10703


Change subject: IMPALA-7165: [DOCS] Correct example for dynamic partition 
pruning
..

IMPALA-7165: [DOCS] Correct example for dynamic partition pruning

Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
---
M docs/shared/impala_common.xml
1 file changed, 10 insertions(+), 32 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/10703/1
--
To view, visit http://gerrit.cloudera.org:8080/10703
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44d1054f55d3dc7947ccf4c2ef440e506c41f963
Gerrit-Change-Number: 10703
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni