[Impala-ASF-CR] IMPALA-7837: Fix flakiness in test resource limits for release builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11933 ) Change subject: IMPALA-7837: Fix flakiness in test_resource_limits for release builds .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/11933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a47391e52f3974db554dfc0d38139d3ee18a1b4 Gerrit-Change-Number: 11933 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 15 Nov 2018 05:48:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7837: Fix flakiness in test resource limits for release builds
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11933 ) Change subject: IMPALA-7837: Fix flakiness in test_resource_limits for release builds .. IMPALA-7837: Fix flakiness in test_resource_limits for release builds test_resource_limits was failing in release build because the queries used were finishing earlier than expected. This resulted in fragment instances not being able to send enough updates to the coordinator in order to hit the limits used for the tests. This patches adds a deterministic sleep to the queries which gives enough time to the coordinator to catch up on reports. Testing: Checked that tests passed on release builds. Change-Id: I4a47391e52f3974db554dfc0d38139d3ee18a1b4 Reviewed-on: http://gerrit.cloudera.org:8080/11933 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M testdata/workloads/functional-query/queries/QueryTest/query-resource-limits.test 1 file changed, 15 insertions(+), 12 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4a47391e52f3974db554dfc0d38139d3ee18a1b4 Gerrit-Change-Number: 11933 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-7837: Fix flakiness in test resource limits for release builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11933 ) Change subject: IMPALA-7837: Fix flakiness in test_resource_limits for release builds .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/1369/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/11933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a47391e52f3974db554dfc0d38139d3ee18a1b4 Gerrit-Change-Number: 11933 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 15 Nov 2018 02:12:38 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7837: Fix flakiness in test resource limits for release builds
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11933 ) Change subject: IMPALA-7837: Fix flakiness in test_resource_limits for release builds .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3463/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/11933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a47391e52f3974db554dfc0d38139d3ee18a1b4 Gerrit-Change-Number: 11933 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 15 Nov 2018 01:49:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7837: Fix flakiness in test resource limits for release builds
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11933 ) Change subject: IMPALA-7837: Fix flakiness in test_resource_limits for release builds .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a47391e52f3974db554dfc0d38139d3ee18a1b4 Gerrit-Change-Number: 11933 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Thu, 15 Nov 2018 01:39:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7837: Fix flakiness in test resource limits for release builds
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11933 Change subject: IMPALA-7837: Fix flakiness in test_resource_limits for release builds .. IMPALA-7837: Fix flakiness in test_resource_limits for release builds test_resource_limits was failing in release build because the queries used were finishing earlier than expected. This resulted in fragment instances not being able to send enough updates to the coordinator in order to hit the limits used for the tests. This patches adds a deterministic sleep to the queries which gives enough time to the coordinator to catch up on reports. Testing: Checked that tests passed on release builds. Change-Id: I4a47391e52f3974db554dfc0d38139d3ee18a1b4 --- M testdata/workloads/functional-query/queries/QueryTest/query-resource-limits.test 1 file changed, 15 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/11933/1 -- To view, visit http://gerrit.cloudera.org:8080/11933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4a47391e52f3974db554dfc0d38139d3ee18a1b4 Gerrit-Change-Number: 11933 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig
