[Impala-ASF-CR] IMPALA-8796: Restrict bit unpacking to unsigned integer types
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14031 ) Change subject: IMPALA-8796: Restrict bit unpacking to unsigned integer types .. IMPALA-8796: Restrict bit unpacking to unsigned integer types Restrict bit unpacking to the unsigned integer types uint8_t, uint16_t, uint32_t and uint64_t to simplify the interface of bit unpacking. Testing: Modified some tests that used bool or signed types for unpacking. Change-Id: I36cb57f43cc93e5dda6b6b2ff1617f1631f8cbe1 Reviewed-on: http://gerrit.cloudera.org:8080/14031 Reviewed-by: Csaba Ringhofer Tested-by: Impala Public Jenkins --- M be/src/exec/parquet/parquet-bool-decoder.h M be/src/util/bit-packing.cc M be/src/util/bit-packing.inline.h M be/src/util/bit-stream-utils-test.cc M be/src/util/bit-stream-utils.h 5 files changed, 40 insertions(+), 19 deletions(-) Approvals: Csaba Ringhofer: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I36cb57f43cc93e5dda6b6b2ff1617f1631f8cbe1 Gerrit-Change-Number: 14031 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-8796: Restrict bit unpacking to unsigned integer types
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14031 ) Change subject: IMPALA-8796: Restrict bit unpacking to unsigned integer types .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36cb57f43cc93e5dda6b6b2ff1617f1631f8cbe1 Gerrit-Change-Number: 14031 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 15 Aug 2019 16:04:51 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Restrict bit unpacking to unsigned integer types
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14031 ) Change subject: IMPALA-8796: Restrict bit unpacking to unsigned integer types .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4797/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/14031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36cb57f43cc93e5dda6b6b2ff1617f1631f8cbe1 Gerrit-Change-Number: 14031 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 15 Aug 2019 11:58:05 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Restrict bit unpacking to unsigned integer types
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14031 ) Change subject: IMPALA-8796: Restrict bit unpacking to unsigned integer types .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36cb57f43cc93e5dda6b6b2ff1617f1631f8cbe1 Gerrit-Change-Number: 14031 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 09 Aug 2019 12:23:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Restrict bit unpacking to unsigned integer types
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14031 ) Change subject: IMPALA-8796: Restrict bit unpacking to unsigned integer types .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4176/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36cb57f43cc93e5dda6b6b2ff1617f1631f8cbe1 Gerrit-Change-Number: 14031 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Wed, 07 Aug 2019 16:52:01 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Restrict bit unpacking to unsigned integer types
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14031 Change subject: IMPALA-8796: Restrict bit unpacking to unsigned integer types .. IMPALA-8796: Restrict bit unpacking to unsigned integer types Restrict bit unpacking to the unsigned integer types uint8_t, uint16_t, uint32_t and uint64_t to simplify the interface of bit unpacking. Testing: Modified some tests that used bool or signed types for unpacking. Change-Id: I36cb57f43cc93e5dda6b6b2ff1617f1631f8cbe1 --- M be/src/exec/parquet/parquet-bool-decoder.h M be/src/util/bit-packing.cc M be/src/util/bit-packing.inline.h M be/src/util/bit-stream-utils-test.cc M be/src/util/bit-stream-utils.h 5 files changed, 42 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14031/1 -- To view, visit http://gerrit.cloudera.org:8080/14031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I36cb57f43cc93e5dda6b6b2ff1617f1631f8cbe1 Gerrit-Change-Number: 14031 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker
