[Impala-ASF-CR] IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14043 ) Change subject: IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2. .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/14043/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14043/4//COMMIT_MSG@7 PS4, Line 7: IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2 > nit: I would prefer something more descriptive like "(Hive3) Use 'engine' f Done http://gerrit.cloudera.org:8080/#/c/14043/4//COMMIT_MSG@7 PS4, Line 7: part 1 > What does part 1 mean? Will there be additional changes after part 1 step 4 This is step 2 in a series of steps that involves both Hive and Impala. IMPALA-8842 covers the Impala related steps, that is: step 2 and step 4. so step 2 is part 1 of IMPALA-8842, while step 4 will be part 2. If you think this is too confusing, I could remove "part 1" from the summary. Or maybe I should remove "Step 2" from the end of the summary line? http://gerrit.cloudera.org:8080/#/c/14043/4//COMMIT_MSG@40 PS4, Line 40: > About testing: there were EE tests in https://gerrit.cloudera.org/#/c/14032 So far only step 1 has been merged in on the Hive side: "New APIs will simply call old existing methods so there should not be any change of functionality there." Since there's no new functionality, no new tests are needed. I'll add E2E tests in Step 4. -- To view, visit http://gerrit.cloudera.org:8080/14043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a73f5eeac8e84d63b22aaed5dfbcd8ea39f0af4 Gerrit-Change-Number: 14043 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 15 Aug 2019 14:29:07 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14043 ) Change subject: IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2. .. Patch Set 4: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/14043/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14043/4//COMMIT_MSG@7 PS4, Line 7: IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2 nit: I would prefer something more descriptive like "(Hive3) Use 'engine' field in HMS stat API" http://gerrit.cloudera.org:8080/#/c/14043/4//COMMIT_MSG@7 PS4, Line 7: part 1 What does part 1 mean? Will there be additional changes after part 1 step 4? http://gerrit.cloudera.org:8080/#/c/14043/4//COMMIT_MSG@40 PS4, Line 40: About testing: there were EE tests in https://gerrit.cloudera.org/#/c/14032/4/tests/metadata/test_hms_integration.py Shouldn't that work at this point? Please add a comment if the tests do not work yet or add the tests if they do. -- To view, visit http://gerrit.cloudera.org:8080/14043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a73f5eeac8e84d63b22aaed5dfbcd8ea39f0af4 Gerrit-Change-Number: 14043 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Csaba Ringhofer Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 15 Aug 2019 13:12:45 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14043 ) Change subject: IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2. .. Patch Set 4: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4258/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a73f5eeac8e84d63b22aaed5dfbcd8ea39f0af4 Gerrit-Change-Number: 14043 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Thu, 15 Aug 2019 10:29:21 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2.
Attila Jeges has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14043 ) Change subject: IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2. .. IMPALA-8842 part 1: Accommodate HIVE-22046 - Step 2. HIVE-22046 added 'engine' column to TAB_COL_STATS and PART_COL_STATS HMS tables. The new column is used to differentiate among column stats computed by different engines. The related HMS API calls were changed accordingly. This change is Step 2 in a series of steps to coordinate the introduction of HMS API changes to Hive and Impala: 1. Change in Hive. We push new APIs so Impala can use them. New APIs will simply call old existing methods so there should not be any change of functionality there. Since there were many incompatible changes, new APIs are tagged method_name_V2. 2. Change in Impala. Push changes to use new methods *V2. 3. Change in Hive Push patch with complete functionality. *V2 methods contains the new logic. The old existing methods are not used anymore by Impala at this point, hence they can be removed. For every method_name_V2, I will create a corresponding method method_name that calls the former one. 4. Change in Impala Replace *V2 calls by *. 5. Change in Hive. Remove *V2 methods from API. This change also adds exclusions to fe/pom.xml and shaded-deps/pom.xml to work around the hive hadoop2 dependency. Change-Id: I9a73f5eeac8e84d63b22aaed5dfbcd8ea39f0af4 --- M bin/impala-config.sh M fe/pom.xml M fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java M fe/src/main/java/org/apache/impala/catalog/Table.java M fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java M shaded-deps/pom.xml 9 files changed, 106 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/14043/4 -- To view, visit http://gerrit.cloudera.org:8080/14043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9a73f5eeac8e84d63b22aaed5dfbcd8ea39f0af4 Gerrit-Change-Number: 14043 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins
