[Impala-ASF-CR] IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds

2019-09-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14213 )

Change subject: IMPALA-8940: Fix 
MetastoreEventsProcessorTest.testPartitionEvents in CDP builds
..


Patch Set 3: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/14213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie93e7237944142f616a80dec675280b397fe5995
Gerrit-Change-Number: 14213
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Thu, 12 Sep 2019 13:15:37 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds

2019-09-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/14213 )

Change subject: IMPALA-8940: Fix 
MetastoreEventsProcessorTest.testPartitionEvents in CDP builds
..

IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds

The problem was caused by "numFilesErasureCoded" property, which does
not exist in CDP builds, and trivial event filtering only skipped
events where a "trivial" property was changed, but not when it was
added.

Change-Id: Ie93e7237944142f616a80dec675280b397fe5995
Reviewed-on: http://gerrit.cloudera.org:8080/14213
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/14213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie93e7237944142f616a80dec675280b397fe5995
Gerrit-Change-Number: 14213
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds

2019-09-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14213 )

Change subject: IMPALA-8940: Fix 
MetastoreEventsProcessorTest.testPartitionEvents in CDP builds
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4552/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie93e7237944142f616a80dec675280b397fe5995
Gerrit-Change-Number: 14213
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Thu, 12 Sep 2019 09:44:29 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds

2019-09-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14213 )

Change subject: IMPALA-8940: Fix 
MetastoreEventsProcessorTest.testPartitionEvents in CDP builds
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/14213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie93e7237944142f616a80dec675280b397fe5995
Gerrit-Change-Number: 14213
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Thu, 12 Sep 2019 09:04:55 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds

2019-09-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14213 )

Change subject: IMPALA-8940: Fix 
MetastoreEventsProcessorTest.testPartitionEvents in CDP builds
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4942/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/14213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie93e7237944142f616a80dec675280b397fe5995
Gerrit-Change-Number: 14213
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Thu, 12 Sep 2019 09:04:56 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds

2019-09-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14213 )

Change subject: IMPALA-8940: Fix 
MetastoreEventsProcessorTest.testPartitionEvents in CDP builds
..


Patch Set 2: Code-Review+2

(1 comment)

Carry +2

http://gerrit.cloudera.org:8080/#/c/14213/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java:

http://gerrit.cloudera.org:8080/#/c/14213/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1382
PS1, Line 1382: if (val == null) {
> nit: formatting, don't think we use single line if else
Done



--
To view, visit http://gerrit.cloudera.org:8080/14213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie93e7237944142f616a80dec675280b397fe5995
Gerrit-Change-Number: 14213
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Csaba Ringhofer 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Thu, 12 Sep 2019 09:04:00 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds

2019-09-12 Thread Csaba Ringhofer (Code Review)
Hello Bharath Vissapragada, Anurag Mantripragada, Vihang Karajgaonkar, Alex 
Behm, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14213

to look at the new patch set (#2).

Change subject: IMPALA-8940: Fix 
MetastoreEventsProcessorTest.testPartitionEvents in CDP builds
..

IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds

The problem was caused by "numFilesErasureCoded" property, which does
not exist in CDP builds, and trivial event filtering only skipped
events where a "trivial" property was changed, but not when it was
added.

Change-Id: Ie93e7237944142f616a80dec675280b397fe5995
---
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/14213/2
--
To view, visit http://gerrit.cloudera.org:8080/14213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie93e7237944142f616a80dec675280b397fe5995
Gerrit-Change-Number: 14213
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds

2019-09-11 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14213 )

Change subject: IMPALA-8940: Fix 
MetastoreEventsProcessorTest.testPartitionEvents in CDP builds
..


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14213/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java:

http://gerrit.cloudera.org:8080/#/c/14213/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1382
PS1, Line 1382: if (val == null) parametersAfter.remove(parameter);
nit: formatting, don't think we use single line if else



--
To view, visit http://gerrit.cloudera.org:8080/14213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie93e7237944142f616a80dec675280b397fe5995
Gerrit-Change-Number: 14213
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 11 Sep 2019 16:53:31 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds

2019-09-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14213 )

Change subject: IMPALA-8940: Fix 
MetastoreEventsProcessorTest.testPartitionEvents in CDP builds
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/4540/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/14213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie93e7237944142f616a80dec675280b397fe5995
Gerrit-Change-Number: 14213
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 11 Sep 2019 15:29:40 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds

2019-09-11 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14213 )

Change subject: IMPALA-8940: Fix 
MetastoreEventsProcessorTest.testPartitionEvents in CDP builds
..


Patch Set 1: Code-Review+1

Thanks for making this change Csaba. Looks good to me. I will add Bharath to 
reviewers list as Vihang is away.


--
To view, visit http://gerrit.cloudera.org:8080/14213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie93e7237944142f616a80dec675280b397fe5995
Gerrit-Change-Number: 14213
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer 
Gerrit-Reviewer: Anurag Mantripragada 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Wed, 11 Sep 2019 14:58:07 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds

2019-09-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/14213


Change subject: IMPALA-8940: Fix 
MetastoreEventsProcessorTest.testPartitionEvents in CDP builds
..

IMPALA-8940: Fix MetastoreEventsProcessorTest.testPartitionEvents in CDP builds

The problem was caused by "numFilesErasureCoded" property, which does
not exist in CDP builds, and trivial event filtering only skipped
events where a "trivial" property was changed, but not when it was
added.

Change-Id: Ie93e7237944142f616a80dec675280b397fe5995
---
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/14213/1
--
To view, visit http://gerrit.cloudera.org:8080/14213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie93e7237944142f616a80dec675280b397fe5995
Gerrit-Change-Number: 14213
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer