[Impala-ASF-CR] IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14290 ) Change subject: IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/14290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7acdd40c63166cd4986e546a992c0816f94823d5 Gerrit-Change-Number: 14290 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 25 Sep 2019 16:58:13 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14290 ) Change subject: IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations .. IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations Grouping aggregator always tried to serialize the 0th tuple regardless of the aggregation index. This could lead to a segmentation fault because the 0th tuple might be null. Testing: Added a query that triggers the error to multiple-distinct-aggs.test Change-Id: I7acdd40c63166cd4986e546a992c0816f94823d5 Reviewed-on: http://gerrit.cloudera.org:8080/14290 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins --- M be/src/exec/grouping-aggregator-ir.cc M testdata/workloads/functional-query/queries/QueryTest/multiple-distinct-aggs.test 2 files changed, 18 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7acdd40c63166cd4986e546a992c0816f94823d5 Gerrit-Change-Number: 14290 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall
[Impala-ASF-CR] IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14290 ) Change subject: IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4998/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7acdd40c63166cd4986e546a992c0816f94823d5 Gerrit-Change-Number: 14290 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 25 Sep 2019 12:44:59 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14290 ) Change subject: IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4997/ -- To view, visit http://gerrit.cloudera.org:8080/14290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7acdd40c63166cd4986e546a992c0816f94823d5 Gerrit-Change-Number: 14290 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 25 Sep 2019 12:41:49 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14290 ) Change subject: IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4997/ DRY_RUN=false -- To view, visit http://gerrit.cloudera.org:8080/14290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7acdd40c63166cd4986e546a992c0816f94823d5 Gerrit-Change-Number: 14290 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 25 Sep 2019 08:28:42 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14290 ) Change subject: IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7acdd40c63166cd4986e546a992c0816f94823d5 Gerrit-Change-Number: 14290 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Wed, 25 Sep 2019 08:28:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14290 ) Change subject: IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7acdd40c63166cd4986e546a992c0816f94823d5 Gerrit-Change-Number: 14290 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 24 Sep 2019 17:17:57 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14290 ) Change subject: IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4622/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7acdd40c63166cd4986e546a992c0816f94823d5 Gerrit-Change-Number: 14290 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-Comment-Date: Tue, 24 Sep 2019 10:59:54 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14290 Change subject: IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations .. IMPALA-8969: Grouping aggregator can cause segmentation fault when doing multiple aggregations Grouping aggregator always tried to serialize the 0th tuple regardless of the aggregation index. This could lead to a segmentation fault because the 0th tuple might be null. Testing: Added a query that triggers the error to multiple-distinct-aggs.test Change-Id: I7acdd40c63166cd4986e546a992c0816f94823d5 --- M be/src/exec/grouping-aggregator-ir.cc M testdata/workloads/functional-query/queries/QueryTest/multiple-distinct-aggs.test 2 files changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/14290/1 -- To view, visit http://gerrit.cloudera.org:8080/14290 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7acdd40c63166cd4986e546a992c0816f94823d5 Gerrit-Change-Number: 14290 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy
