[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. IMPALA-9010: Add builtin mask functions There're 6 builtin

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-16 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 12: Code-Review+2 Carrying on +2 of Zoltan -- To view, visit

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-16 Thread Quanlong Huang (Code Review)
Hello Fang-Yu Rao, Norbert Luksa, Kurt Deschler, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14963 to look at the new patch set (#12). Change subject: IMPALA-9010: Add builtin mask functions

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 11: Code-Review+2 (1 comment) LGTM

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 11: Build Failed

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-15 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 11: (2 comments) The UBSAN test don't allow me to test on

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-15 Thread Quanlong Huang (Code Review)
Hello Fang-Yu Rao, Norbert Luksa, Kurt Deschler, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14963 to look at the new patch set (#11). Change subject: IMPALA-9010: Add builtin mask functions

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 10: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-15 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 10: Code-Review+1 (2 comments) Code looks good.

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 9: Build Successful

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-15 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 10: Sorry for the GVO failures. I made a mistake that

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-15 Thread Quanlong Huang (Code Review)
Hello Fang-Yu Rao, Norbert Luksa, Kurt Deschler, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14963 to look at the new patch set (#10). Change subject: IMPALA-9010: Add builtin mask functions

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-15 Thread Quanlong Huang (Code Review)
Hello Fang-Yu Rao, Norbert Luksa, Kurt Deschler, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14963 to look at the new patch set (#9). Change subject: IMPALA-9010: Add builtin mask functions

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 8: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-14 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 7: Code-Review+2 Carry on Zoltan's +2 and Fang-Yu's +1. -- To

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-14 Thread Quanlong Huang (Code Review)
Hello Fang-Yu Rao, Norbert Luksa, Kurt Deschler, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14963 to look at the new patch set (#7). Change subject: IMPALA-9010: Add builtin mask functions

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-14 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-12 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 5: Code-Review+1 (4 comments) Thanks Quanlong for your patience

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-12 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 5: Edited the commit message based on Fang-Yu's offline

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-12 Thread Quanlong Huang (Code Review)
Hello Fang-Yu Rao, Norbert Luksa, Kurt Deschler, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14963 to look at the new patch set (#5). Change subject: IMPALA-9010: Add builtin mask functions

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-12 Thread Quanlong Huang (Code Review)
Hello Fang-Yu Rao, Norbert Luksa, Kurt Deschler, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14963 to look at the new patch set (#4). Change subject: IMPALA-9010: Add builtin mask functions

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-09 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 2: (10 comments) Thanks for your coments! Addressed them.

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-09 Thread Quanlong Huang (Code Review)
Hello Fang-Yu Rao, Norbert Luksa, Kurt Deschler, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14963 to look at the new patch set (#3). Change subject: IMPALA-9010: Add builtin mask functions

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-08 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-08 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-08 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-08 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-07 Thread Norbert Luksa (Code Review)
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 2: Code-Review+1 (4 comments) That seems a lot of work, nice

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-07 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 2: (9 comments) Thank Zoltan! Addressed the comments.

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-07 Thread Quanlong Huang (Code Review)
Hello Fang-Yu Rao, Norbert Luksa, Kurt Deschler, Zoltan Borok-Nagy, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14963 to look at the new patch set (#2). Change subject: IMPALA-9010: Add builtin mask functions

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2020-01-06 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 1: Code-Review+1 (9 comments) Great work, found a couple of

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2019-12-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14963 ) Change subject: IMPALA-9010: Add builtin mask functions .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9010: Add builtin mask functions

2019-12-31 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14963 Change subject: IMPALA-9010: Add builtin mask functions .. IMPALA-9010: Add builtin mask functions There're 6 builtin GenericUDFs for