[Impala-ASF-CR] IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() method

2020-06-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16121 )

Change subject: IMPALA-9907: Fix NullPointerException in 
ParallelFileMetadataLoader's load() method
..


Patch Set 4: Verified+1


--
To view, visit http://gerrit.cloudera.org:8080/16121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 30 Jun 2020 19:33:23 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() method

2020-06-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/16121 )

Change subject: IMPALA-9907: Fix NullPointerException in 
ParallelFileMetadataLoader's load() method
..

IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() 
method

ParallelFileMetadataLoader.loaders_ became a Map, but at one place we
still treat it as a List:

  loaders_.get(i).getPartDir()

'i' is an integer, while the loaders_'s key type is Path.

Unfortunately the code compiled which means we got a
NullPointerException for this statement. I changed the logic to avoid
the NPE.

Testing:

  * Tested manually on an ACID table with deleted rows
  * I didn't add an automated test because I'm about to extend the ACID
functionalities, hence getting rid of these exceptions
  * The other case when we can hit this NPE is when we get an
IOException in the file metadata loader's load() method

Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Reviewed-on: http://gerrit.cloudera.org:8080/16121
Reviewed-by: Impala Public Jenkins 
Tested-by: Impala Public Jenkins 
---
M fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java
1 file changed, 7 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/16121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 


[Impala-ASF-CR] IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() method

2020-06-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16121 )

Change subject: IMPALA-9907: Fix NullPointerException in 
ParallelFileMetadataLoader's load() method
..


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6079/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/16121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 30 Jun 2020 14:33:18 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() method

2020-06-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16121 )

Change subject: IMPALA-9907: Fix NullPointerException in 
ParallelFileMetadataLoader's load() method
..


Patch Set 4: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 30 Jun 2020 14:33:17 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() method

2020-06-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16121 )

Change subject: IMPALA-9907: Fix NullPointerException in 
ParallelFileMetadataLoader's load() method
..


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6077/


-- 
To view, visit http://gerrit.cloudera.org:8080/16121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 30 Jun 2020 13:32:40 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() method

2020-06-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16121 )

Change subject: IMPALA-9907: Fix NullPointerException in 
ParallelFileMetadataLoader's load() method
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16121/1/fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java
File fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java:

http://gerrit.cloudera.org:8080/#/c/16121/1/fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java@166
PS1, Line 166: loader,
 : pool.submit(() -> { loader.load(); return null; })));
> nit, can be moved to earlier line.
Done



--
To view, visit http://gerrit.cloudera.org:8080/16121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 30 Jun 2020 12:57:44 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() method

2020-06-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16121 )

Change subject: IMPALA-9907: Fix NullPointerException in 
ParallelFileMetadataLoader's load() method
..


Patch Set 2:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/6463/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/16121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 30 Jun 2020 08:44:53 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() method

2020-06-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16121 )

Change subject: IMPALA-9907: Fix NullPointerException in 
ParallelFileMetadataLoader's load() method
..


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6077/ 
DRY_RUN=false


--
To view, visit http://gerrit.cloudera.org:8080/16121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 30 Jun 2020 08:28:57 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() method

2020-06-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16121 )

Change subject: IMPALA-9907: Fix NullPointerException in 
ParallelFileMetadataLoader's load() method
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/16121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 30 Jun 2020 08:28:56 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() method

2020-06-30 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16121 )

Change subject: IMPALA-9907: Fix NullPointerException in 
ParallelFileMetadataLoader's load() method
..


Patch Set 2: Code-Review+2

Carrying +2


--
To view, visit http://gerrit.cloudera.org:8080/16121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Reviewer: Zoltan Borok-Nagy 
Gerrit-Comment-Date: Tue, 30 Jun 2020 08:28:39 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() method

2020-06-30 Thread Zoltan Borok-Nagy (Code Review)
Hello Vihang Karajgaonkar, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/16121

to look at the new patch set (#2).

Change subject: IMPALA-9907: Fix NullPointerException in 
ParallelFileMetadataLoader's load() method
..

IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() 
method

ParallelFileMetadataLoader.loaders_ became a Map, but at one place we
still treat it as a List:

  loaders_.get(i).getPartDir()

'i' is an integer, while the loaders_'s key type is Path.

Unfortunately the code compiled which means we got a
NullPointerException for this statement. I changed the logic to avoid
the NPE.

Testing:

  * Tested manually on an ACID table with deleted rows
  * I didn't add an automated test because I'm about to extend the ACID
functionalities, hence getting rid of these exceptions
  * The other case when we can hit this NPE is when we get an
IOException in the file metadata loader's load() method

Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
---
M fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/16121/2
--
To view, visit http://gerrit.cloudera.org:8080/16121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 


[Impala-ASF-CR] IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() method

2020-06-29 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16121 )

Change subject: IMPALA-9907: Fix NullPointerException in 
ParallelFileMetadataLoader's load() method
..


Patch Set 1: Code-Review+2

(1 comment)

Thanks for fixing this.

http://gerrit.cloudera.org:8080/#/c/16121/1/fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java
File fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java:

http://gerrit.cloudera.org:8080/#/c/16121/1/fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java@166
PS1, Line 166: loader,
 : pool.submit(() -> { loader.load(); return null; })));
nit, can be moved to earlier line.



--
To view, visit http://gerrit.cloudera.org:8080/16121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Mon, 29 Jun 2020 17:36:57 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() method

2020-06-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16121 )

Change subject: IMPALA-9907: Fix NullPointerException in 
ParallelFileMetadataLoader's load() method
..


Patch Set 1:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/6450/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/16121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Vihang Karajgaonkar 
Gerrit-Comment-Date: Mon, 29 Jun 2020 16:05:51 +
Gerrit-HasComments: No


[Impala-ASF-CR] IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() method

2020-06-29 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/16121


Change subject: IMPALA-9907: Fix NullPointerException in 
ParallelFileMetadataLoader's load() method
..

IMPALA-9907: Fix NullPointerException in ParallelFileMetadataLoader's load() 
method

ParallelFileMetadataLoader.loaders_ became a Map, but at one place we
still treat it as a List:

  loaders_.get(i).getPartDir()

'i' is an integer, while the loaders_'s key type is Path.

Unfortunately the code compiled which means we got a
NullPointerException for this statement. I changed the logic to avoid
the NPE.

Testing:

  * Tested manually on an ACID table with deleted rows
  * I didn't add an automated test because I'm about to extend the ACID
functionalities, hence getting rid of these exceptions
  * The other case when we can hit this NPE is when we get an
IOException in the file metadata loader's load() method

Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
---
M fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java
1 file changed, 8 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/16121/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16121
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4322a18a1f07e4106789591b80d25105c565a2b6
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy