[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. IMPALA-9980: Remove jersey* jars from maven exclusions IMPALA-9679 added jersey* jars to maven exclusions. These jars are required by Impala Ranger plugin to instantiate RuntimeDelegateImpl As a result of the exclusions, ClassNotFound exceptions are thrown in Impala docker containers when ranger plugin is enabled. This change removes jersey-bundle exclusion from Ranger dependency. Testing: - Built and ran Impala containers locally with ranger enabled. - Ran dockerized tests in precommit. Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 Reviewed-on: http://gerrit.cloudera.org:8080/16225 Tested-by: Impala Public Jenkins Reviewed-by: Tim Armstrong --- M fe/pom.xml 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 Gerrit-Change-Number: 16225 Gerrit-PatchSet: 3 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/16225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 Gerrit-Change-Number: 16225 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 21 Jul 2020 16:20:46 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/16225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 Gerrit-Change-Number: 16225 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 21 Jul 2020 10:17:40 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6676/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 Gerrit-Change-Number: 16225 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 21 Jul 2020 05:10:41 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6151/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/16225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 Gerrit-Change-Number: 16225 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 21 Jul 2020 05:09:58 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 2: Makes sense. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/16225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 Gerrit-Change-Number: 16225 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 21 Jul 2020 05:09:39 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 2: I think it would be better to just include jersey-bundle if that's what Ranger is depending on - that way at least the version will line up with what ranger is expecting. -- To view, visit http://gerrit.cloudera.org:8080/16225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 Gerrit-Change-Number: 16225 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 21 Jul 2020 04:54:17 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 2: Could we just add jersey-server.jar and jersey-servlet.jar since these were the missing jars instead of the jersey-bundle which seems to be a large jar? -- To view, visit http://gerrit.cloudera.org:8080/16225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 Gerrit-Change-Number: 16225 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 21 Jul 2020 04:53:16 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 2: (1 comment) Instead of removing all jersey* exclusions, just removing the jersey-bundle dependency from ranger worked in my local testing. I will look into why our dockerized tests did not catch this. http://gerrit.cloudera.org:8080/#/c/16225/1/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/16225/1/fe/pom.xml@189 PS1, Line 189: rocksdbjni > This doesn't make a lot of sense to me - if the problem is with Ranger, why The original idea was to revert parts of IMPALA-9679 but I missed this exclusion in Ranger dependency. Instead of reverting all jeresey* changes, just removing this exclusion also worked in my local testing. Do you think it is a good idea? -- To view, visit http://gerrit.cloudera.org:8080/16225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 Gerrit-Change-Number: 16225 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Anurag Mantripragada Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 21 Jul 2020 04:49:16 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions
Anurag Mantripragada has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. IMPALA-9980: Remove jersey* jars from maven exclusions IMPALA-9679 added jersey* jars to maven exclusions. These jars are required by Impala Ranger plugin to instantiate RuntimeDelegateImpl As a result of the exclusions, ClassNotFound exceptions are thrown in Impala docker containers when ranger plugin is enabled. This change removes jersey-bundle exclusion from Ranger dependency. Testing: - Built and ran Impala containers locally with ranger enabled. - Ran dockerized tests in precommit. Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 --- M fe/pom.xml 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/16225/2 -- To view, visit http://gerrit.cloudera.org:8080/16225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 Gerrit-Change-Number: 16225 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong
[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 1: (1 comment) What was the test gap? Why didn't our ranger tests catch this? How are we meant to prevent this regressing in future? http://gerrit.cloudera.org:8080/#/c/16225/1/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/16225/1/fe/pom.xml@189 PS1, Line 189: jersey-bundle This doesn't make a lot of sense to me - if the problem is with Ranger, why are we removing exclusions from non-Ranger dependencies and leaving the exclusion for ranger? -- To view, visit http://gerrit.cloudera.org:8080/16225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 Gerrit-Change-Number: 16225 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Tim Armstrong Gerrit-Comment-Date: Tue, 21 Jul 2020 03:20:36 + Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/6674/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/16225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 Gerrit-Change-Number: 16225 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 21 Jul 2020 03:16:36 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16225 ) Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6150/ DRY_RUN=true -- To view, visit http://gerrit.cloudera.org:8080/16225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 Gerrit-Change-Number: 16225 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada Gerrit-Reviewer: Fang-Yu Rao Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Comment-Date: Tue, 21 Jul 2020 02:49:52 + Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9980: Remove jersey* jars from maven exclusions
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16225 Change subject: IMPALA-9980: Remove jersey* jars from maven exclusions .. IMPALA-9980: Remove jersey* jars from maven exclusions IMPALA-9679 added jersey* jars to maven exclusions. These jars are required by Impala Ranger plugin to instantiate RuntimeDelegateImpl As a result of the exclusions, ClassNotFound exceptions are thrown in Impala docker containers when ranger plugin is enabled. This change removes jersey-server.jar and jersey-servlet.jar from exclusions. Testing: Ran dockerized tests in precommit. Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 --- M fe/pom.xml 1 file changed, 0 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/16225/1 -- To view, visit http://gerrit.cloudera.org:8080/16225 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I796a9ff4c1beff776147266c2f2649c2d02a8dd8 Gerrit-Change-Number: 16225 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada
