[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. KUDU-2004. Undefined behavior in TlsSocket::Writev() TlsSocket::Writev() was attempting to use the value of nwritten from TlsSocket::Write(), but in the case of an error that value was never set or initialized. A simple check to make sure the result from TlsSocket::Write() wasn't an error was added, otherwise we break out of the write loop to cleanup and return the error (thus skipping the line that uses nwritten) Dist job result from before the fix: http://dist-test.cloudera.org/job?job_id=efan.1496860112.16151 Dist job result from after the fix: http://dist-test.cloudera.org/job?job_id=efan.1497036430.19311 Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Reviewed-on: http://gerrit.cloudera.org:8080/7141 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy Reviewed-on: http://gerrit.cloudera.org:8080/9359 Reviewed-by: Sailesh Mukil Tested-by: Impala Public Jenkins --- M be/src/kudu/security/tls_socket.cc M be/src/kudu/util/net/socket.h 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Sailesh Mukil: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Gerrit-Change-Number: 9359 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Edward Fancher Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Sailesh Mukil
[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Gerrit-Change-Number: 9359 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Edward Fancher Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Tue, 20 Feb 2018 09:03:22 + Gerrit-HasComments: No
[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1956/ -- To view, visit http://gerrit.cloudera.org:8080/9359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Gerrit-Change-Number: 9359 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Edward Fancher Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Tue, 20 Feb 2018 05:26:25 + Gerrit-HasComments: No
[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 1: GVO failed due to infrastructure issue (IMPALA-6394) -- To view, visit http://gerrit.cloudera.org:8080/9359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Gerrit-Change-Number: 9359 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Edward Fancher Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Tue, 20 Feb 2018 05:25:35 + Gerrit-HasComments: No
[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1955/ -- To view, visit http://gerrit.cloudera.org:8080/9359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Gerrit-Change-Number: 9359 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Edward Fancher Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Tue, 20 Feb 2018 04:12:44 + Gerrit-HasComments: No
[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1955/ -- To view, visit http://gerrit.cloudera.org:8080/9359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Gerrit-Change-Number: 9359 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Edward Fancher Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Tue, 20 Feb 2018 00:30:05 + Gerrit-HasComments: No
[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Gerrit-Change-Number: 9359 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Edward Fancher Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Tue, 20 Feb 2018 00:18:13 + Gerrit-HasComments: No
[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Patch Set 1: Clean application of the original patch. -- To view, visit http://gerrit.cloudera.org:8080/9359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Gerrit-Change-Number: 9359 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Edward Fancher Gerrit-Reviewer: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Sailesh Mukil Gerrit-Comment-Date: Mon, 19 Feb 2018 22:37:56 + Gerrit-HasComments: No
[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()
Hello Mike Percy, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9359 to review the following change. Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. KUDU-2004. Undefined behavior in TlsSocket::Writev() TlsSocket::Writev() was attempting to use the value of nwritten from TlsSocket::Write(), but in the case of an error that value was never set or initialized. A simple check to make sure the result from TlsSocket::Write() wasn't an error was added, otherwise we break out of the write loop to cleanup and return the error (thus skipping the line that uses nwritten) Dist job result from before the fix: http://dist-test.cloudera.org/job?job_id=efan.1496860112.16151 Dist job result from after the fix: http://dist-test.cloudera.org/job?job_id=efan.1497036430.19311 Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Reviewed-on: http://gerrit.cloudera.org:8080/7141 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy --- M be/src/kudu/security/tls_socket.cc M be/src/kudu/util/net/socket.h 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/9359/1 -- To view, visit http://gerrit.cloudera.org:8080/9359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Gerrit-Change-Number: 9359 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Edward Fancher Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[Impala-ASF-CR] KUDU-2004. Undefined behavior in TlsSocket::Writev()
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9359 ) Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() .. Removed reviewer Kudu Jenkins. -- To view, visit http://gerrit.cloudera.org:8080/9359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Gerrit-Change-Number: 9359 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho Gerrit-Reviewer: Edward Fancher Gerrit-Reviewer: Mike Percy
