[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23967 )

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..


Patch Set 8:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/21701/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Thu, 19 Feb 2026 02:38:06 +
Gerrit-HasComments: No


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-18 Thread Joe McDonnell (Code Review)
Hello Michael Smith, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/23967

to look at the new patch set (#8).

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..

PROTOTYPE: Remove the Python 2 impala-python virtualenv

Previous changes stopped building the Python 2 impala-python
virtualenv, but the code is still around and in theory could
be revived. Since Python 2 is dead, this removes that support
and simplifies the code. py2-requirements.txt is removed.
py3-requirements.txt is folded back into requirements.txt.
This removes scripts that depended on the Python 2 virtualenv.
This removes pylint as it was only being used for the py3k
check, which is no longer necessary. This keeps isort separately.

Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
---
M CMakeLists.txt
M bin/bootstrap_toolchain.py
D bin/check-pylint-py3k.sh
M bin/check-python-syntax.sh
M bin/cmake_aux/create_virtualenv.sh
M bin/impala-config.sh
D bin/impala-env-versioned-python
D bin/impala-futurize
D bin/impala-pip
M bin/impala-py.test
D bin/impala-pylint
D bin/impala-python
D bin/impala-python-common.sh
M bin/impala-python3-common.sh
M bin/impala-shell.sh
D bin/impala-virtualenv
M bin/init-impala-python.sh
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/pip_download.py
D infra/python/deps/py2-requirements.txt
D infra/python/deps/py3-requirements.txt
M infra/python/deps/requirements.txt
M shell/CMakeLists.txt
M shell/packaging/make_shell_tarball.sh
M tests/common/network.py
M tests/custom_cluster/test_client_ssl.py
M tests/custom_cluster/test_thrift_socket.py
M tests/run-tests.py
M tests/shell/test_shell_commandline.py
M tests/shell/test_shell_interactive.py
M tests/shell/util.py
31 files changed, 85 insertions(+), 697 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/23967/8
--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23967 )

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..


Patch Set 6:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/21656/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Sun, 15 Feb 2026 21:17:58 +
Gerrit-HasComments: No


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-15 Thread Joe McDonnell (Code Review)
Hello Michael Smith, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/23967

to look at the new patch set (#6).

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..

PROTOTYPE: Remove the Python 2 impala-python virtualenv

Previous changes stopped building the Python 2 impala-python
virtualenv, but the code is still around and in theory could
be revived. Since Python 2 is dead, this removes that support
and simplifies the code. py2-requirements.txt is removed.
py3-requirements.txt is folded back into requirements.txt.
This removes scripts that depended on the Python 2 virtualenv.
This removes pylint as it was only being used for the py3k
check, which is no longer necessary. This keeps isort separately.

Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
---
M CMakeLists.txt
D bin/check-pylint-py3k.sh
M bin/cmake_aux/create_virtualenv.sh
D bin/impala-env-versioned-python
D bin/impala-futurize
D bin/impala-pip
M bin/impala-py.test
D bin/impala-pylint
D bin/impala-python
D bin/impala-python-common.sh
D bin/impala-virtualenv
M bin/init-impala-python.sh
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/pip_download.py
D infra/python/deps/py2-requirements.txt
D infra/python/deps/py3-requirements.txt
M infra/python/deps/requirements.txt
M shell/CMakeLists.txt
M tests/run-tests.py
19 files changed, 71 insertions(+), 572 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/23967/6
--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23967 )

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..


Patch Set 5:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/21654/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Sun, 15 Feb 2026 20:46:37 +
Gerrit-HasComments: No


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-15 Thread Joe McDonnell (Code Review)
Hello Michael Smith, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/23967

to look at the new patch set (#5).

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..

PROTOTYPE: Remove the Python 2 impala-python virtualenv

Previous changes stopped building the Python 2 impala-python
virtualenv, but the code is still around and in theory could
be revived. Since Python 2 is dead, this removes that support
and simplifies the code. py2-requirements.txt is removed.
py3-requirements.txt is folded back into requirements.txt.
This removes scripts that depended on the Python 2 virtualenv.
This removes pylint as it was only being used for the py3k
check, which is no longer necessary. This keeps isort separately.

Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
---
M CMakeLists.txt
D bin/check-pylint-py3k.sh
M bin/cmake_aux/create_virtualenv.sh
D bin/impala-env-versioned-python
D bin/impala-futurize
D bin/impala-pip
M bin/impala-py.test
D bin/impala-pylint
D bin/impala-python
D bin/impala-python-common.sh
D bin/impala-virtualenv
M bin/init-impala-python.sh
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/pip_download.py
D infra/python/deps/py2-requirements.txt
D infra/python/deps/py3-requirements.txt
M infra/python/deps/requirements.txt
M shell/CMakeLists.txt
M tests/run-tests.py
19 files changed, 70 insertions(+), 572 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/23967/5
--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23967 )

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/23967/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23967/3//COMMIT_MSG@13
PS3, Line 13: py3-requirements.txt is folded back into requirements.txt.
> Yeah, all of this is with the toolchain Python 3.8, so it should be the sam
Ok, here is what I think is happening:
py2-requirements.txt had references to pyflakes, mccabe, and pycodestyle. We 
download all of those along with the other packages from other requirements.txt 
files. Even though they aren't specified in the py3-requirements.txt, they are 
available locally, and pip can find them. When I removed py2-requirements.txt, 
those were no longer being downloaded and things broke.

Very weird setup, but that explains why I had to add those dependencies for 
flake8.


http://gerrit.cloudera.org:8080/#/c/23967/3/infra/python/deps/requirements.txt
File infra/python/deps/requirements.txt:

http://gerrit.cloudera.org:8080/#/c/23967/3/infra/python/deps/requirements.txt@55
PS3, Line 55: futures == 3.3.0; python_version == "2.7"
> Do we still need this?
Removed


http://gerrit.cloudera.org:8080/#/c/23967/3/infra/python/deps/requirements.txt@83
PS3, Line 83: virtualenv == 16.7.10
Also removed this



--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Fri, 13 Feb 2026 01:32:59 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23967 )

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..


Patch Set 4:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/21648/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Fri, 13 Feb 2026 01:02:15 +
Gerrit-HasComments: No


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-12 Thread Joe McDonnell (Code Review)
Hello Michael Smith, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/23967

to look at the new patch set (#4).

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..

PROTOTYPE: Remove the Python 2 impala-python virtualenv

Previous changes stopped building the Python 2 impala-python
virtualenv, but the code is still around and in theory could
be revived. Since Python 2 is dead, this removes that support
and simplifies the code. py2-requirements.txt is removed.
py3-requirements.txt is folded back into requirements.txt.
This removes scripts that depended on the Python 2 virtualenv.

Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
---
M CMakeLists.txt
M bin/cmake_aux/create_virtualenv.sh
D bin/impala-env-versioned-python
D bin/impala-futurize
D bin/impala-pip
M bin/impala-py.test
D bin/impala-python
D bin/impala-python-common.sh
D bin/impala-virtualenv
M bin/init-impala-python.sh
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/pip_download.py
D infra/python/deps/py2-requirements.txt
D infra/python/deps/py3-requirements.txt
M infra/python/deps/requirements.txt
M shell/CMakeLists.txt
M tests/run-tests.py
17 files changed, 80 insertions(+), 414 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/23967/4
--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23967 )

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23967/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23967/3//COMMIT_MSG@13
PS3, Line 13: py3-requirements.txt is folded back into requirements.txt.
> I guess it should be the impala-python 3.8.
Yeah, all of this is with the toolchain Python 3.8, so it should be the same as 
before.



--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Joe McDonnell 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Thu, 12 Feb 2026 17:35:03 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-12 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23967 )

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23967/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23967/3//COMMIT_MSG@13
PS3, Line 13: py3-requirements.txt is folded back into requirements.txt.
> If versions changed, what versions of Python 3 did you validate with? I've
I guess it should be the impala-python 3.8.



--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Thu, 12 Feb 2026 17:04:13 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-12 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23967 )

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23967/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23967/3//COMMIT_MSG@13
PS3, Line 13: py3-requirements.txt is folded back into requirements.txt.
If versions changed, what versions of Python 3 did you validate with? I've seen 
projects add python >= 3.6, python >= 3.7, etc dependencies that could make 
them sensitive.


http://gerrit.cloudera.org:8080/#/c/23967/3/infra/python/deps/requirements.txt
File infra/python/deps/requirements.txt:

http://gerrit.cloudera.org:8080/#/c/23967/3/infra/python/deps/requirements.txt@55
PS3, Line 55: futures == 3.3.0; python_version == "2.7"
Do we still need this?



--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Reviewer: Michael Smith 
Gerrit-Comment-Date: Thu, 12 Feb 2026 17:03:20 +
Gerrit-HasComments: Yes


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23967 )

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..


Patch Set 3:

Build Successful

https://jenkins.impala.io/job/gerrit-code-review-checks/21639/ : Initial code 
review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun 
to run full precommit tests.


--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Feb 2026 06:24:51 +
Gerrit-HasComments: No


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-11 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/23967

to look at the new patch set (#3).

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..

PROTOTYPE: Remove the Python 2 impala-python virtualenv

Previous changes stopped building the Python 2 impala-python
virtualenv, but the code is still around and in theory could
be revived. Since Python 2 is dead, this removes that support
and simplifies the code. py2-requirements.txt is removed.
py3-requirements.txt is folded back into requirements.txt.
This removes scripts that depended on the Python 2 virtualenv.

Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
---
M CMakeLists.txt
M bin/cmake_aux/create_virtualenv.sh
D bin/impala-env-versioned-python
D bin/impala-futurize
D bin/impala-pip
M bin/impala-py.test
D bin/impala-python
D bin/impala-python-common.sh
D bin/impala-virtualenv
M bin/init-impala-python.sh
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/pip_download.py
D infra/python/deps/py2-requirements.txt
D infra/python/deps/py3-requirements.txt
M infra/python/deps/requirements.txt
M shell/CMakeLists.txt
M tests/run-tests.py
17 files changed, 81 insertions(+), 413 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/23967/3
--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23967 )

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..


Patch Set 2:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/21637/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Feb 2026 03:20:34 +
Gerrit-HasComments: No


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-11 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/23967

to look at the new patch set (#2).

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..

PROTOTYPE: Remove the Python 2 impala-python virtualenv

Previous changes stopped building the Python 2 impala-python
virtualenv, but the code is still around and in theory could
be revived. Since Python 2 is dead, this removes that support
and simplifies the code. py2-requirements.txt is removed.
py3-requirements.txt is folded back into requirements.txt.
This removes scripts that depended on the Python 2 virtualenv.

Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
---
M CMakeLists.txt
M bin/cmake_aux/create_virtualenv.sh
D bin/impala-env-versioned-python
D bin/impala-futurize
D bin/impala-pip
M bin/impala-py.test
D bin/impala-python
D bin/impala-python-common.sh
D bin/impala-virtualenv
M bin/init-impala-python.sh
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/pip_download.py
D infra/python/deps/py2-requirements.txt
D infra/python/deps/py3-requirements.txt
M infra/python/deps/requirements.txt
M shell/CMakeLists.txt
M tests/run-tests.py
17 files changed, 81 insertions(+), 413 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/23967/2
--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23967 )

Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..


Patch Set 1:

Build Failed

https://jenkins.impala.io/job/gerrit-code-review-checks/21636/ : Initial code 
review checks failed. See linked job for details on the failure.


--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell 
Gerrit-Reviewer: Impala Public Jenkins 
Gerrit-Comment-Date: Thu, 12 Feb 2026 01:16:35 +
Gerrit-HasComments: No


[Impala-ASF-CR] PROTOTYPE: Remove the Python 2 impala-python virtualenv

2026-02-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/23967


Change subject: PROTOTYPE: Remove the Python 2 impala-python virtualenv
..

PROTOTYPE: Remove the Python 2 impala-python virtualenv

Previous changes stopped building the Python 2 impala-python
virtualenv, but the code is still around and in theory could
be revived. Since Python 2 is dead, this removes that support
and simplifies the code. py2-requirements.txt is removed.
py3-requirements.txt is folded back into requirements.txt.
This removes scripts that depended on the Python 2 virtualenv.

Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
---
M CMakeLists.txt
M bin/cmake_aux/create_virtualenv.sh
D bin/impala-env-versioned-python
D bin/impala-futurize
D bin/impala-pip
M bin/impala-py.test
D bin/impala-python
D bin/impala-python-common.sh
D bin/impala-virtualenv
M bin/init-impala-python.sh
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/pip_download.py
D infra/python/deps/py2-requirements.txt
D infra/python/deps/py3-requirements.txt
M infra/python/deps/requirements.txt
M shell/CMakeLists.txt
M tests/run-tests.py
17 files changed, 78 insertions(+), 413 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/23967/1
--
To view, visit http://gerrit.cloudera.org:8080/23967
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If28a8a0466614fc1d022e27c742dc3880509947a
Gerrit-Change-Number: 23967
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell