[Impala-ASF-CR] WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14043 ) Change subject: WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2. .. Patch Set 2: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4207/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a73f5eeac8e84d63b22aaed5dfbcd8ea39f0af4 Gerrit-Change-Number: 14043 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 09 Aug 2019 16:37:23 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2.
Attila Jeges has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14043 ) Change subject: WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2. .. WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2. HIVE-22046 added 'engine' column to TAB_COL_STATS and PART_COL_STATS HMS tables. The new column is used to differentiate among column stats computed by different engines. The related HMS API calls were changed accordingly. This change is Step 2 in a series of steps to coordinate the introduction of HMS API changes to Hive and Impala: 1. Change in Hive. We push new APIs so Impala can use them. New APIs will simply call old existing methods so there should not be any change of functionality there. Since there were many incompatible changes, new APIs are tagged method_name_V2. 2. Change in Impala. Push changes to use new methods *V2. 3. Change in Hive Push patch with complete functionality. *V2 methods contains the new logic. The old existing methods are not used anymore by Impala at this point, hence they can be removed. For every method_name_V2, I will create a corresponding method method_name that calls the former one. 4. Change in Impala Replace *V2 calls by *. 5. Change in Hive. Remove *V2 methods from API. This patch-set is in WIP state as Step 1 is not yet complete. TODO: Once Step 1 is complete, make the new build available to Impala via the native-toolchain. Update the CDP_BUILD_NUMBER and CDP_HIVE_VERSION environment variables in bin/impala-config.sh accordingly. Change-Id: I9a73f5eeac8e84d63b22aaed5dfbcd8ea39f0af4 --- M fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java M fe/src/main/java/org/apache/impala/catalog/Table.java M fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java 6 files changed, 90 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/14043/2 -- To view, visit http://gerrit.cloudera.org:8080/14043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9a73f5eeac8e84d63b22aaed5dfbcd8ea39f0af4 Gerrit-Change-Number: 14043 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14043 ) Change subject: WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/4206/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/14043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a73f5eeac8e84d63b22aaed5dfbcd8ea39f0af4 Gerrit-Change-Number: 14043 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Jeges Gerrit-Reviewer: Impala Public Jenkins Gerrit-Comment-Date: Fri, 09 Aug 2019 15:37:35 + Gerrit-HasComments: No
[Impala-ASF-CR] WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2.
Attila Jeges has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14043 Change subject: WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2. .. WIP: IMPALA-8842: Accommodate HIVE-22046 - Step 2. HIVE-22046 added 'engine' column to TAB_COL_STATS and PART_COL_STATS HMS tables. The new column is used to differentiate among column stats computed by different engines. The related HMS API calls were changed accordingly. This change is Step 2 in a series of steps to coordinate the introduction of HMS API changes to Hive and Impala: 1. Change in Hive. We push new APIs so Impala can use them. New APIs will simply call old existing methods so there should not be any change of functionality there. Since there were many incompatible changes, new APIs are tagged method_name_V2. 2. Change in Impala. Push changes to use new methods *V2. 3. Change in Hive Push patch with complete functionality. *V2 methods contains the new logic. The old existing methods are not used anymore by Impala at this point, hence they can be removed. For every method_name_V2, I will create a corresponding method method_name that calls the former one. 4. Change in Impala Replace *V2 calls by *. 5. Change in Hive. Remove *V2 methods from API. This patch-set is in WIP state as Step 1 is not yet complete. TODO: Once Step 1 is complete, make the new build available to Impala via the native-toolchain. Update the CDP_BUILD_NUMBER and CDP_HIVE_VERSION environment variables in bin/impala-config.sh accordingly. Change-Id: I9a73f5eeac8e84d63b22aaed5dfbcd8ea39f0af4 --- M fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java M fe/src/main/java/org/apache/impala/catalog/Table.java M fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java 6 files changed, 90 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/14043/1 -- To view, visit http://gerrit.cloudera.org:8080/14043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9a73f5eeac8e84d63b22aaed5dfbcd8ea39f0af4 Gerrit-Change-Number: 14043 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Jeges
