[Impala-ASF-CR] IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations

2017-08-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations .. Patch Set 6: Code-Review+1 This looks good to me. -- To view, visit

[Impala-ASF-CR] IMPALA-5681: release reservation from blocking operators

2017-08-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5681: release reservation from blocking operators .. IMPALA-5681: release reservation from blocking operators When an in-memory blocking aggregation or

[Impala-ASF-CR] IMPALA-5778: clarify --read size option.

2017-08-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7623 Change subject: IMPALA-5778: clarify --read_size option. .. IMPALA-5778: clarify --read_size option. Remove BTS_BLOCK_OVERFLOW error

[Impala-ASF-CR] IMPALA-1478: Improve error message when subquery is used in the ON clause

2017-08-08 Thread Pranay Singh (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7588 to look at the new patch set (#4). Change subject: IMPALA-1478: Improve error message when subquery is used in the ON clause

[Impala-ASF-CR] IMPALA-5652: deprecate unlimited process mem limit

2017-08-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7622 Change subject: IMPALA-5652: deprecate unlimited process mem_limit .. IMPALA-5652: deprecate unlimited process mem_limit Testing:

[Impala-ASF-CR] IMPALA-5652: deprecate unlimited process mem limit

2017-08-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5652: deprecate unlimited process mem_limit .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7622 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5760: Revert IMPALA-4795

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5760: Revert IMPALA-4795 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7616 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5760: Revert IMPALA-4795

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5760: Revert IMPALA-4795 .. IMPALA-5760: Revert IMPALA-4795 Revert commit 3059024bd8dc63bc1f4ecb91c99e11e2ae34ebb1 for IMPALA-4795:

[Impala-ASF-CR] IMPALA-5772: failure in test scratch disk.TestScratchDir didn't occur

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5772: failure in test_scratch_disk.TestScratchDir didn't occur .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5772: failure in test scratch disk.TestScratchDir didn't occur

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5772: failure in test_scratch_disk.TestScratchDir didn't occur .. IMPALA-5772: failure in test_scratch_disk.TestScratchDir didn't occur

[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface .. Patch Set 12: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-1478: Improve error message when subquery is used in the ON clause

2017-08-08 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. Change subject: IMPALA-1478: Improve error message when subquery is used in the ON clause .. Patch Set 3: (4 comments) Addressed the comments

[Impala-ASF-CR] IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests

2017-08-08 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7624 Change subject: IMPALA-5781: Only use TLSv1.0-compatible ciphers for tests .. IMPALA-5781: Only use TLSv1.0-compatible ciphers for

[Impala-ASF-CR] IMPALA-5652: deprecate unlimited process mem limit

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5652: deprecate unlimited process mem_limit .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1021/ -- To view,

[Impala-ASF-CR] IMPALA-5652: deprecate unlimited process mem limit

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5652: deprecate unlimited process mem_limit .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7622 To unsubscribe,

[Impala-ASF-CR] IMPALA-5652: deprecate unlimited process mem limit

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5652: deprecate unlimited process mem_limit .. IMPALA-5652: deprecate unlimited process mem_limit Testing: Started cluster locally with:

[Impala-ASF-CR] IMPALA-5772: failure in test scratch disk.TestScratchDir didn't occur

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5772: failure in test_scratch_disk.TestScratchDir didn't occur .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5772: failure in test scratch disk.TestScratchDir didn't occur

2017-08-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5772: failure in test_scratch_disk.TestScratchDir didn't occur .. Patch Set 1: Code-Review+2 This is good validation for the buffer pool changes! --

[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface

2017-08-08 Thread Sailesh Mukil (Code Review)
Hello Impala Public Jenkins, Henry Robinson, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7542 to look at the new patch set (#11). Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface

[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface

2017-08-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface .. Patch Set 11: Code-Review+2 Fixed a clang-tidy warning. Rebase, carry +2. -- To view,

[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface .. Patch Set 11: Build started:

[Impala-ASF-CR] IMPALA-5760: Revert IMPALA-4795

2017-08-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7616 Change subject: IMPALA-5760: Revert IMPALA-4795 .. IMPALA-5760: Revert IMPALA-4795 Revert commit

[Impala-ASF-CR] IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations

2017-08-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5772: failure in test scratch disk.TestScratchDir didn't occur

2017-08-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5772: failure in test_scratch_disk.TestScratchDir didn't occur .. Patch Set 2: Code-Review+2 Rebase -- To view, visit

[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. IMPALA-5696: Enable cipher configuration when using TLS / Thrift The

[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7524 To

[Impala-ASF-CR] IMPALA-5661: buffer pool limit

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5661: buffer pool limit .. IMPALA-5661: buffer pool limit Adds the --buffer_pool_limit flag to control the buffer pool size. It can be

[Impala-ASF-CR] IMPALA-5661: buffer pool limit

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5661: buffer pool limit .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7462 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface .. Patch Set 10: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2 .. IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2 This is cleanup that wasn't included

[Impala-ASF-CR] IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 2.5: Rename BufferedTupleStreamV2 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7609 To unsubscribe,

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. IMPALA-5572: Timestamp codegen for text scanner Currently codegen is disabled when scanning

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-08 Thread Tim Armstrong (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7526 to look at the new patch set (#8). Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types ..

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size uda intermediate types

2017-08-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3931: arbitrary fixed-size uda intermediate types .. Patch Set 8: Code-Review+1 Rebase -- To view, visit http://gerrit.cloudera.org:8080/7526 To

[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface

2017-08-08 Thread Sailesh Mukil (Code Review)
Hello Impala Public Jenkins, Henry Robinson, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7542 to look at the new patch set (#12). Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface

[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface

2017-08-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface .. Patch Set 12: Code-Review+2 Rebase conflict. Fixed. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-5760: Revert IMPALA-4795

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5760: Revert IMPALA-4795 .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1019/ -- To view, visit

[Impala-ASF-CR] IMPALA-5760: Revert IMPALA-4795

2017-08-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5760: Revert IMPALA-4795 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7616 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4674: Part 3: fix null-aware anti join

2017-08-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-4674: Part 3: fix null-aware anti join .. IMPALA-4674: Part 3: fix null-aware anti join Part 2 regressed NAAJ by tightening up the spilling invariants

[Impala-ASF-CR] IMPALA-4674: Part 3: fix null-aware anti join

2017-08-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 3: fix null-aware anti join .. Patch Set 7: PS7 is a rebase -- To view, visit http://gerrit.cloudera.org:8080/7367 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5744: Add 'use krpc' flag and create DataStream interface

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5744: Add 'use_krpc' flag and create DataStream interface .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers .. IMPALA-5715: (mitigation only) defer destruction of MemTrackers One

[Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7492 To

[Impala-ASF-CR] IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations

2017-08-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations

2017-08-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#6). Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations .. IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations We were missing

[Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers

2017-08-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1016/

[Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers

2017-08-08 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7492 to look at the new patch set (#5). Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers

[Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers

2017-08-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers .. Patch Set 5: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7492 To

[Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers

2017-08-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers .. Patch Set 4: ASAN build was clean but hit flaky test IMPALA-5773. -- To view, visit