[Impala-ASF-CR] IMPALA-3973: add position and occurrence to instr()

2016-09-12 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-3973: add position and occurrence to instr() .. Patch Set 13: (5 comments) We should also update the documentation for instr(). Where can I do that? >

[Impala-ASF-CR] IMPALA-3973: add position and occurrence to instr()

2016-09-12 Thread Zoltan Ivanfi (Code Review)
Hello Lars Volker, Matthew Jacobs, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4094 to look at the new patch set (#15). Change subject: IMPALA-3973: add position and occurrence to instr()

[Impala-ASF-CR] IMPALA-1616: Improve the Memory Limit Exceeded error report

2016-09-12 Thread Attila Jeges (Code Review)
Hello Michael Ho, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4335 to look at the new patch set (#4). Change subject: IMPALA-1616: Improve the Memory Limit Exceeded error report

[Impala-ASF-CR] IMPALA-1616: Improve the Memory Limit Exceeded error report

2016-09-12 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#4). Change subject: IMPALA-1616: Improve the Memory Limit Exceeded error report .. IMPALA-1616: Improve the Memory Limit Exceeded error report The error report has been changed to

[Impala-ASF-CR] IMPALA-1616: Improve the Memory Limit Exceeded error report

2016-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1616: Improve the Memory Limit Exceeded error report .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4335 To

[Impala-ASF-CR] IMPALA-4100,4112: Qgen: Replace EXTRACT UDF + IS [NOT] DISTINCT FROM in HiveSqlWriter

2016-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4100,4112: Qgen: Replace EXTRACT UDF + IS [NOT] DISTINCT FROM in HiveSqlWriter .. IMPALA-4100,4112: Qgen: Replace EXTRACT UDF + IS [NOT]

[Impala-ASF-CR] IMPALA-3973: add position and occurrence to instr()

2016-09-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3973: add position and occurrence to instr() .. Patch Set 15: > (5 comments) > > We should also update the documentation for instr(). Where can I do >

[Impala-ASF-CR] IMPALA-3973: add position and occurrence to instr()

2016-09-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3973: add position and occurrence to instr() .. Patch Set 15: Code-Review+2 Please see comment about possible missing test case, but if nothing else

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 2: (5 comments) Thanks for switching back to unique_lock, it makes it a bit easier to

[Impala-ASF-CR] Fix typo in buildall.sh introduced in IMPALA-4006

2016-09-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Fix typo in buildall.sh introduced in IMPALA-4006 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4382 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-12 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. Patch Set 5: (8 comments) Reworked the git commit message, and fixed all the issues.

[Impala-ASF-CR] IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()

2016-09-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal() .. Patch Set 9: Code-Review+2 Still lgtm -- To view, visit

[Impala-ASF-CR] IMPALA-4111: backend death tests should not produce minidumps

2016-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4111: backend death tests should not produce minidumps .. Patch Set 4: Code-Review+1 Carry +1 -- To view, visit http://gerrit.cloudera.org:8080/4353 To

[Impala-ASF-CR] IMPALA-4111: backend death tests should not produce minidumps

2016-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4111: backend death tests should not produce minidumps .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4111: backend death tests should not produce minidumps

2016-09-12 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4353 to look at the new patch set (#4). Change subject: IMPALA-4111: backend death tests should not produce minidumps ..

[Impala-ASF-CR] IMPALA-4111: backend death tests should not produce minidumps

2016-09-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4111: backend death tests should not produce minidumps .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/2/be/src/util/blocking-queue.h File

[Impala-ASF-CR] IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh

2016-09-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4187/3/bin/save-version.sh File

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 2: (16 comments) Nice! I think this counter may be useful more generally, though I think

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 9: Amos, I ran this patch through all tests and there are still failures, please fix them.

[Impala-ASF-CR] Fix typo in buildall.sh introduced in IMPALA-4006

2016-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4382 Change subject: Fix typo in buildall.sh introduced in IMPALA-4006 .. Fix typo in buildall.sh introduced in IMPALA-4006 The typo

[Impala-ASF-CR] IMPALA-4100,4112: Qgen: Replace EXTRACT UDF + IS [NOT] DISTINCT FROM in HiveSqlWriter

2016-09-12 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-4100,4112: Qgen: Replace EXTRACT UDF + IS [NOT] DISTINCT FROM in HiveSqlWriter .. Patch Set 3: > > Have we considered added some basic sanity

[Impala-ASF-CR] IMPALA-1616: Improve the Memory Limit Exceeded error report

2016-09-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-1616: Improve the Memory Limit Exceeded error report .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4335 To unsubscribe,

[Impala-ASF-CR] IMPALA-3973: add position and occurrence to instr()

2016-09-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3973: add position and occurrence to instr() .. Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/4094/15/be/src/exprs/string-functions-ir.cc

[Impala-ASF-CR] IMPALA-4100,4112: Qgen: Replace EXTRACT UDF + IS [NOT] DISTINCT FROM in HiveSqlWriter

2016-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4100,4112: Qgen: Replace EXTRACT UDF + IS [NOT] DISTINCT FROM in HiveSqlWriter .. Patch Set 2: Code-Review+2 Verified+1 Have we considered added some

[Impala-ASF-CR] Fix typo in buildall.sh introduced in IMPALA-4006

2016-09-12 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Fix typo in buildall.sh introduced in IMPALA-4006 .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4382 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4028: Trim sentry config file path spaces while impala start.

2016-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4028: Trim sentry config file path spaces while impala start. .. Patch Set 3: How did you come across this? Did you start Impala from the command line

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

2016-09-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests. .. Patch Set 1: Thanks for fixing this. While we are at it, why don't we create a common library for the

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/4326/3/be/src/exec/hash-table.h File

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4350/2/be/src/util/blocking-queue.h

[Impala-ASF-CR] IMPALA-3918: Fix straggler Cloudera -> ASF license headers

2016-09-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3918: Fix straggler Cloudera -> ASF license headers .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4386 To unsubscribe,

[Impala-ASF-CR] IMPALA-4014: PARALLEL HEADERS ONLY: Introduce query-wide execution state.

2016-09-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#3). Change subject: IMPALA-4014: PARALLEL HEADERS ONLY: Introduce query-wide execution state. .. IMPALA-4014: PARALLEL HEADERS ONLY: Introduce query-wide execution state. This patch

[Impala-ASF-CR] IMPALA-3918: Fix straggler Cloudera -> ASF license headers

2016-09-12 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: IMPALA-3918: Fix straggler Cloudera -> ASF license headers .. Patch Set 1: lgtm, though it might be a good idea to document the reasoning that the "relicense" is

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4371/2/be/src/util/runtime-profile.cc File

[Impala-ASF-CR] IMPALA-4014: PARALLEL HEADERS ONLY: Introduce query-wide execution state.

2016-09-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#4). Change subject: IMPALA-4014: PARALLEL HEADERS ONLY: Introduce query-wide execution state. .. IMPALA-4014: PARALLEL HEADERS ONLY: Introduce query-wide execution state. This patch

[Impala-ASF-CR] IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.

2016-09-12 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs. .. IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs. While I'm here, fix as many of the warnings as

[Impala-ASF-CR] IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.

2016-09-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs. .. Patch Set 1: (3 comments) > (5 comments) > > looks pretty reasonable. Might want to do a surface level

[Impala-ASF-CR] IMPALA-3918: Fix straggler Cloudera -> ASF license headers

2016-09-12 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4386 Change subject: IMPALA-3918: Fix straggler Cloudera -> ASF license headers .. IMPALA-3918: Fix straggler Cloudera -> ASF license headers

[Impala-ASF-CR] Fix typo in buildall.sh introduced in IMPALA-4006

2016-09-12 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Fix typo in buildall.sh introduced in IMPALA-4006 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4382 To unsubscribe, visit

[Impala-ASF-CR] Fix typo in buildall.sh introduced in IMPALA-4006

2016-09-12 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Fix typo in buildall.sh introduced in IMPALA-4006 .. Fix typo in buildall.sh introduced in IMPALA-4006 The typo resulted in a silent failure: an

[Impala-ASF-CR] IMPALA-4099: Fix the error message while loading UDFs with no JARs

2016-09-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4099: Fix the error message while loading UDFs with no JARs .. Patch Set 1: (5 comments) Thanks Alex for the review.

[Impala-ASF-CR] IMPALA-4014: PARALLEL HEADERS ONLY: Introduce query-wide execution state.

2016-09-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4014: PARALLEL HEADERS ONLY: Introduce query-wide execution state. .. Patch Set 4: (27 comments) Thanks for the review Lars. I've made the changes.

[Impala-ASF-CR] IMPALA-4111: backend death tests should not produce minidumps

2016-09-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4111: backend death tests should not produce minidumps .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4111: backend death tests should not produce minidumps

2016-09-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4111: backend death tests should not produce minidumps .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4099: Fix the error message while loading UDFs with no JARs

2016-09-12 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#2). Change subject: IMPALA-4099: Fix the error message while loading UDFs with no JARs .. IMPALA-4099: Fix the error message while loading UDFs with no JARs Currently we

[Impala-ASF-CR] IMPALA-4099: Fix the error message while loading UDFs with no JARs

2016-09-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4099: Fix the error message while loading UDFs with no JARs .. Patch Set 2: Code-Review+1 Henry, Marcel, can one of you sign off? -- To view, visit

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

2016-09-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests. .. Patch Set 2: (9 comments) Made a first pass. I'm still building the change to validate it myself.

[Impala-ASF-CR] IMPALA-4096: Allow clean.sh to work from snapshots

2016-09-12 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: IMPALA-4096: Allow clean.sh to work from snapshots .. IMPALA-4096: Allow clean.sh to work from snapshots buildall.sh calls bin/clean.sh, which fails when

[Impala-ASF-CR] IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh

2016-09-12 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#6). Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh .. IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh We used to

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-4028: Trim sentry config file path spaces while impala start.

2016-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4028: Trim sentry config file path spaces while impala start. .. Patch Set 3: I don't think we should go ahead with the trimming solution for the

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-12 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. Patch Set 4: (27 comments)

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-12 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#5). Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. IMPALA-3902: Scheduler improvements for running multiple

[Impala-ASF-CR] IMPALA-4099: Fix the error message while loading UDFs with no JARs

2016-09-12 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4099: Fix the error message while loading UDFs with no JARs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4365 To

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/4350/2/be/src/util/blocking-queue.h

[Impala-ASF-CR] IMPALA-3918: Fix straggler Cloudera -> ASF license headers

2016-09-12 Thread Jim Apple (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4386 to look at the new patch set (#2). Change subject: IMPALA-3918: Fix straggler Cloudera -> ASF license headers ..

[Impala-ASF-CR] IMPALA-3918: Fix straggler Cloudera -> ASF license headers

2016-09-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3918: Fix straggler Cloudera -> ASF license headers .. Patch Set 2: Code-Review+2 > lgtm, though it might be a good idea to document the reasoning that >

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

2016-09-12 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests. .. IMPALA-4091: Fix backend unit to log in logs/be_tests. 1. Many backend unit tests did not follow proper

[Impala-ASF-CR] IMPALA-4091: Fix backend unit to log in logs/be tests.

2016-09-12 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4091: Fix backend unit to log in logs/be_tests. .. Patch Set 1: I decided to add a macro for the common main() instead of going the library route. The

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-12 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 3: (18 comments) http://gerrit.cloudera.org:8080/#/c/4371/2//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4350/3/be/src/util/blocking-queue.h

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-12 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. IMPALA-4026: Implement double-buffering for BlockingQueue. With recent changes to improve the parquet

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into PAGG/AGG IR code

2016-09-12 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/4390 Change subject: IMPALA-4008: Don't bake ExprContext pointers into PAGG/AGG IR code .. IMPALA-4008: Don't bake ExprContext pointers into