[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/rpc/rpc-trace.cc File

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-22 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 5: Code-Review-1 (1 comment)

[Impala-ASF-CR] IMPALA-3504: function for current timestamp in UTC, i.e. utc timestamp()

2016-09-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3504: function for current timestamp in UTC, i.e. utc_timestamp() .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4500 To

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: What's the performance of updating this metrics? -- To view, visit

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. IMPALA-4023: don't attach buffered tuple streams to batches This simplifies the memory transfer

[Impala-ASF-CR] IMPALA-889: Add support for an ISO-SQL compliant trim() function.

2016-09-22 Thread Youwei Wang (Code Review)
Youwei Wang has posted comments on this change. Change subject: IMPALA-889: Add support for an ISO-SQL compliant trim() function. .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4474/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: (8 comments) Perf results are in the commit msg now.

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 1: Have you considered making TAcceptQueueThreadedServer inherit from

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/rpc/rpc-trace.cc File

[Impala-ASF-CR] IMPALA-889: Add support for an ISO-SQL compliant trim() function.

2016-09-22 Thread Youwei Wang (Code Review)
Youwei Wang has uploaded a new patch set (#3). Change subject: IMPALA-889: Add support for an ISO-SQL compliant trim() function. .. IMPALA-889: Add support for an ISO-SQL compliant trim() function. Syntax #1: BTRIM(string

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-22 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-3504: function for current timestamp in UTC, i.e. utc timestamp()

2016-09-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3504: function for current timestamp in UTC, i.e. utc_timestamp() .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-22 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/4519 Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. IMPALA-4135: Thrift threaded

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4516/2/be/src/rpc/rpc-trace.cc File

[Impala-ASF-CR] IMPALA-4193: Improve detection of max CPU frequency

2016-09-22 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/4521 Change subject: IMPALA-4193: Improve detection of max CPU frequency .. IMPALA-4193: Improve detection of max CPU frequency The current

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. IMPALA-4187: Switch RPC latency metrics to histograms It's usually better to measure latency

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. Patch Set 2: Code-Review+2 I'm going to submit this as is, then someone can take on

[Impala-ASF-CR] IMPALA-3504: function for current timestamp in UTC, i.e. utc timestamp()

2016-09-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3504: function for current timestamp in UTC, i.e. utc_timestamp() .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-22 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. Patch Set 10: (26 comments) How much testing have you

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 12: (10 comments)

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. IMPALA-4011: Remove / reword messages when statestore messages are late

[Impala-ASF-CR] IMPALA-3504: function for current timestamp in UTC, i.e. utc timestamp()

2016-09-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3504: function for current timestamp in UTC, i.e. utc_timestamp() .. Patch Set 3: (15 comments) http://gerrit.cloudera.org:8080/#/c/4490/3//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation

2016-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation .. Patch Set 9: (2 comments)

[Impala-ASF-CR] IMPALA-4118: extract encryption utils from BufferedBlockMgr

2016-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr .. IMPALA-4118: extract encryption utils from BufferedBlockMgr As groundwork for IMPALA-4118, extract

[Impala-ASF-CR] IMPALA-4118: extract encryption utils from BufferedBlockMgr

2016-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr .. IMPALA-4118: extract encryption utils from BufferedBlockMgr As groundwork for IMPALA-4118, extract

[Impala-ASF-CR] IMPALA-4118: extract encryption utils from BufferedBlockMgr

2016-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr .. Patch Set 6: (13 comments) http://gerrit.cloudera.org:8080/#/c/4389/6/be/src/common/init.cc File

[Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation

2016-09-22 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation .. Patch Set 11: Code-Review+2 Rebase, carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation

2016-09-22 Thread Tim Armstrong (Code Review)
Hello Henry Robinson, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4163 to look at the new patch set (#10). Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation

[Impala-ASF-CR] IMPALA-3504: function for current timestamp in UTC, i.e. utc timestamp()

2016-09-22 Thread Youwei Wang (Code Review)
Youwei Wang has uploaded a new patch set (#3). Change subject: IMPALA-3504: function for current timestamp in UTC, i.e. utc_timestamp() .. IMPALA-3504: function for current timestamp in UTC, i.e. utc_timestamp() Implement a

[Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation

2016-09-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4163 To

[Impala-ASF-CR] IMPALA-4037,IMPALA-4038: fix locking during query cancellation

2016-09-22 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4037,IMPALA-4038: fix locking during query cancellation .. IMPALA-4037,IMPALA-4038: fix locking during query cancellation * Refactor the

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4516 Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. IMPALA-4187: Switch RPC latency metrics to histograms It's

[Impala-ASF-CR] IMPALA-4187: Switch RPC latency metrics to histograms

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4187: Switch RPC latency metrics to histograms .. Patch Set 2: The core change to HistogramMetric (adding a Reset() method) is needed for our proposed

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-22 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. Patch Set 2: Before we consider adding a histogram, we'll need one that can be

[Impala-ASF-CR] IMPALA-889: Add support for ISO-SQL trim()

2016-09-22 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-889: Add support for ISO-SQL trim() .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4474/1//COMMIT_MSG Commit Message: Line 10: Form 1:

[Impala-ASF-CR] IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-22 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 10: (10 comments)

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/4390/4/be/src/exec/aggregation-node.cc

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4390/4/be/src/exec/aggregation-node.cc

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-22 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4390 to look at the new patch set (#5). Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code ..

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-22 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#12). Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-22 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#12). Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has uploaded a new patch set (#10). Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. IMPALA-3902: Scheduler improvements for running multiple

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-22 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. Patch Set 10: (29 comments)

[Impala-ASF-CR] IMPALA-4011: Remove / reword messages when statestore messages are late

2016-09-22 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4011: Remove / reword messages when statestore messages are late .. Patch Set 2: (1 comment)