[Impala-ASF-CR](asf-site) Add downloads page

2016-09-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: Add downloads page .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4544/1/downloads.html File downloads.html: PS1, Line 50: indent off

[Impala-ASF-CR](asf-site) Add downloads page

2016-09-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#3). Change subject: Add downloads page .. Add downloads page This should not be pushed to the repo until a release is approved by the IPMC and the links are working and the mirrors have

[Impala-ASF-CR](asf-site) Add downloads page

2016-09-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#4). Change subject: Add downloads page .. Add downloads page This should not be pushed to the repo until a release is approved by the IPMC and the links are working and the mirrors have

[Impala-ASF-CR](asf-site) Add downloads page

2016-09-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add downloads page .. Patch Set 4: (5 comments) I used tidy -indent --wrap 90 -bare in PS1, FYI. http://gerrit.cloudera.org:8080/#/c/4544/1/downloads.html

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-27 Thread Sailesh Mukil (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4371 to look at the new patch set (#8). Change subject: IMPALA-3823: Add timer to measure Parquet footer reads ..

[Impala-ASF-CR] IMPALA-3823: Add timer to measure Parquet footer reads

2016-09-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables With this commit we

[Impala-ASF-CR](asf-site) Add downloads page

2016-09-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: Add downloads page .. Patch Set 4: Code-Review+1 (2 comments) Please wait for +2 from Taras. http://gerrit.cloudera.org:8080/#/c/4544/4/downloads.html File

[Impala-ASF-CR](asf-site) Add downloads page

2016-09-27 Thread Jim Apple (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4544 to look at the new patch set (#5). Change subject: Add downloads page .. Add downloads page This should not be

[Impala-ASF-CR](asf-site) Add downloads page

2016-09-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add downloads page .. Patch Set 5: Code-Review+1 Carry kwho@'s +1 -- To view, visit http://gerrit.cloudera.org:8080/4544 To unsubscribe, visit

[Impala-ASF-CR](asf-site) Add downloads page

2016-09-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add downloads page .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4544/4/downloads.html File downloads.html: PS4, Line 174: > Not sure if it's

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-09-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 1: (94 comments) http://gerrit.cloudera.org:8080/#/c/4414/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-27 Thread Sahil Takiar (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4011 to look at the new patch set (#12). Change subject: IMPALA-3980: qgen: re-enable Hive as a target database ..

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-27 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-4199: Add 'SNAPSHOT' to Impala version

2016-09-27 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4199: Add 'SNAPSHOT' to Impala version .. IMPALA-4199: Add 'SNAPSHOT' to Impala version Unreleased versions should contain the string

[Impala-ASF-CR] IMPALA-3201: in-memory buffer pool implementation

2016-09-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: in-memory buffer pool implementation .. Patch Set 7: (8 comments) http://gerrit.cloudera.org:8080/#/c/4070/7/be/src/bufferpool/buffer-pool.cc File

[Impala-ASF-CR] IMPALA-4205: fix tmp-file-mgr-test under ASAN

2016-09-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4205: fix tmp-file-mgr-test under ASAN .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4546 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4142: qgen: Hive does not support CTEs inside sub-query blocks

2016-09-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4142: qgen: Hive does not support CTEs inside sub-query blocks .. Patch Set 2: Code-Review+2 Verified+1 -- To view, visit

[Impala-ASF-CR](asf-site) Add downloads page

2016-09-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: Add downloads page .. Patch Set 5: Code-Review+2 Looks good to me. We should verify that the download links are working before actually pushing. -- To

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-09-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 5: Code-Review+2 Actually I think the changes are simple enough and don't change any core

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 14: (11 comments)

[Impala-ASF-CR] IMPALA-4205: fix tmp-file-mgr-test under ASAN

2016-09-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4546 Change subject: IMPALA-4205: fix tmp-file-mgr-test under ASAN .. IMPALA-4205: fix tmp-file-mgr-test under ASAN Fix use-after-free of

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 4: Let's also disallow the copy constructor (see DISALLOW_COPY_AND_ASSIGN macro). -- To view, visit

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-09-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4448 To unsubscribe,

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 5: (10 comments) http://gerrit.cloudera.org:8080/#/c/4350/5/be/src/exec/hdfs-scan-node.cc

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-27 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4350 to look at the new patch set (#7). Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue ..

[Impala-ASF-CR] IMPALA-3201: in-memory buffer pool implementation

2016-09-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3201: in-memory buffer pool implementation .. Patch Set 8: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 13: Code-Review+2 Verified+1 Looks good to me, I'll submit this patch. -- To view,

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has submitted this change and it was merged. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. IMPALA-3980: qgen: re-enable Hive as a target database Changes: * Added hive cli options

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-09-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 5: Code-Review+1 (2 comments) FE changes look good to me. We need Henry or Marcel to sign off

[Impala-ASF-CR] IMPALA-4199: Add 'SNAPSHOT' to Impala version

2016-09-27 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4199: Add 'SNAPSHOT' to Impala version .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4539 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3201: in-memory buffer pool implementation

2016-09-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-3201: in-memory buffer pool implementation .. IMPALA-3201: in-memory buffer pool implementation This patch implements basic in-memory buffer management,

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 4: Code-Review+2 Trivial enough that I feel giving a +2 on the catalog changes also. -- To

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-27 Thread Tim Armstrong (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3873 to look at the new patch set (#20). Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/4350/7/be/src/util/blocking-queue.h File

[Impala-ASF-CR] IMPALA-3201: in-memory buffer pool implementation

2016-09-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: in-memory buffer pool implementation .. Patch Set 7: (11 comments) http://gerrit.cloudera.org:8080/#/c/4070/4/be/src/bufferpool/buffer-allocator.h

[Impala-ASF-CR] IMPALA-3201: in-memory buffer pool implementation

2016-09-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3201: in-memory buffer pool implementation .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4070/4/be/src/bufferpool/buffer-allocator.h

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/5/be/src/util/blocking-queue.h File

Re: [Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-27 Thread Taras Bobrovytsky
We normally use the gerrit-verify-merge script to merge Impala changes. However, since this is the query generator, you can click Verified+1, then submit. On Tue, Sep 27, 2016 at 11:06 AM, Taras Bobrovytsky (Code Review) < ger...@cloudera.org> wrote: > Taras Bobrovytsky has posted comments on

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has submitted this change and it was merged. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. IMPALA-4101: qgen: Hive join predicates should only contains

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 4: Same thing with this one. -- To view, visit http://gerrit.cloudera.org:8080/3936 To

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-09-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 2: > (2 comments) What if the blocksize is set to something other than 8MB by startup

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-09-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 5: Alex and Henry, can you look at FE and Catalog respectively? Or Marcel could you do the +2?

[Impala-ASF-CR] IMPALA-4199: Add 'SNAPSHOT' to Impala version

2016-09-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4199: Add 'SNAPSHOT' to Impala version .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4539 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 11: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 11: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4104: add DCHECK to ConsumeLocal() and fix tests

2016-09-27 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4104: add DCHECK to ConsumeLocal() and fix tests .. IMPALA-4104: add DCHECK to ConsumeLocal() and fix tests The TestEnv used for the backend

[Impala-ASF-CR] IMPALA-4104: add DCHECK to ConsumeLocal() and fix tests

2016-09-27 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4104: add DCHECK to ConsumeLocal() and fix tests .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4531 To unsubscribe,

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-27 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4390 To unsubscribe,

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-27 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. IMPALA-4008: Don't bake ExprContext pointers into IR code To allow genearated code to

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-09-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 2: I agree that it could make a difference but I don't think we want to preserve the

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-09-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 2: Code-Review+2 Please check if Alex's concerns are addressed before committing. -- To

[Impala-ASF-CR](asf-site) Add downloads page

2016-09-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Add downloads page .. Add downloads page This should not be pushed to the repo until a release is approved by the IPMC and the links are working and the mirrors have

[Impala-ASF-CR](asf-site) Allow votes to go long if they overlap a weekend.

2016-09-27 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: Allow votes to go long if they overlap a weekend. .. Allow votes to go long if they overlap a weekend. On our first release vote, Tom White explained that

[Impala-ASF-CR](asf-site) Allow votes to go long if they overlap a weekend.

2016-09-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Allow votes to go long if they overlap a weekend. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4536 To unsubscribe, visit

[Impala-ASF-CR](asf-site) Add downloads page

2016-09-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/4544 Change subject: Add downloads page .. Add downloads page This should not be pushed to the repo until a release is approved by the IPMC and

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 11: (1 comment)

[Impala-ASF-CR](asf-site) Add downloads page

2016-09-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: Add downloads page .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4544/1/downloads.html File downloads.html: PS1, Line 135:

[Impala-ASF-CR](asf-site) Add downloads page

2016-09-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add downloads page .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4544/1/downloads.html File downloads.html: PS1, Line 135: class="active" >