[Impala-ASF-CR] IMPALA-4270: Gracefully fail unsupported queries with mt dop > 0.

2016-10-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4270: Gracefully fail unsupported queries with mt_dop > 0. .. IMPALA-4270: Gracefully fail unsupported queries with mt_dop > 0. MT_DOP > 0

[Impala-ASF-CR] IMPALA-4270: Gracefully fail unsupported queries with mt dop > 0.

2016-10-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4270: Gracefully fail unsupported queries with mt_dop > 0. .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4677 To

[Impala-ASF-CR] Buffer pool: Add basic counters to buffer pool client

2016-10-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Buffer pool: Add basic counters to buffer pool client .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4714 To unsubscribe, visit

[Impala-ASF-CR] Add search / sort to HTML tables for metrics and threads

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4743 Change subject: Add search / sort to HTML tables for metrics and threads .. Add search / sort to HTML tables for metrics and threads

[Impala-ASF-CR] IMPALA-2916: Add warning to query profile if debug build

2016-10-17 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-2916: Add warning to query profile if debug build .. IMPALA-2916: Add warning to query profile if debug build Change-Id:

[Impala-ASF-CR] IMPALA-2916: Add warning to query profile if debug build

2016-10-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2916: Add warning to query profile if debug build .. Patch Set 1: (2 comments) Thanks for the review, please see PS2.

[Impala-ASF-CR] Buffer pool: Add basic counters to buffer pool client

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Buffer pool: Add basic counters to buffer pool client .. Patch Set 3: Code-Review+2 carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4714 To

[Impala-ASF-CR] IMPALA-4120: Incorrect results with LEAD() analytic function

2016-10-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4120: Incorrect results with LEAD() analytic function .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4740/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 7: (29 comments)

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 5: (8 comments) Responses to comments. Starting next round on code.

[Impala-ASF-CR] IMPALA-2789: More compact mem layout with null bits at the end.

2016-10-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2789: More compact mem layout with null bits at the end. .. Patch Set 7: (1 comment)

[Impala-ASF-CR] Impala-3342: Adding thread counters to measure time spent during plan fragment execution

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Impala-3342: Adding thread counters to measure time spent during plan fragment execution .. Patch Set 5: (2 comments)

[Impala-ASF-CR] Remove Llama dependency

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Remove Llama dependency .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4739/1/common/thrift/metrics.json File

[Impala-ASF-CR] Remove Llama dependency

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Remove Llama dependency .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4739/1/common/thrift/metrics.json File common/thrift/metrics.json:

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4720 To

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Abandoned I need to make time to polish this up and put out a version for review. -- To

[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3. .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4582 To unsubscribe, visit

[Impala-ASF-CR] Remove Llama dependency

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Remove Llama dependency .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4739/1/common/thrift/metrics.json File common/thrift/metrics.json:

[Impala-ASF-CR] IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables

2016-10-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3719: Simplify CREATE TABLE statements with Kudu tables .. Patch Set 7: (26 comments) Next round over the code.

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

2016-10-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2905: Move QueryResultSet implementations into separate module .. Patch Set 2: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/4651/4/be/src/exec/exec-node.h File

[Impala-ASF-CR] PREVIEW IMPALA-2521: Add clustered hint to insert statements

2016-10-17 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/4745 Change subject: PREVIEW IMPALA-2521: Add clustered hint to insert statements .. PREVIEW IMPALA-2521: Add clustered hint to insert

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

2016-10-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2905: Move QueryResultSet implementations into separate module .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] PREVIEW IMPALA-2521: Add clustered hint to insert statements

2016-10-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: PREVIEW IMPALA-2521: Add clustered hint to insert statements .. Patch Set 1: In a first round I'd like to ask for feedback on the overall approach and the open

[Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution

2016-10-17 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#6). Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution .. IMPALA-3342: Add thread counters to monitor plan fragment execution This change removes the

[Impala-ASF-CR] IMPALA-3342: Add thread counters to monitor plan fragment execution

2016-10-17 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution .. Patch Set 6: (1 comment)

[Impala-ASF-CR] Add search / sort to HTML tables for metrics and threads

2016-10-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Add search / sort to HTML tables for metrics and threads .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4743 To unsubscribe,

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 15: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4494 To unsubscribe, visit

[Impala-ASF-CR] Remove Llama dependency

2016-10-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Remove Llama dependency .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4739 To unsubscribe, visit

[Impala-ASF-CR] Buffer pool: Add basic counters to buffer pool client

2016-10-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Buffer pool: Add basic counters to buffer pool client .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4714 To unsubscribe,

[Impala-ASF-CR] Buffer pool: Add basic counters to buffer pool client

2016-10-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Buffer pool: Add basic counters to buffer pool client .. Buffer pool: Add basic counters to buffer pool client Change-Id:

[Impala-ASF-CR] Add search / sort to HTML tables for metrics and threads

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: Add search / sort to HTML tables for metrics and threads .. Add search / sort to HTML tables for metrics and threads Change-Id:

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Move QueryResultSet implementations into separate module .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4736/2//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value

2016-10-17 Thread Juan Yu (Code Review)
Hello Sailesh Mukil, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4668 to look at the new patch set (#2). Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

2016-10-17 Thread Henry Robinson (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4736 to look at the new patch set (#3). Change subject: IMPALA-2905: Move QueryResultSet implementations into separate module

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Move QueryResultSet implementations into separate module .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4736 To

[Impala-ASF-CR] IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value

2016-10-17 Thread Juan Yu (Code Review)
Juan Yu has posted comments on this change. Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value .. Patch Set 2: Code-Review+2 (1 comment) Carry Dan's +2

[Impala-ASF-CR] PREVIEW IMPALA-2521: Add clustered hint to insert statements

2016-10-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: PREVIEW IMPALA-2521: Add clustered hint to insert statements .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4720 To

[Impala-ASF-CR] review comments 1

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: review comments 1 .. Abandoned Mistakenly pushed. -- To view, visit http://gerrit.cloudera.org:8080/4735 To unsubscribe, visit

[Impala-ASF-CR](hadoop-next) IMPALA-4277: bump Hadoop component versions except for Hadoop itself

2016-10-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop itself .. Patch Set 1: (2 comments) Sorry for the delay.

[Impala-ASF-CR](hadoop-next) IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4299: add buildall.sh option to start test cluster

2016-10-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4299: add buildall.sh option to start test cluster .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4734 To unsubscribe,

[Impala-ASF-CR] Remove Llama dependency

2016-10-17 Thread Tim Armstrong (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4739 to look at the new patch set (#3). Change subject: Remove Llama dependency .. Remove Llama dependency

[Impala-ASF-CR] Remove Llama dependency

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Remove Llama dependency .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4739 To unsubscribe, visit

[Impala-ASF-CR] Remove Llama dependency

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Remove Llama dependency .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4739/2/common/thrift/ImpalaInternalService.thrift File

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 13: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/4494/11/be/src/util/bit-packing-test.cc File

[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Follow Apache Project Branding Requirements .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4683/1/bylaws.html File bylaws.html: PS1, Line 134:

[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-17 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Follow Apache Project Branding Requirements .. Follow Apache Project Branding Requirements See: http://www.apache.org/foundation/marks/pmcs.html Specifically: 1.

[Impala-ASF-CR] Impala-3342: Adding thread counters to measure time spent during plan fragment execution

2016-10-17 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: Impala-3342: Adding thread counters to measure time spent during plan fragment execution .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node

2016-10-17 Thread anujphadke (Code Review)
Hello Matthew Jacobs, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4639 to look at the new patch set (#3). Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node

[Impala-ASF-CR] IMPALA-2789: More compact mem layout with null bits at the end.

2016-10-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2789: More compact mem layout with null bits at the end. .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/4047/6/fe/src/main/cup/sql-parser.cup File

[Impala-ASF-CR] IMPALA-4299: add buildall.sh option to start test cluster

2016-10-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4299: add buildall.sh option to start test cluster .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4734 To unsubscribe,

[Impala-ASF-CR] IMPALA-4299: add buildall.sh option to start test cluster

2016-10-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4299: add buildall.sh option to start test cluster .. IMPALA-4299: add buildall.sh option to start test cluster A previous commit

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. IMPALA-4277: allow overriding of Hive/Hadoop versions/locations This is to help with

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-17 Thread Tim Armstrong (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4494 to look at the new patch set (#14). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 15: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4494 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/4494/11/be/src/util/bit-packing-test.cc File

[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.

2016-10-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3. .. Patch Set 5: Tim, Taras, any other concerns? -- To view, visit http://gerrit.cloudera.org:8080/4582 To

[Impala-ASF-CR] IMPALA-4299: add buildall.sh option to start test cluster

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4734 Change subject: IMPALA-4299: add buildall.sh option to start test cluster .. IMPALA-4299: add buildall.sh option to start test cluster

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4720/1/bin/impala-config.sh

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4720/1/bin/impala-config.sh

[Impala-ASF-CR] IMPALA-4216: Test became flaky: TestTpchMemLimitError.test low mem limit q20

2016-10-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4216: Test became flaky: TestTpchMemLimitError.test_low_mem_limit_q20 .. Patch Set 1: But why do we no longer get the MEM_LIMIT_EXCEEDED error status

[Impala-ASF-CR] IMPALA-3504: UDF for current timestamp in UTC

2016-10-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3504: UDF for current timestamp in UTC .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4490/8/be/src/service/impala-server.cc File

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. Patch Set 1: Did a grep for HADOOP_HOME, and this might need to be changed too:

[Impala-ASF-CR] IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node

2016-10-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3920: TotalStorageWaitTime counter not populated for fragments with Kudu scan node .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-17 Thread Charlie Helin (Code Review)
Charlie Helin has posted comments on this change. Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. Patch Set 1: -Code-Review > Did a grep for HADOOP_HOME, and this might need to be changed

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. Patch Set 4: Do we still plan to make the ExecNodes' Codegen() be static (in a future patch), or has

[Impala-ASF-CR] IMPALA-2905: Move QueryResultSet implementations into separate module

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4736 Change subject: IMPALA-2905: Move QueryResultSet implementations into separate module .. IMPALA-2905: Move QueryResultSet

[Impala-ASF-CR] review comments 1

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4735 Change subject: review comments 1 .. review comments 1 Change-Id: I3d1094dffd6b0341f8554283c3b77c6a970ca7ec --- M

[Impala-ASF-CR](hadoop-next) IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API

2016-10-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#12). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 12: (8 comments) http://gerrit.cloudera.org:8080/#/c/4494/11/be/src/util/bit-packing-test.cc File

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#13). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. Patch Set 1: This is for master, yet. I think we will need to be able to point to the

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-17 Thread Charlie Helin (Code Review)
Charlie Helin has posted comments on this change. Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4720/1/bin/impala-config.sh

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4720/1/bin/impala-config.sh

[Impala-ASF-CR] Remove Llama dependency

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4739 Change subject: Remove Llama dependency .. Remove Llama dependency This change prevents us from depending on LLAMA to build. Note that

[Impala-ASF-CR](hadoop-next) IMPALA-4277: bump Hadoop component versions except for Hadoop itself

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop itself .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4698/1//COMMIT_MSG

[Impala-ASF-CR](hadoop-next) IMPALA-4277: bump Hadoop component versions except for Hadoop itself

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop itself .. IMPALA-4277: bump Hadoop component versions except for Hadoop itself The Hive version

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. Patch Set 1: Is this necessary for the master branch? Once we move permanently to C6, we

[Impala-ASF-CR](hadoop-next) IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API

2016-10-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR](hadoop-next) IMPALA-4277: bump Hadoop component versions except for Hadoop itself

2016-10-17 Thread Charlie Helin (Code Review)
Charlie Helin has posted comments on this change. Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop itself .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4698/1//COMMIT_MSG Commit

[Impala-ASF-CR] Impala-3342 Adding thread counters to measure time spent during plan fragment execution

2016-10-17 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#3). Change subject: Impala-3342 Adding thread counters to measure time spent during plan fragment execution .. Impala-3342 Adding thread counters to measure time spent during plan

[Impala-ASF-CR](hadoop-next) IMPALA-4277: bump Hadoop component versions except for Hadoop itself

2016-10-17 Thread Charlie Helin (Code Review)
Charlie Helin has posted comments on this change. Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop itself .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4698/1//COMMIT_MSG Commit

[Impala-ASF-CR] Remove Llama dependency

2016-10-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Remove Llama dependency .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4739/1/common/thrift/ImpalaService.thrift File

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. IMPALA-4277: allow overriding of Hive/Hadoop versions/locations This is to help with

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. Patch Set 1: I updated the HADOOP_HOME/lib reference I think HADOOP_LZO shouldn't need

[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Follow Apache Project Branding Requirements .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4683/1/bylaws.html File bylaws.html: PS1, Line

[Impala-ASF-CR] Remove Llama dependency

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Remove Llama dependency .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4739/1/common/thrift/ImpalaService.thrift File

[Impala-ASF-CR] Remove Llama dependency

2016-10-17 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4739 to look at the new patch set (#2). Change subject: Remove Llama dependency .. Remove Llama dependency This change

[Impala-ASF-CR] Not for review: IR for IMPALA-4231: fix codegen time regression

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. Change subject: Not for review: IR for IMPALA-4231: fix codegen time regression .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4649 To unsubscribe, visit

[Impala-ASF-CR] Remove Llama dependency

2016-10-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Remove Llama dependency .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4739 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4720/2/bin/impala-config.sh

[Impala-ASF-CR] IMPALA-4024: Add "system" database and expose Impala metrics as a table

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table .. Patch Set 19: What do you think we should do with this? Is it close to commit, or

[Impala-ASF-CR] IMPALA-4050: Support starting webserver specified by hostname

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4050: Support starting webserver specified by hostname .. Patch Set 2: Hi - will you have some time to work on this patch, or should we close it out?

[Impala-ASF-CR] Remove Llama dependency

2016-10-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Remove Llama dependency .. Patch Set 2: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/4739/2/common/thrift/ImpalaInternalService.thrift File

[Impala-ASF-CR] IMPALA-2916: Add warning to query profile if debug build

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2916: Add warning to query profile if debug build .. Patch Set 1: (2 comments) This will be useful to have.

  1   2   >