[Impala-ASF-CR] IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.

2016-11-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04. .. Patch Set 4: Build failed:

[Impala-ASF-CR] IMPALA-4553: ntpd must be synchronized for kudu to start.

2016-11-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5258/1/testdata/cluster/admin File

[Impala-ASF-CR] Start a docs build system.

2016-11-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Start a docs build system. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5238/2/docs/Makefile File docs/Makefile: High-level question: would

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific

2016-11-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5239/2//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/4968/8/be/src/exec/parquet-column-readers.cc

[Impala-ASF-CR] IMPALA-4550: Fix CastExpr analysis for substituted slots

2016-11-29 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/5267 Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots .. IMPALA-4550: Fix CastExpr analysis for substituted slots

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load

2016-11-29 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load .. IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load If a

[Impala-ASF-CR] IMPALA-4550: Fix CastExpr analysis for substituted slots

2016-11-29 Thread Lars Volker (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5267 to look at the new patch set (#2). Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots ..

[Impala-ASF-CR] IMPALA-4550: Fix CastExpr analysis for substituted slots

2016-11-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots .. Patch Set 1: (5 comments) Thanks for the review. Please see PS2.

[Impala-ASF-CR] IMPALA-4550: Fix CastExpr analysis for substituted slots

2016-11-29 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/5265 Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots .. IMPALA-4550: Fix CastExpr analysis for substituted slots

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#9). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add Parquet timestamp validation Before this patch, we would simply read the INT96 Parquet

[Impala-ASF-CR] IMPALA-4550: Fix CastExpr analysis for substituted slots

2016-11-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots .. Patch Set 1: Code-Review+2 (5 comments) Nice! http://gerrit.cloudera.org:8080/#/c/5267/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. Patch Set 4: Henry, I tried doing some of the refactoring we discussed, but they don't

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 11: (40 comments)

[Impala-ASF-CR] IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.

2016-11-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04. .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5154

[Impala-ASF-CR] Fix E2E test infrastructure to handle missing exceptions correctly

2016-11-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Fix E2E test infrastructure to handle missing exceptions correctly .. Patch Set 2: Code-Review+2 We should do an exhaustive run before merging. -- To view,

[Impala-ASF-CR] IMPALA-4450: qgen: use string concatenation operator for postgres queries

2016-11-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4450: qgen: use string concatenation operator for postgres queries .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#10). Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. IMPALA-4172/IMPALA-3653: Improvements to block metadata loading This patch improves the

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 9: (3 comments)

[Impala-ASF-CR] IMPALA-4550: Fix CastExpr analysis for substituted slots

2016-11-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4553: ntpd must be synchronized for kudu to start.

2016-11-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start. .. IMPALA-4553: ntpd must be synchronized for kudu to start. When ntpd is not

[Impala-ASF-CR] IMPALA-4553: ntpd must be synchronized for kudu to start.

2016-11-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5258 To

[Impala-ASF-CR] IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.

2016-11-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04. .. IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#11). Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. IMPALA-4172/IMPALA-3653: Improvements to block metadata loading This patch improves the

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-29 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4968 to look at the new patch set (#9). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

2016-11-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific .. Patch Set 2: (13 comments) > (12 comments) > > Because I'm advocating re-doing the

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

2016-11-29 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#3). Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific .. IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific This fix is a prototype

[Impala-ASF-CR] IMPALA-4397 addendum: remove stray semicolon

2016-11-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4397 addendum: remove stray semicolon .. Patch Set 1: Failed because https://issues.cloudera.org/browse/IMPALA-4557 -- To view, visit

[Impala-ASF-CR] IMPALA-4550: Fix CastExpr analysis for substituted slots

2016-11-29 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4397 addendum: remove stray semicolon

2016-11-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4397 addendum: remove stray semicolon .. Patch Set 1: Build started: http://35.164.73.121:8080/job/gerrit-verify-dryrun/54/ -- To view, visit

[Impala-ASF-CR] IMPALA-4550: Fix CastExpr analysis for substituted slots

2016-11-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5267 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4550: Fix CastExpr analysis for substituted slots

2016-11-29 Thread Lars Volker (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5267 to look at the new patch set (#3). Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots ..

[Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

2016-11-29 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model .. Patch Set 5: (8 comments)

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific

2016-11-29 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific .. Patch Set 2: (12 comments) Because I'm advocating re-doing the automated portions of

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. Patch Set 3: (1 comment) Patchset 4 addresses the comments that don't involve

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-29 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new patch set (#4). Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting The

[Impala-ASF-CR] IMPALA-4550: Fix CastExpr analysis for substituted slots

2016-11-29 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots .. Abandoned Needs rebase. -- To view, visit http://gerrit.cloudera.org:8080/5265 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-29 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4968 to look at the new patch set (#9). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-29 Thread Taras Bobrovytsky (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4968 to look at the new patch set (#9). Change subject: IMPALA-4363: Add Parquet timestamp validation .. IMPALA-4363: Add

[Impala-ASF-CR] IMPALA-4397 addendum: remove stray semicolon

2016-11-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4397 addendum: remove stray semicolon .. Patch Set 1: Verified-1 Build failed: http://35.164.73.121:8080/job/gerrit-verify-dryrun/52/ -- To

[Impala-ASF-CR] IMPALA-4397 addendum: remove stray semicolon

2016-11-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4397 addendum: remove stray semicolon .. Patch Set 1: Build started: http://35.164.73.121:8080/job/gerrit-verify-dryrun/52/ -- To view, visit

[Impala-ASF-CR] IMPALA-4553: ntpd must be synchronized for kudu to start.

2016-11-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start. .. Patch Set 3: Code-Review+2 carry Tim's -- To view, visit http://gerrit.cloudera.org:8080/5258 To

[Impala-ASF-CR] Fix E2E test infrastructure to handle missing exceptions correctly

2016-11-29 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: Fix E2E test infrastructure to handle missing exceptions correctly .. Fix E2E test infrastructure to handle missing exceptions correctly This change fixes a bug in

[Impala-ASF-CR] IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"

2016-11-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL" .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5259

[Impala-ASF-CR] IMPALA-4553: ntpd must be synchronized for kudu to start.

2016-11-29 Thread Jim Apple (Code Review)
Hello Todd Lipcon, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5258 to look at the new patch set (#3). Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start.

[Impala-ASF-CR] IMPALA-4553: ntpd must be synchronized for kudu to start.

2016-11-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start. .. Patch Set 2: Code-Review+2 (1 comment)

[Impala-ASF-CR] Fix E2E test infrastructure to handle missing exceptions correctly

2016-11-29 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/5260 Change subject: Fix E2E test infrastructure to handle missing exceptions correctly .. Fix E2E test infrastructure to handle missing

[Impala-ASF-CR] Start a docs build system.

2016-11-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Start a docs build system. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5238/2/docs/Makefile File docs/Makefile: > High-level question: would

[Impala-ASF-CR] IMPALA-4553: ntpd must be synchronized for kudu to start.

2016-11-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5258 To unsubscribe,

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 9: (3 comments)

[Impala-ASF-CR] Fix E2E test infrastructure to handle missing exceptions correctly

2016-11-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Fix E2E test infrastructure to handle missing exceptions correctly .. Patch Set 1: (1 comment) Did you do an exhaustive test run? Just to be sure that this

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-29 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new patch set (#3). Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting The

[Impala-ASF-CR] IMPALA-4553: ntpd must be synchronized for kudu to start.

2016-11-29 Thread Jim Apple (Code Review)
Hello Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5258 to look at the new patch set (#2). Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start. ..

[Impala-ASF-CR] IMPALA-2057: Better error message for incorrect avro decimal column declaration

2016-11-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2057: Better error message for incorrect avro decimal column declaration .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4397 addendum: remove stray semicolon

2016-11-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5261 Change subject: IMPALA-4397 addendum: remove stray semicolon .. IMPALA-4397 addendum: remove stray semicolon Change-Id:

[Impala-ASF-CR] IMPALA-3875: Thrift threaded server hang in some cases

2016-11-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/5263 Change subject: IMPALA-3875: Thrift threaded server hang in some cases .. IMPALA-3875: Thrift threaded server hang in some cases We use

[Impala-ASF-CR] IMPALA-2057: Better error message for incorrect avro decimal column declaration

2016-11-29 Thread anujphadke (Code Review)
anujphadke has uploaded a new change for review. http://gerrit.cloudera.org:8080/5255 Change subject: IMPALA-2057: Better error message for incorrect avro decimal column declaration .. IMPALA-2057: Better error message for

[Impala-ASF-CR] IMPALA-4553: ntpd must be synchronized for kudu to start.

2016-11-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5258/1/testdata/cluster/admin File

[Impala-ASF-CR] IMPALA-4553: ntpd must be synchronized for kudu to start.

2016-11-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start. .. Patch Set 2: Code-Review+1 Carry Todd's +1 -- To view, visit http://gerrit.cloudera.org:8080/5258 To

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 12: Code-Review+1 (7 comments) I'm pretty happy with the changes. Let's let Dimitris

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 12: (7 comments) http://gerrit.cloudera.org:8080/#/c/5148/12//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-29 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5148 to look at the new patch set (#13). Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading ..

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5136 To

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. IMPALA-2890: Support ALTER TABLE statements for Kudu tables With this commit, we add

[Impala-ASF-CR] IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting

2016-11-29 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4504: fix races in PlanFragmentExecutor regarding status reporting .. Patch Set 4: Code-Review+1 (7 comments)

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 13: Code-Review+1 Thanks for the review Alex. Carrying +1. -- To view,

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2016-11-29 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 3: Any further thoughts on this? -- To view, visit

[Impala-ASF-CR] IMPALA-4554: fix projection of nested collections with mt dop > 0

2016-11-29 Thread Tim Armstrong (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5270 to look at the new patch set (#2). Change subject: IMPALA-4554: fix projection of nested collections with mt_dop > 0

[Impala-ASF-CR] IMPALA-4554: fix projection of nested collections with mt dop > 0

2016-11-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4554: fix projection of nested collections with mt_dop > 0 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4554: fix projection of nested collections with mt dop > 0

2016-11-29 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5270 Change subject: IMPALA-4554: fix projection of nested collections with mt_dop > 0 .. IMPALA-4554: fix projection of nested collections

[Impala-ASF-CR] IMPALA-4554: fix projection of nested collections with mt dop > 0

2016-11-29 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4554: fix projection of nested collections with mt_dop > 0 .. Patch Set 1: Code-Review+2 (1 comment) Perfect, thank you!

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 11: (40 comments)

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#12). Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. IMPALA-4172/IMPALA-3653: Improvements to block metadata loading This patch improves the

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2016-11-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 2: > Are any of these overflows legitimate use of signed overflows? > Assuming

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

2016-11-29 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 11: Audit event log has no link file, so there is no link file switch

[Impala-ASF-CR] IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.

2016-11-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04. .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-4543: Properly escape ignored tests subdirectories.

2016-11-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4543: Properly escape ignored tests subdirectories. .. Patch Set 1: (2 comments) Just wondering why we started hitting that ? Why isn't it showing up in

[Impala-ASF-CR] IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.

2016-11-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04. .. Patch Set 4: Build failed:

[Impala-ASF-CR] IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.

2016-11-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04. .. Patch Set 4: Build started:

[Impala-ASF-CR] Start a docs build system.

2016-11-29 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Start a docs build system. .. Start a docs build system. The docs can be built by running "make" from the docs directory. This does not hook into buildall.sh for now,

[Impala-ASF-CR] IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.

2016-11-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04. .. Patch Set 4: Build failed:

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-4553: ntpd must be synchronized for kudu to start.

2016-11-29 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5258 Change subject: IMPALA-4553: ntpd must be synchronized for kudu to start. .. IMPALA-4553: ntpd must be synchronized for kudu to start. When

[Impala-ASF-CR] IMPALA-4542: Fix use-after-free in some BE tests

2016-11-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4542: Fix use-after-free in some BE tests .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5243 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#8). Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. IMPALA-4172/IMPALA-3653: Improvements to block metadata loading This patch improves the

[Impala-ASF-CR] IMPALA-4000: Restricted Sentry authorization for Kudu Tables

2016-11-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4000: Restricted Sentry authorization for Kudu Tables .. IMPALA-4000: Restricted Sentry authorization for Kudu Tables At this time, there is

[Impala-ASF-CR] IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"

2016-11-29 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5259 Change subject: IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL" .. IMPALA-4527: Columns in Kudu

[Impala-ASF-CR] IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.

2016-11-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04. .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-29 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. Patch Set 10: Code-Review+2 Rebase. Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4542: Fix use-after-free in some BE tests

2016-11-29 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4542: Fix use-after-free in some BE tests .. IMPALA-4542: Fix use-after-free in some BE tests Change RuntimeState::ReleaseResources() to use

[Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading

2016-11-29 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#9). Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading .. IMPALA-4172/IMPALA-3653: Improvements to block metadata loading This patch improves the

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific

2016-11-29 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific .. IMPALA-3398: Rework Impala documentation to be non-Cloduera-specific This fix is a prototype

[Impala-ASF-CR] IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.

2016-11-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04. .. Patch Set 5: Code-Review+2 rebase carry -- To view, visit

[Impala-ASF-CR] IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04.

2016-11-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4512: Add a script that builds Impala on stock Ubuntu 14.04. .. Patch Set 5: Build started: