[Impala-ASF-CR] IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs

2017-02-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs .. Patch Set 1: (2 comments) Responding to comments. Will wait for next PS to continue the

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-02-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5668/7/docs/topics/impala_new_features.xml File

[Impala-ASF-CR] IMPALA-2518: DROP DATABASE CASCADE doesn't remove cache directives of tables

2017-02-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2518: DROP DATABASE CASCADE doesn't remove cache directives of tables .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/5815/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4792: Fix number of distinct values for a CASE with constant outputs

2017-02-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4792: Fix number of distinct values for a CASE with constant outputs .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5768

[Impala-ASF-CR] IMPALA-2518: DROP DATABASE CASCADE removes cache directives of tables

2017-02-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2518: DROP DATABASE CASCADE removes cache directives of tables .. Patch Set 2: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5828/3/be/src/exec/hdfs-scan-node-base.cc

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 3: (3 comments) Thanks for doing this, Bharath! Much better. Just a few more requests as final

[Impala-ASF-CR] IMPALA-3586 (Part 1): Implement Union Pass Through

2017-02-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3586 (Part 1): Implement Union Pass Through .. Patch Set 5: (42 comments) http://gerrit.cloudera.org:8080/#/c/5816/5//COMMIT_MSG Commit Message: Line 14:

[Impala-ASF-CR] IMPALA-4792: Fix number of distinct values for a CASE with constant outputs

2017-02-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4792: Fix number of distinct values for a CASE with constant outputs .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 5: (9 comments) Since we're accepting user input it would be great to have unit tests. Checking that

[Impala-ASF-CR] IMPALA-4792: Fix number of distinct values for a CASE with constant outputs

2017-02-01 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4792: Fix number of distinct values for a CASE with constant outputs .. Patch Set 6: (5 comments) I'm pretty happy with this change minus the remaining

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/5792/6/be/src/util/logging-support.cc File

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-03 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 5: Code-Review+2 (2 comments) Before you merge, let me ask Dan to take a quick look to see if

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5668/7/docs/topics/impala_incompatible_changes.xml File

[Impala-ASF-CR] Improvements to "Unknown disk-ID" warning

2017-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Improvements to "Unknown disk-ID" warning .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5828/1//COMMIT_MSG Commit Message: Line 7: Improvements

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 23: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-06 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5909/1/www/memz.tmpl File

[Impala-ASF-CR] IMPALA-4849: IllegalStateException from rewritten CASE expr

2017-02-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4849: IllegalStateException from rewritten CASE expr .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI

2017-02-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4884: Add JVM heap and non-heap usage in metrics and UI .. Patch Set 1: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 18: (2 comments)

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 19: (1 comment)

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5792/7/common/thrift/Logging.thrift File

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 19: (1 comment)

[Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes

2017-02-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5792/7/common/thrift/Logging.thrift File

[Impala-ASF-CR] IMPALA-4731: Crash when sorting on non-deterministic expr

2017-02-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4731: Crash when sorting on non-deterministic expr .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4849: IllegalStateException from rewritten CASE expr

2017-02-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4849: IllegalStateException from rewritten CASE expr .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5917 To unsubscribe,

[Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs

2017-02-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs .. Patch Set 20: (2 comments) FE lgtm +2

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 20: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5776 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 20: Trivial test fix +2 -- To view, visit http://gerrit.cloudera.org:8080/5776 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4818: Ensure the same number of tests are run every time

2017-02-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4818: Ensure the same number of tests are run every time .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5784 To

[Impala-ASF-CR] IMPALA-4675 Lowercase parquet column names prior to matching

2017-02-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4675 Lowercase parquet column names prior to matching .. Patch Set 2: (2 comments) Thanks for taking this on! Will you be able to add test cases? Please

[Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning

2017-02-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning .. Patch Set 4: (6 comments) So much better!

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-02 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/5776/10//COMMIT_MSG Commit Message: Line 13: Change-Id:

[Impala-ASF-CR] IMPALA-4792: Fix number of distinct values for a CASE with constant outputs

2017-01-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4792: Fix number of distinct values for a CASE with constant outputs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5768/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4263: Fix wrong ommission of agg/analytic hash exchanges.

2017-01-23 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/5774 Change subject: IMPALA-4263: Fix wrong ommission of agg/analytic hash exchanges. .. IMPALA-4263: Fix wrong ommission of agg/analytic hash

[Impala-ASF-CR] IMPALA-1654: [DOCS] DDL for multiple partitions

2017-01-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1654: [DOCS] DDL for multiple partitions .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5726 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/5776/2//COMMIT_MSG Commit Message: Line 11: since function

[Impala-ASF-CR] Remove 'without Cloudera Manager' from two titles

2017-01-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Remove 'without Cloudera Manager' from two titles .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5749 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5776/2//COMMIT_MSG Commit Message: Line 11: since function names

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-24 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-4055: Speed up to_date() with custom implementation. .. IMPALA-4055: Speed up to_date() with custom implementation. Simple implementation of to_date() that

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-24 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/5791 Change subject: IMPALA-4055: Speed up to_date() with custom implementation. .. IMPALA-4055: Speed up to_date() with custom implementation.

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5743 to look at the new patch set (#4). Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 3: (4 comments)

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: [DOCS] Add doc for MT_DOP query option. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5652 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 6: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/5743 To

[Impala-ASF-CR] IMPALA-4617: remove IsConstant() analysis from be

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4617: remove IsConstant() analysis from be .. Patch Set 9: Code-Review+2 FE changes lgtm. Dan any additional BE comments? -- To view, visit

[Impala-ASF-CR] IMPALA-4792: Fix number of distinct values for a CASE with constant outputs

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4792: Fix number of distinct values for a CASE with constant outputs .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5743 to look at the new patch set (#5). Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 5: Dan, Bharath, any more comments? -- To view, visit

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/4/fe/src/main/cup/sql-parser.cup File

[Impala-ASF-CR] IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4822: Dynamic log level changes to Catalog and Frontend JVMs .. Patch Set 1: (6 comments) This is awesome! Code looks good to me. If we really want to

[Impala-ASF-CR] IMPALA-4792: Fix number of distinct values for a CASE with constant outputs

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4792: Fix number of distinct values for a CASE with constant outputs .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4792: Fix number of distinct values for a CASE with constant outputs

2017-01-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4792: Fix number of distinct values for a CASE with constant outputs .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4055: Speed up to_date() with custom implementation. .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5791/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-25 Thread Alex Behm (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5791 to look at the new patch set (#4). Change subject: IMPALA-4055: Speed up to_date() with custom implementation. ..

[Impala-ASF-CR] IMPALA-4617: remove IsConstant() analysis from be

2017-01-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4617: remove IsConstant() analysis from be .. Patch Set 8: (5 comments)

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4055: Speed up to_date() with custom implementation. .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5791 To unsubscribe,

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4055: Speed up to_date() with custom implementation. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-25 Thread Alex Behm (Code Review)
Hello Jim Apple, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5791 to look at the new patch set (#5). Change subject: IMPALA-4055: Speed up to_date() with custom implementation.

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4055: Speed up to_date() with custom implementation. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-25 Thread Alex Behm (Code Review)
Hello Impala Public Jenkins, Jim Apple, Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5791 to look at the new patch set (#7). Change subject: IMPALA-4055: Speed up to_date() with custom implementation.

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2017-01-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 22: (10 comments) Thanks for the clarifications. Change looks

[Impala-ASF-CR] IMPALA-1654: DDL for multiple partitions

2017-01-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1654: DDL for multiple partitions .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5726/4/docs/topics/impala_alter_table.xml File

[Impala-ASF-CR] IMPALA-278: Mention DIV arithmetic operator.

2017-01-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-278: Mention DIV arithmetic operator. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5634/1/docs/topics/impala_math_functions.xml File

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4449: Revisit table locking pattern in the catalog

2017-01-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4449: Revisit table locking pattern in the catalog .. Patch Set 2: (1 comment)

[Impala-ASF-CR] Add doc for MT DOP query option.

2017-01-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Add doc for MT_DOP query option. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5652/1/docs/topics/impala_mt_dop.xml File

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-26 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5743 to look at the new patch set (#3). Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4792: Fix number of distinct values for a CASE with constant outputs

2017-01-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4792: Fix number of distinct values for a CASE with constant outputs .. Patch Set 2: (13 comments)

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

2017-01-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: [DOCS] Add doc for MT_DOP query option. .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5652/3/docs/topics/impala_mt_dop.xml File

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/5743/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-26 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5743 to look at the new patch set (#2). Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

[Impala-ASF-CR] IMPALA-278: Mention DIV arithmetic operator.

2017-01-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-278: Mention DIV arithmetic operator. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5634 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-25 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-4055: Speed up to_date() with custom implementation. .. IMPALA-4055: Speed up to_date() with custom implementation. Simple implementation of to_date() that

[Impala-ASF-CR] IMPALA-4055: Speed up to date() with custom implementation.

2017-01-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4055: Speed up to_date() with custom implementation. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4282: Remove max length check for type strings.

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-4282: Remove max length check for type strings. .. IMPALA-4282: Remove max length check for type strings. During analysis, Impala used to enforce the default

[Impala-ASF-CR] IMPALA-4854: Fix incremental stats with complex types.

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/6033 Change subject: IMPALA-4854: Fix incremental stats with complex types. .. IMPALA-4854: Fix incremental stats with complex types. The bug:

[Impala-ASF-CR] IMPALA-4282: Remove max length check for type strings.

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4282: Remove max length check for type strings. .. Patch Set 2: Ahh right. Thanks. Done. -- To view, visit http://gerrit.cloudera.org:8080/6034 To

[Impala-ASF-CR] IMPALA-4282: Remove max length check for type strings.

2017-02-15 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/6034 Change subject: IMPALA-4282: Remove max length check for type strings. .. IMPALA-4282: Remove max length check for type strings. During

[Impala-ASF-CR] IMPALA-4959: Avoid picking up the system's boost cmake module

2017-02-21 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#3). Change subject: IMPALA-4959: Avoid picking up the system's boost cmake module .. IMPALA-4959: Avoid picking up the system's boost cmake module In some systems with an old boost

[Impala-ASF-CR] IMPALA-4821: Update AVG() for DECIMAL V2

2017-02-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2 .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6038 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4282: Remove max length check for type strings.

2017-02-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4282: Remove max length check for type strings. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4282: Remove max length check for type strings.

2017-02-16 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4282: Remove max length check for type strings. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6034 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/5969/2/be/src/exprs/timestamp-functions.cc

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5969/2/be/src/exprs/expr-test.cc File

[Impala-ASF-CR] IMPALA-4821: Update AVG() for DECIMAL V2

2017-02-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2 .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6038/3//COMMIT_MSG Commit Message: Line 12: 2. precision

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5969/5/be/src/exprs/timestamp-functions.cc

[Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014

2017-02-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014 .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5969/5/be/src/exprs/timestamp-functions.cc

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6025/2/be/src/exprs/aggregate-functions-ir.cc File

[Impala-ASF-CR] IMPALA-4787: Optimize APPX MEDIAN() memory usage

2017-02-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4787: Optimize APPX_MEDIAN() memory usage .. Patch Set 4: (6 comments) I'm pretty happy with this patch.

[Impala-ASF-CR] IMPALA-4962: Fix SHOW COLUMN STATS for HS2

2017-02-22 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4962: Fix SHOW COLUMN STATS for HS2 .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6109/1/tests/hs2/test_fetch.py File

[Impala-ASF-CR] IMPALA-4981: Re-enable spilling with MT DOP.

2017-02-23 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/6131 Change subject: IMPALA-4981: Re-enable spilling with MT_DOP. .. IMPALA-4981: Re-enable spilling with MT_DOP. The initial changes for MT_DOP

[Impala-ASF-CR] IMPALA-3586: Implement union passthrough

2017-02-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3586: Implement union passthrough .. Patch Set 9: Code-Review+1 (1 comment) FE changes lgtm.

[Impala-ASF-CR] IMPALA-4982: Add parquet stats test

2017-02-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4982: Add parquet stats test .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4982: Add parquet stats test

2017-02-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4982: Add parquet stats test .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-4982: Add parquet stats test

2017-02-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4982: Add parquet stats test .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6130 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4848: Add WIDHT BUCKET() function

2017-02-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4848: Add WIDHT_BUCKET() function .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/6023/3/be/src/exprs/math-functions-ir.cc File

[Impala-ASF-CR] IMPALA-2328: Read support for min/max Parquet statistics

2017-02-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2328: Read support for min/max Parquet statistics .. Patch Set 11: (1 comment)

  1   2   3   4   5   6   7   8   9   10   >