[Impala-ASF-CR] IMPALA-3977: TransmitData() should not block

2017-01-19 Thread Anonymous Coward (Code Review)
Anonymous Coward #168 has posted comments on this change. Change subject: IMPALA-3977: TransmitData() should not block .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5491/4/be/src/runtime/data-stream-mgr.cc

[Impala-ASF-CR] IMPALA-4856: Port ImpalaInternalService to KRPC

2017-03-01 Thread Anonymous Coward (Code Review)
Anonymous Coward #168 has posted comments on this change. Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-13 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has uploaded a new patch set (#4). Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. IMPALA-3980: qgen: re-enable Hive as a target database Changes: * Added hive cli options back in

[Impala-ASF-CR] IMPALA-4028: Trim sentry config file path spaces while impala start.

2016-09-13 Thread Anonymous Coward (Code Review)
davy...@163.com has posted comments on this change. Change subject: IMPALA-4028: Trim sentry config file path spaces while impala start. .. Patch Set 3: We have developed a configuration management system through which

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-23 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-23 Thread Anonymous Coward (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4011 to look at the new patch set (#9). Change subject: IMPALA-3980: qgen: re-enable Hive as a target database ..

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-23 Thread Anonymous Coward (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4011 to look at the new patch set (#8). Change subject: IMPALA-3980: qgen: re-enable Hive as a target database ..

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-23 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 6: (1 comment) @Taras, comments addressed, new changes

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-23 Thread Anonymous Coward (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4419 to look at the new patch set (#7). Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-23 Thread Anonymous Coward (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4011 to look at the new patch set (#11). Change subject: IMPALA-3980: qgen: re-enable Hive as a target database ..

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-25 Thread Anonymous Coward (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4419 to look at the new patch set (#9). Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-24 Thread Anonymous Coward (Code Review)
Hello Michael Brown, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4419 to look at the new patch set (#8). Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-24 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-14 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has uploaded a new patch set (#2). Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. IMPALA-4101: qgen: Hive join predicates should only contains equality

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-14 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 5: > Uploaded patch set 5: Patch Set 4 was rebased. @Michael, not sure what happened

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-20 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 7: > This needs a committer's look. @Michael, do we know of a committer that has

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-21 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 4: (6 comments) @Michael, comments addressed.

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-21 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has uploaded a new patch set (#4). Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. IMPALA-4101: qgen: Hive join predicates should only contains equality

[Impala-ASF-CR] IMPALA-4028: Improve message for improper Sentry config file path to make extra spaces visible.

2016-09-19 Thread Anonymous Coward (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4309 to look at the new patch set (#5). Change subject: IMPALA-4028: Improve message for improper Sentry config file path to make extra spaces visible.

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-22 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-21 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-20 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has uploaded a new patch set (#3). Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. IMPALA-4101: qgen: Hive join predicates should only contains equality

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-16 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 6: > Uploaded patch set 6. Hey Michael, Apologies, yes you are correct, the tests

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-16 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 7: > > The hive-default.xml file under > > fe/src/test/resources/ is not a valid XML

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-16 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has uploaded a new patch set (#7). Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. IMPALA-3980: qgen: re-enable Hive as a target database Changes: * Added hive cli options back in

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-16 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has uploaded a new patch set (#6). Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. IMPALA-3980: qgen: re-enable Hive as a target database Changes: * Added hive cli options back in

[Impala-ASF-CR] IMPALA-4042: count(distinct NULL) fails on a view

2016-10-03 Thread Anonymous Coward (Code Review)
Anonymous Coward #216 has posted comments on this change. Change subject: IMPALA-4042: count(distinct NULL) fails on a view .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4042: count(distinct NULL) fails on a view

2016-10-03 Thread Anonymous Coward (Code Review)
Anonymous Coward #216 has posted comments on this change. Change subject: IMPALA-4042: count(distinct NULL) fails on a view .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

2016-11-06 Thread Anonymous Coward (Code Review)
davy...@163.com has uploaded a new patch set (#2). Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. .. IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

[Impala-ASF-CR] IMPALA-3167: Fix assignment of WHERE-clause predicate through grouping agg + outer join.

2016-11-07 Thread Anonymous Coward (Code Review)
Anonymous Coward #27 has posted comments on this change. Change subject: IMPALA-3167: Fix assignment of WHERE-clause predicate through grouping agg + outer join. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3167: Fix assignment of WHERE-clause predicate through grouping agg + outer join.

2016-11-07 Thread Anonymous Coward (Code Review)
Anonymous Coward #27 has posted comments on this change. Change subject: IMPALA-3167: Fix assignment of WHERE-clause predicate through grouping agg + outer join. .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-3398: Add docs to main Impala branch.

2016-11-14 Thread Anonymous Coward (Code Review)
Anonymous Coward #250 has posted comments on this change. Change subject: IMPALA-3398: Add docs to main Impala branch. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5014/1/docs/generatingImpalaDoc.md File

[Impala-ASF-CR] IMPALA-4036: show create table outputs invalid SQL for partitioned tables with comments

2017-01-09 Thread Anonymous Coward (Code Review)
joemcdonn...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/5648 Change subject: IMPALA-4036: show create table outputs invalid SQL for partitioned tables with comments .. IMPALA-4036:

[Impala-ASF-CR] IMPALA-4036: show create table outputs invalid SQL for partitioned table with comment

2017-01-09 Thread Anonymous Coward (Code Review)
joemcdonn...@cloudera.com has uploaded a new patch set (#2). Change subject: IMPALA-4036: show create table outputs invalid SQL for partitioned table with comment .. IMPALA-4036: show create table outputs invalid SQL for

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-12 Thread Anonymous Coward (Code Review)
zams...@cloudera.com has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 6: (2 comments) I realize this is already merged - simply learning how to use gerrit and

[Impala-ASF-CR] Remove audience="Cloudera" from DITAVal, replace with audience="hidden".

2017-01-05 Thread Anonymous Coward (Code Review)
Anonymous Coward #250 has posted comments on this change. Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden". .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3973: optional 2nd and 3rd arguments for instr().

2017-01-03 Thread Anonymous Coward (Code Review)
Anonymous Coward #268 has posted comments on this change. Change subject: IMPALA-3973: optional 2nd and 3rd arguments for instr(). .. Patch Set 2: Code-Review+1 Thanks for the doc update! -- To view, visit

[Impala-ASF-CR] DOCS-1757

2017-01-03 Thread Anonymous Coward (Code Review)
ambreen.k...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/5594 Change subject: DOCS-1757 .. DOCS-1757 Change-Id: Ibf5f387fa07cf988a99b9ede4066bfd2b27afe16 --- M

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

2017-04-06 Thread Anonymous Coward (Code Review)
Anonymous Coward #290 has posted comments on this change. Change subject: Impala and Hive have slightly different SQL they accept. .. Patch Set 1: The issue we (HivePMC) are trying dealing with is there are several entities

[Impala-ASF-CR](asf-site) Impala and Hive have slightly different SQL they accept.

2017-04-06 Thread Anonymous Coward (Code Review)
Anonymous Coward #290 has posted comments on this change. Change subject: Impala and Hive have slightly different SQL they accept. .. Patch Set 1: Do not use the term 'compatible' or imply it.

[Impala-ASF-CR] IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos.

2017-07-21 Thread Anonymous Coward (Code Review)
a...@phdata.io has posted comments on this change. Change subject: IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos. .. Patch Set 2: I think we should use

[Impala-ASF-CR] CDH-56987: Update sentry version to 2.0.0-cdh6.x-SNAPSHOT in impala

2017-07-25 Thread Anonymous Coward (Code Review)
kkal...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/7507 Change subject: CDH-56987: Update sentry version to 2.0.0-cdh6.x-SNAPSHOT in impala .. CDH-56987: Update sentry version to

[Impala-ASF-CR] CDH-56988: Update the sentry dependencies to reflect the new version of sentry

2017-07-25 Thread Anonymous Coward (Code Review)
kkal...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/7508 Change subject: CDH-56988: Update the sentry dependencies to reflect the new version of sentry .. CDH-56988: Update the sentry

[Impala-ASF-CR] CDH-56990: Fix impala code as sentry-policy-db package is removed in sentry 2.0.0-cdh6.x-SNAPSHOT

2017-07-25 Thread Anonymous Coward (Code Review)
kkal...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/7509 Change subject: CDH-56990: Fix impala code as sentry-policy-db package is removed in sentry 2.0.0-cdh6.x-SNAPSHOT .. CDH-56990:

[Impala-ASF-CR] CDH-56991: Implement new API's in AuthorizationPolicy

2017-07-25 Thread Anonymous Coward (Code Review)
kkal...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/7510 Change subject: CDH-56991: Implement new API's in AuthorizationPolicy .. CDH-56991: Implement new API's in AuthorizationPolicy

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-06 Thread Anonymous Coward (Code Review)
gaborkas...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/7363 Change subject: IMPALA-5511: Add process start time to debug web page .. IMPALA-5511: Add process start time to debug web

[Impala-ASF-CR] Problem: Improve error message when subquery is used in the ON clause

2017-08-04 Thread Anonymous Coward (Code Review)
psi...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/7588 Change subject: Problem: Improve error message when subquery is used in the ON clause .. Problem: Improve error message when

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-08 Thread Anonymous Coward (Code Review)
sakinape...@cloudera.com has uploaded a new patch set (#2). Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. IMPALA-5280: Coalesce chains of OR conditions to an IN predicate This change

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-12 Thread Anonymous Coward (Code Review)
sakinape...@cloudera.com has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 3: (17 comments) additional tests and changes to normalize binary

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-12 Thread Anonymous Coward (Code Review)
sakinape...@cloudera.com has uploaded a new patch set (#3). Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. IMPALA-5280: Coalesce chains of OR conditions to an IN predicate This change

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-07 Thread Anonymous Coward (Code Review)
sakinape...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/7110 Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. IMPALA-5280: Coalesce chains of OR

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-09 Thread Anonymous Coward (Code Review)
sakinape...@cloudera.com has posted comments on this change. Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. Patch Set 2: (21 comments) Responding to comments...

[Impala-ASF-CR] IMPALA-4252: Min-max runtime filters for Kudu

2017-10-16 Thread Anonymous Coward (Code Review)
Anonymous Coward #345 has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 ) Change subject: IMPALA-4252: Min-max runtime filters for Kudu .. Patch Set 6: (1 comment) link error while not include this

[Impala-ASF-CR] IMPALA-5362 : Preserve case-sensitivity in field titles

2017-11-15 Thread Anonymous Coward (Code Review)
ydjainopensou...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8555 Change subject: IMPALA-5362 : Preserve case-sensitivity in field titles .. IMPALA-5362 : Preserve case-sensitivity in field

[Impala-ASF-CR] IMPALA-5362 : Preserve case-sensitivity in field titles

2017-11-15 Thread Anonymous Coward (Code Review)
ydjainopensou...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8544 Change subject: IMPALA-5362 : Preserve case-sensitivity in field titles .. IMPALA-5362 : Preserve case-sensitivity in field