[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-31 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5668/3/docs/topics/impala_new_features.xml File

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-10 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5668/1/docs/topics/impala_incompatible_changes.xml File

[Impala-ASF-CR] Start a docs build system.

2016-12-01 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: Start a docs build system. .. Patch Set 2: Code-Review+1 LGTM. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/5238 To unsubscribe, visit

[Impala-ASF-CR] Add Apache license header to files in doc directory

2016-12-01 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: Add Apache license header to files in doc directory .. Patch Set 1: Code-Review+1 LGTM -- To view, visit http://gerrit.cloudera.org:8080/5232 To unsubscribe,

[Impala-ASF-CR] IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific

2016-12-01 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: IMPALA-3398: Rework Impala documentation to be non-Cloudera-specific .. Patch Set 2: For the goal mentioned, it LGTM. I'll defer to others for tag specific

[Impala-ASF-CR] Add thousands separator to cardinality in plan diagram

2017-01-05 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: Add thousands separator to cardinality in plan diagram .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5587/5/www/query_plan.tmpl File

[Impala-ASF-CR] add thousands separator to cardinality tested manually by visually validating the cardinality numbers have thousands separators

2017-01-03 Thread Greg Rahn (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5587 to look at the new patch set (#2). Change subject: add thousands separator to cardinality tested manually by visually validating the cardinality numbers have thousands separators

[Impala-ASF-CR] add thousands separator to cardinality

2017-01-03 Thread Greg Rahn (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5587 to look at the new patch set (#3). Change subject: add thousands separator to cardinality .. add thousands

[Impala-ASF-CR] [DOCS] Pare down ODBC info

2017-03-15 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: [DOCS] Pare down ODBC info .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6409 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3381: Support AM/PM marker in date and time format strings

2017-04-04 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: IMPALA-3381: Support AM/PM marker in date and time format strings .. Patch Set 2: (1 comment)

[Impala-ASF-CR] [DOCS] Add placeholder for DECIMAL V2 query option

2017-04-10 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: [DOCS] Add placeholder for DECIMAL_V2 query option .. Patch Set 2: Code-Review+1 lgtm -- To view, visit http://gerrit.cloudera.org:8080/6596 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5316: [DOCS] Document last day() function

2017-08-15 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: IMPALA-5316: [DOCS] Document last_day() function .. Patch Set 1: Code-Review+1 LGTM. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/7682 To

[Impala-ASF-CR] [DOCS] add EPOCH to list of units supported.

2017-07-06 Thread Greg Rahn (Code Review)
Greg Rahn has uploaded a new patch set (#2). Change subject: [DOCS] add EPOCH to list of units supported. .. [DOCS] add EPOCH to list of units supported. Per

[Impala-ASF-CR] [DOCS] Take out not-production-ready notice from ADLS page

2017-07-24 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: [DOCS] Take out not-production-ready notice from ADLS page .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7487/1/docs/shared/impala_common.xml

[Impala-ASF-CR] [DOCS] Take out not-production-ready notice from ADLS page

2017-07-24 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: [DOCS] Take out not-production-ready notice from ADLS page .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7487 To unsubscribe,

[Impala-ASF-CR] IMPALA-3894: Changed the behavior parsing 2-digit year values

2017-07-27 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: IMPALA-3894: Changed the behavior parsing 2-digit year values .. Patch Set 4: IIRC that's the calculation SimpleDateFormat uses for two digit years and likely

[Impala-ASF-CR] [DOCS] add EPOCH to list of units supported.

2017-06-29 Thread Greg Rahn (Code Review)
Greg Rahn has uploaded a new change for review. http://gerrit.cloudera.org:8080/7342 Change subject: [DOCS] add EPOCH to list of units supported. .. [DOCS] add EPOCH to list of units supported. Per

[Impala-ASF-CR] IMPALA-5326: [DOCS] Document REPLACE() function

2017-05-24 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: IMPALA-5326: [DOCS] Document REPLACE() function .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6979/1/docs/topics/impala_new_features.xml File

[Impala-ASF-CR] IMPALA-5326: [DOCS] Document REPLACE() function

2017-05-25 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: IMPALA-5326: [DOCS] Document REPLACE() function .. Patch Set 2: Code-Review+1 LGTM -- To view, visit http://gerrit.cloudera.org:8080/6979 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5326: [DOCS] Document REPLACE() function

2017-05-24 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: IMPALA-5326: [DOCS] Document REPLACE() function .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6979/1/docs/topics/impala_string_functions.xml File

[Impala-ASF-CR] IMPALA-5326: [DOCS] Document REPLACE() function

2017-05-24 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: IMPALA-5326: [DOCS] Document REPLACE() function .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6979/1/docs/topics/impala_string_functions.xml File

[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures

2017-10-06 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3504: [DOCS] Document utc timestamp()

2017-10-06 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/8190 ) Change subject: IMPALA-3504: [DOCS] Document utc_timestamp() .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5529: [DOCS] New trunc() signatures

2017-10-02 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/8189 ) Change subject: IMPALA-5529: [DOCS] New trunc() signatures .. Patch Set 3: > (1 comment) There should be TRUNC(timestamp) and

[Impala-ASF-CR] PREVIEW: IMPALA-3437: DECIMAL V2: avoid implicit decimal->double conversion

2017-09-12 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: PREVIEW: IMPALA-3437: DECIMAL_V2: avoid implicit decimal->double conversion .. Patch Set 4: Code-Review+1 LGTM -- To view, visit