Michael Ho has posted comments on this change.
Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER
TABLE ADD PARTITION
..
Patch Set 23:
Dimitris, can you please take a quick pass again to see if
Michael Ho has posted comments on this change.
Change subject: IMPALA-4810: Add DECIMAL_V2 query option
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5889
To unsubscribe, visit
Michael Ho has posted comments on this change.
Change subject: [DOCS] Add several items to "known issues" page
..
Patch Set 1:
Ping. Is this review thread still active ?
--
To view, visit http://gerrit.cloudera.org:8080/5809
Michael Ho has posted comments on this change.
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
Patch Set 8: Code-Review+2
Carry +2 forward.
--
To view, visit
Hello Dan Hecht, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5732
to look at the new patch set (#7).
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
Michael Ho has posted comments on this change.
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
Patch Set 6:
(8 comments)
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5732
to look at the new patch set (#6).
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
Michael Ho has posted comments on this change.
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
Patch Set 5:
(5 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
..
Patch Set 15: Code-Review+1
The fix for the UDA arg type makes sense to me.
--
To view, visit
Michael Ho has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 5:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4809: Add Stability for codegen constants
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5848/1//COMMIT_MSG
Commit Message:
PS1, Line
Michael Ho has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 5:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5933/1//COMMIT_MSG
Commit Message:
PS1,
Michael Ho has posted comments on this change.
Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven
..
Patch Set 2: Code-Review+2
(1 comment)
Michael Ho has posted comments on this change.
Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven
..
Patch Set 1: Code-Review+1
(2 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
Patch Set 4:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/5732/4//COMMIT_MSG
Commit
Michael Ho has posted comments on this change.
Change subject: IMPALA-4810: Add DECIMAL_V2 query option
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/5889/1//COMMIT_MSG
Commit Message:
Line 7: IMPALA-4810:
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5732
to look at the new patch set (#5).
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
Michael Ho has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 11:
(15 comments)
Please also add exprs.test as discussed offline to cover cases in which pattern
or replace are
Michael Ho has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 15: Code-Review+1
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5776/15/be/src/exprs/string-functions-ir.cc
File
Michael Ho has uploaded a new patch set (#4).
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen
This change fixes
Michael Ho has posted comments on this change.
Change subject: IMPALA-1430: enable codegen for native UDAs
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5161/11/be/src/exprs/agg-fn-evaluator.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-1430: enable codegen for native UDAs
..
Patch Set 12: Code-Review+1
(2 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
Patch Set 2:
(1 comment)
Michael Ho has posted comments on this change.
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
Patch Set 2:
(4 comments)
Michael Ho has uploaded a new patch set (#3).
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen
This change fixes
Michael Ho has posted comments on this change.
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
Patch Set 2:
(1 comment)
Michael Ho has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/5776/2/be/src/exprs/string-functions-ir.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5776/2/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4729: Implement REPLACE()
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5776/2/be/src/exprs/string-functions-ir.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4055: Speed up to_date() with custom implementation.
..
Patch Set 1:
(1 comment)
Nice change. A suggestion below.
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5483/6/be/src/exprs/expr.h
File be/src/exprs/expr.h:
Michael Ho has posted comments on this change.
Change subject: [DOCS] Add several items to "known issues" page
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5809/1/docs/topics/impala_known_issues.xml
File
Michael Ho has posted comments on this change.
Change subject: Update copyright year to 2017
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5754
To unsubscribe, visit
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#5).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
IMPALA-4192:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 4:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/5483/4//COMMIT_MSG
Commit Message:
PS4, Line 31:
Michael Ho has posted comments on this change.
Change subject: IMPALA-1430: enable codegen for native UDAs
..
Patch Set 11:
(1 comment)
Can you please address the question in agg-fn-evaluator.cc ? I can +1
afterwards.
Michael Ho has posted comments on this change.
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
Patch Set 1:
(8 comments)
Michael Ho has uploaded a new patch set (#2).
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen
This change fixes
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5483
to look at the new patch set (#6).
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
IMPALA-4192:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5483/6/be/src/exprs/expr.h
File be/src/exprs/expr.h:
Michael Ho has posted comments on this change.
Change subject: IMPALA-4055: Speed up to_date() with custom implementation.
..
Patch Set 3: Code-Review+2
Seems trivial enough for me to +2. Please feel free to have another
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6038
to look at the new patch set (#5).
Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2
..
IMPALA-4821: Update
Michael Ho has posted comments on this change.
Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6038/4//COMMIT_MSG
Commit Message:
PS4, Line 25: types
Michael Ho has posted comments on this change.
Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6068/2/be/src/exprs/expr-test.cc
File
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6038
to look at the new patch set (#3).
Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2
..
IMPALA-4821: Update
Michael Ho has posted comments on this change.
Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2
..
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/6038/2/be/src/exprs/aggregate-functions-ir.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2
..
Patch Set 2:
(1 comment)
Michael Ho has posted comments on this change.
Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts
..
Patch Set 22:
(1 comment)
Michael Ho has posted comments on this change.
Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts
..
Patch Set 22: Code-Review+1
(1 comment)
Michael Ho has posted comments on this change.
Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6038/3//COMMIT_MSG
Commit Message:
Line 12: 2.
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6038
to look at the new patch set (#4).
Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2
..
IMPALA-4821: Update
Michael Ho has posted comments on this change.
Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6068/2/be/src/exprs/expr-test.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-2020: Add rounding for decimal casts
..
Patch Set 15:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5951/15/be/src/benchmarks/expr-benchmark.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4809: Enable support for DECIMAL_V2 in decimal_casting.py
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5989/1//COMMIT_MSG
Commit
Michael Ho has posted comments on this change.
Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version
V2
..
Patch Set 11: Code-Review+1
(6 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-4810: fix incorrect expr-test decimal types
..
Patch Set 1:
Why doesn't this change also pull in the validation of the resulting Decimal
types to validate
Michael Ho has posted comments on this change.
Change subject: IMPALA-4810: fix incorrect expr-test decimal types
..
Patch Set 2: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5959/2/be/src/exprs/expr-test.cc
Michael Ho has posted comments on this change.
Change subject: IMPALA-4810: fix incorrect expr-test decimal types
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5959/2/be/src/exprs/expr-test.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2
..
Patch Set 2:
Verified there is no perf regression with decimal_v2=false using following
query:
select
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5950
to look at the new patch set (#3).
Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2
..
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5950
to look at the new patch set (#4).
Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2
..
Michael Ho has posted comments on this change.
Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2
..
Patch Set 4: Code-Review+2
Carry +2 forward.
--
To view, visit http://gerrit.cloudera.org:8080/5950
Michael Ho has posted comments on this change.
Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2
..
Patch Set 4:
Added decimal_v2 as a test dimension for decimal_casting.py. It's disabled for
now as we
Michael Ho has posted comments on this change.
Change subject: IMPALA-4809: Enable support for DECIMAL_V2 in decimal_casting.py
..
Patch Set 1:
(4 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version
V2
..
Patch Set 8:
(2 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-4842: BufferedBlockMgrTest.WriteError is flaky
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5940/3/common/thrift/generate_error_codes.py
Michael Ho has uploaded a new patch set (#2).
Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2
..
IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2
Currently, codegen supports converting type
Michael Ho has posted comments on this change.
Change subject: IMPALA-2020, IMPALA-4809: Codegen support for DECIMAL_V2
..
Patch Set 1:
(16 comments)
http://gerrit.cloudera.org:8080/#/c/5950/1//COMMIT_MSG
Commit Message:
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6038
Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2
..
IMPALA-4821: Update AVG() for DECIMAL_V2
This change implements the
Michael Ho has posted comments on this change.
Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/6038/1/be/src/exprs/aggregate-functions-ir.cc
File
Michael Ho has uploaded a new patch set (#2).
Change subject: IMPALA-4821: Update AVG() for DECIMAL_V2
..
IMPALA-4821: Update AVG() for DECIMAL_V2
This change implements the DECIMAL_V2's behavior for AVG().
The major
Michael Ho has posted comments on this change.
Change subject: IMPALA-1430: enable codegen for native UDAs
..
Patch Set 10:
(7 comments)
Looking good. Most comments about comments.
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5732
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some
Michael Ho has posted comments on this change.
Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with
codegen
..
Patch Set 1:
Quite a bit longer. 5~6 mins in debug builds on my machine. I think it's
Michael Ho has posted comments on this change.
Change subject: IMPALA-4192: Disentangle Expr and ExprContext
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5483/4/be/src/exec/hash-table-test.cc
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-3079: Fix sequence file writer
..
Patch Set 1:
(4 comments)
Some initial comments...
Michael Ho has posted comments on this change.
Change subject: IMPALA-3079: Fix sequence file writer
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/6107/1/be/src/exec/read-write-util.h
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-3079: Fix sequence file writer
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6107/1/be/src/exec/read-write-util.h
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue.
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4350/3/be/src/util/blocking-queue.h
Michael Ho has posted comments on this change.
Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue.
..
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/4350/3/be/src/util/blocking-queue.h
Michael Ho has uploaded a new patch set (#3).
Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue.
..
IMPALA-4026: Implement double-buffering for BlockingQueue.
With recent changes to improve the parquet
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4390
to look at the new patch set (#6).
Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code
..
Michael Ho has posted comments on this change.
Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code
..
Patch Set 5:
(4 comments)
Hello Dan Hecht, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4390
to look at the new patch set (#7).
Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code
Michael Ho has posted comments on this change.
Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code
..
Patch Set 6:
Will rebase before check-in.
--
To view, visit http://gerrit.cloudera.org:8080/4390
To
Michael Ho has posted comments on this change.
Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder
..
Patch Set 20: Code-Review+1
(1 comment)
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4350
to look at the new patch set (#10).
Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue
..
Michael Ho has posted comments on this change.
Change subject: IMPALA-4196: Cross compile bit-byte-functions
..
Patch Set 2:
(1 comment)
Michael Ho has uploaded a new patch set (#3).
Change subject: IMPALA-4180: Synchronize accesses to
RuntimeState::reader_contexts_
..
IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_
HdfsScanNodeBase::Close()
Michael Ho has posted comments on this change.
Change subject: IMPALA-4180: Synchronize accesses to
RuntimeState::reader_contexts_
..
Patch Set 2:
(4 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-4231: fix codegen time regression
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4623/1//COMMIT_MSG
Commit Message:
PS1, Line 26: y,
Michael Ho has posted comments on this change.
Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER
TABLE ADD PARTITION
..
Patch Set 14:
(11 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-4231: fix codegen time regression
..
Patch Set 2:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/4623/2/be/src/exec/partitioned-aggregation-node.h
File
Michael Ho has posted comments on this change.
Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()
..
Patch Set 1:
(3 comments)
FWIW, this patch probably needs to wait for
Michael Ho has uploaded a new patch set (#2).
Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()
..
IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()
This patch is mostly mechanical move of codegen
Michael Ho has posted comments on this change.
Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()
..
Patch Set 1:
(16 comments)
http://gerrit.cloudera.org:8080/#/c/4651/1//COMMIT_MSG
Commit Message:
PS1,
1 - 100 of 771 matches
Mail list logo
