[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change.

Change subject: Follow Apache Project Branding Requirements
..


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I263790d7c9aba7bfc57de7c16a367fe5204c49ff
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No


[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-29 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged.

Change subject: Follow Apache Project Branding Requirements
..


Follow Apache Project Branding Requirements

See: http://www.apache.org/foundation/marks/pmcs.html

Specifically:

1. Add TM to logo

2. Add links back to ASF

3. Add trademark notice to footers

Change-Id: I263790d7c9aba7bfc57de7c16a367fe5204c49ff
Reviewed-on: http://gerrit.cloudera.org:8080/4683
Reviewed-by: Jim Apple 
Tested-by: Jim Apple 
---
M bylaws.html
M community.html
M downloads.html
M img/impala-logo.png
M impala-docs.html
M index.html
M overview.html
7 files changed, 184 insertions(+), 57 deletions(-)

Approvals:
  Jim Apple: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I263790d7c9aba7bfc57de7c16a367fe5204c49ff
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-29 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change.

Change subject: Follow Apache Project Branding Requirements
..


Patch Set 3: Code-Review+2

(1 comment)

Carry +2

http://gerrit.cloudera.org:8080/#/c/4683/2/community.html
File community.html:

Line 147: 
> Maybe lose some of this whitespace?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I263790d7c9aba7bfc57de7c16a367fe5204c49ff
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes


[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-29 Thread Jim Apple (Code Review)
Hello Henry Robinson,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4683

to look at the new patch set (#3).

Change subject: Follow Apache Project Branding Requirements
..

Follow Apache Project Branding Requirements

See: http://www.apache.org/foundation/marks/pmcs.html

Specifically:

1. Add TM to logo

2. Add links back to ASF

3. Add trademark notice to footers

Change-Id: I263790d7c9aba7bfc57de7c16a367fe5204c49ff
---
M bylaws.html
M community.html
M downloads.html
M img/impala-logo.png
M impala-docs.html
M index.html
M overview.html
7 files changed, 184 insertions(+), 57 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/4683/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I263790d7c9aba7bfc57de7c16a367fe5204c49ff
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 


[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-28 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change.

Change subject: Follow Apache Project Branding Requirements
..


Patch Set 2: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4683/2/community.html
File community.html:

Line 147: 
Maybe lose some of this whitespace?


http://gerrit.cloudera.org:8080/#/c/4683/2/downloads.html
File downloads.html:

PS2, Line 161: navbar
Will trust you that this looks correct and is semantically reasonable.


-- 
To view, visit http://gerrit.cloudera.org:8080/4683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I263790d7c9aba7bfc57de7c16a367fe5204c49ff
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes


[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change.

Change subject: Follow Apache Project Branding Requirements
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4683/1/bylaws.html
File bylaws.html:

PS1, Line 134: 
 : 
 : 
 : 
> I don't quite understand this change - is all the content going in the mast
This is a separate issue that I threw in here to get this one page to have the 
same width for the body text as the other pages.


http://gerrit.cloudera.org:8080/#/c/4683/1/downloads.html
File downloads.html:

PS1, Line 176: 
 : 
 : 
 : Apache Impala is an effort undergoing incubation at the 
Apache Software Foundation
 : (ASF), sponsored by the Apache Incubator PMC. Incubation is 
required of all newly
 : accepted projects until a further review indicates that the 
infrastructure,
 : communications, and decision making process have stabilized 
in a manner consistent
 : with other successful ASF projects. While incubation status 
is not necessarily a
 : reflection of the completeness or stability of the code, it 
does indicate that the
 :   project has yet to be fully endorsed by the ASF.
 : 
 : Apache Impala, Impala, Apache, the Apache feather logo, 
and the Apache Impala
 : project logo are either registered trademarks or trademarks 
of The Apache Software
 : Foundation in the United States and other countries.
 : 
 :   
> Can you try and keep the indentation consistent for s? It's hard to se
I'm not thrilled with the indentation for these pages, either. 
https://issues.cloudera.org/browse/IMPALA-4307


-- 
To view, visit http://gerrit.cloudera.org:8080/4683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I263790d7c9aba7bfc57de7c16a367fe5204c49ff
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes


[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-17 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2).

Change subject: Follow Apache Project Branding Requirements
..

Follow Apache Project Branding Requirements

See: http://www.apache.org/foundation/marks/pmcs.html

Specifically:

1. Add TM to logo

2. Add links back to ASF

3. Add trademark notice to footers

Change-Id: I263790d7c9aba7bfc57de7c16a367fe5204c49ff
---
M bylaws.html
M community.html
M downloads.html
M img/impala-logo.png
M impala-docs.html
M index.html
M overview.html
7 files changed, 186 insertions(+), 53 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/4683/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I263790d7c9aba7bfc57de7c16a367fe5204c49ff
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Henry Robinson 


[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change.

Change subject: Follow Apache Project Branding Requirements
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4683/1/bylaws.html
File bylaws.html:

PS1, Line 134: 
 : 
 : 
 : 
I don't quite understand this change - is all the content going in the masthead 
or navbar div now?


http://gerrit.cloudera.org:8080/#/c/4683/1/downloads.html
File downloads.html:

PS1, Line 176: 
 : 
 : 
 : Apache Impala is an effort undergoing incubation at the 
Apache Software Foundation
 : (ASF), sponsored by the Apache Incubator PMC. Incubation is 
required of all newly
 : accepted projects until a further review indicates that the 
infrastructure,
 : communications, and decision making process have stabilized 
in a manner consistent
 : with other successful ASF projects. While incubation status 
is not necessarily a
 : reflection of the completeness or stability of the code, it 
does indicate that the
 :   project has yet to be fully endorsed by the ASF.
 : 
 : Apache Impala, Impala, Apache, the Apache feather logo, 
and the Apache Impala
 : project logo are either registered trademarks or trademarks 
of The Apache Software
 : Foundation in the United States and other countries.
 : 
 :   
Can you try and keep the indentation consistent for s? It's hard to see 
where this lines up relative to the navbar div above.


-- 
To view, visit http://gerrit.cloudera.org:8080/4683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I263790d7c9aba7bfc57de7c16a367fe5204c49ff
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple 
Gerrit-Reviewer: Henry Robinson 
Gerrit-HasComments: Yes


[Impala-ASF-CR](asf-site) Follow Apache Project Branding Requirements

2016-10-11 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4683

Change subject: Follow Apache Project Branding Requirements
..

Follow Apache Project Branding Requirements

See: http://www.apache.org/foundation/marks/pmcs.html

Specifically:

1. Add TM to logo

2. Add links back to ASF

3. Add trademark notice to footers

Change-Id: I263790d7c9aba7bfc57de7c16a367fe5204c49ff
---
M bylaws.html
M community.html
M downloads.html
M img/impala-logo.png
M impala-docs.html
M index.html
M overview.html
7 files changed, 166 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/83/4683/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I263790d7c9aba7bfc57de7c16a367fe5204c49ff
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: Jim Apple