[Impala-ASF-CR] IMPALA-2422: Fix escaping in LIKE clause

2017-08-29 Thread Alex Behm (Code Review) 
Alex Behm has abandoned this change.

Change subject: IMPALA-2422: Fix escaping in LIKE clause
..


Abandoned

Needs a more involved solution as discussed in the JIRA.

-- 
To view, visit http://gerrit.cloudera.org:8080/7660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iec0f5d99c855ea8d4fe1bcf28c05780ba315034b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht

[Impala-ASF-CR] IMPALA-2422: Fix escaping in LIKE clause

2017-08-14 Thread Dan Hecht (Code Review) 
Dan Hecht has posted comments on this change.

Change subject: IMPALA-2422: Fix escaping in LIKE clause
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7660/2/be/src/exprs/like-predicate.cc
File be/src/exprs/like-predicate.cc:

Line 34: // A regex to match any regex pattern is equivalent to a substring 
search.
isn't this comment referring to line 38? assuming so, it should be kept 
adjacent it it.


-- 
To view, visit http://gerrit.cloudera.org:8080/7660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec0f5d99c855ea8d4fe1bcf28c05780ba315034b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm 
Gerrit-Reviewer: Dan Hecht 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-2422: Fix escaping in LIKE clause

2017-08-11 Thread Taras Bobrovytsky (Code Review) 
Taras Bobrovytsky has uploaded a new patch set (#2).

Change subject: IMPALA-2422: Fix escaping in LIKE clause
..

IMPALA-2422: Fix escaping in LIKE clause

There are two stages to processing a like clause. First, we determine if
it is possible to convert the expression to a simpler function, such as
StartsWith() or EndsWith(). If not, then we use a Regex libarary to
compute the result.

There was a problem in the logic that determines if it is possible to
use a simpler function. It did not take into account escape characters.
For example, "abc\%" was incorrectly converted to StartsWith("abc\").

Testing:
-Added expr tests.

Change-Id: Iec0f5d99c855ea8d4fe1bcf28c05780ba315034b
---
M be/src/exprs/expr-test.cc
M be/src/exprs/like-predicate.cc
2 files changed, 28 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/7660/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iec0f5d99c855ea8d4fe1bcf28c05780ba315034b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm

[Impala-ASF-CR] IMPALA-2422: Fix escaping in LIKE clause

2017-08-11 Thread Taras Bobrovytsky (Code Review) 
Taras Bobrovytsky has uploaded a new patch set (#2).

Change subject: IMPALA-2422: Fix escaping in LIKE clause
..

IMPALA-2422: Fix escaping in LIKE clause

There are two stages to processing a like clause. First, we determine if
it is possible to convert the expression to a simpler function, such as
StartsWith() or EndsWith(). If not, then we use a Regex libarary to
compute the result.

There was a problem in the logic that determines if it is possible to
use a simpler function. It did not take into account escape characters.
For example, "abc\%" was incorrectly converted to StartsWith("abc\").

Testing:
-Added expr tests.

Change-Id: Iec0f5d99c855ea8d4fe1bcf28c05780ba315034b
---
M be/src/exprs/expr-test.cc
M be/src/exprs/like-predicate.cc
2 files changed, 28 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/7660/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iec0f5d99c855ea8d4fe1bcf28c05780ba315034b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky 
Gerrit-Reviewer: Alex Behm

[Impala-ASF-CR] IMPALA-2422: Fix escaping in LIKE clause

2017-08-11 Thread Taras Bobrovytsky (Code Review) 
Taras Bobrovytsky has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7660

Change subject: IMPALA-2422: Fix escaping in LIKE clause
..

IMPALA-2422: Fix escaping in LIKE clause

There are two stages to processing a like clause. First, we determine if
it is possible to convert the expression to a simpler function, such as
StartsWith() or EndsWith(). If not, then we use a Regex libarary to
compute the result.

There was a problem in the logic that determines if it is possible to
use a simpler function. It did not take into account escape characters.
For example, "abc\%" was incorrectly converted to StartsWith("abc\").

Testing:
-Added expr tests.

Change-Id: Iec0f5d99c855ea8d4fe1bcf28c05780ba315034b
---
M be/src/exprs/expr-test.cc
M be/src/exprs/like-predicate.cc
2 files changed, 28 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/7660/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec0f5d99c855ea8d4fe1bcf28c05780ba315034b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky